* Increment package version after release of azure-messaging-eventhubs
* Increment package version after release of azure-messaging-eventhubs-checkpointstore-blob
* Remove OPENSSL_VERSION_NUMBER version check for the CAPath option in
libcurl.
* Revert unit test change that caused an intentional error.
* Remove the openssl header.
* Change the default option for authority host to be read from the environment first.
* Update changelog.
* Update doc comment and refer to the env var correctly.
* Update doc comments and add unit tests.
* Acknowledge community contribution in the changelog
* Update cspell.json
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Added eventhubs test collateral to create and destroy eventhubs namespaces and eventhubs; Added peek message functionality to AMQP
* Use HTTP to talk to management APIs instead of az cli
* Azure Identity September Release
* Update release date in CHANGELOG.md
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Modify the order of the credentials used within the to be consistent with other languages.
* Update LogMessages test since the order of credentials has changed.
* Fix the order for the rest of the log messages within the test.
* Update svg and clang format.
There are two significant parts to this fix. The first is that the Connection object now has a method EnableAsyncOperation which registers the connection with a background thread which polls the connection. The EnableAsyncOperation needs to be callable from outside the connection because in normal client operation, the calls to open the connection are all internal to uAMQP. That means that the message sender and receiver need to call it when they're opened (and closed).
The other major part of this change is that the AsyncOperationQueue now has a WaitForRequest API which does not normally poll (there is a test hook which enables polling but that is not normally used in most scenarios).
The other part of this change fixes some concurrency issues associated with the Log::Stream functionality.
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/core/azure-core/src/logger.cpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/core/azure-core/test/ut/CMakeLists.txt
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/core/azure-core/test/ut/logging_test.cpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Added ASAN as an option, converted transports to be bases to ensure consistancy
---------
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Add WorkloadIdentityCredential to the DefaultAzureCredential.
* Clang format and update the CL.
* Address PR feedback - update CL, and SVG
* Define the required AZURE_FEDERATED_TOKEN_FILE env variable in the test.
* Update DAC unit test to include WIC in the log messages.
* Make several params to WorkloadIdentityCredential optional and read them from the environment instead.
* Fix typo in calling the ClientCredentialCore ctor
* Add changelog entry.
* Address PR feedback, avoid creating many WIC options instances.
* Update ctor impl and add options test.
* Set locals if the options are non-empty, and void unused variable in tests.
* Fixup the sample since the customer no longer needs to explicitly pass in those params.
* Increment package version after release of azure-storage-common
* Increment package version after release of azure-storage-blobs
* Increment package version after release of azure-storage-files-datalake
* Increment package version after release of azure-storage-files-shares
* Increment package version after release of azure-storage-queues
* Better cmake UWP detection condition (use the same definition as vcpkg)
* Update Config.cmake.in
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Add dependency to WIL in azure-identity-cpp when on WIndows.
* Use Win32 APIs to get the thumbprint and private key of a certificate.
* Don't use `out_param_ptr` in `GetPrivateKey`.
`NCRYPT_KEY_HANDLE` is not a pointer but a uintptr and using `out_param_ptr` with it causes compiler errors.
* Use Win32 APIs to sign messages with a private key.
* Remove the OpenSSL dependency from azure-identity-cpp on Windows.
We can't remove it from the root vcpkg.json that gets used for development, because an attestation example uses OpenSSL for certificate code.
* Update the changelog.
* Fix compile errors.
We can't use WIL in the public headers; we will use instead the same approach with the OpenSSL handles.
* Fix more compile errors.
* Use `AZ_PLATFORM_WINDOWS`.
* clang-format
* Update cspell.json
* Update CHANGELOG.md
* Update cspell.json
* Update cspell.json
* Attempt to make spell checker happy with minimum changes
* Ignore `CMakeUserPresets.json`.
* Move to the BCrypt APIs in anticipation of the rewrite.
* Use Windows APIs to read the certificate and the private key in PEM format.
* Move decoding the PEM string to its own function.
* Remove redundant error messages from some checks.
WIL does not recommend them if they do not provide additional information, and it already captures the source location.
* Support opening raw RSA and ECC private keys.
* Stop using pseudo-handles.
They are not supported in Windows Server 2012 R2, which is still supported.
* Fix CI.
* Refactor the ClientCertificateCredential tests and test more certificates.
Thanks to googletest's parameterized tests, duplicate code was eliminated and we test twelve cases with only two test methods.
* Improve code sharing across OpenSSL and CNG.
* Fix error checks when signing.
* Remove ECC certificate support.
Turns out Microsoft identity platform itself does not support them.
* Replace `#ifdef` with `#if defined`.
* Move some CryptoAPI-related terms to a `cspell.json` file local to `azure-identity`.
* Exclude the root `cspell.json` file from gitignore.
* Clean-up `cspell.json`.
* Fix linked libraries of `azure-identity`.
We don't use ncrypt anymore.
* Move `platform.hpp` to `client_certificate_credential.cpp`.
* Clean-up `UniquePrivateKey` and reduce mentions of `pkey`.
---------
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update core ci.yml so that some CI pipeline runs when modifying markdown files at the root of the repo
* Update ci.yml for PRs.
* Update README.md to test that CI triggers.
* Check why wildcard isn't working as expected
* Try wrapping wildcard in quotes since it is at the start of the path to trigger
* Added link credit support to message sender and receiver; reworked message receiver creation to move to the partition client object
* Added round trip test, including filters; fixed a hang with the consumer client caused by no messages; fixed checkpoint store storage names.
* EventDataBatch is created from EventProducer. Fixes#4868
* SendEventDataBatch renamed to Send; pass in Context on methods which require a context
* Added producer client send APIs without requiring an explicit event data batch
* close message receiver in destructor if it is open
* Consumer client and producer client only create message sender and receiver when needed
* Update sas test
* add test case and test records
* fix import file
* fix import files
* update record
* fix test name
* fix conversations
* update test
* fix clang format
* Increment package version after release of azure-storage-common
* Increment package version after release of azure-storage-blobs
* Increment package version after release of azure-storage-files-datalake
* Increment package version after release of azure-storage-files-shares
* Increment package version after release of azure-storage-queues
* bahavior -> behavior
* Update transport_adapter_base_test.hpp to fix the typo
* Update blob_base_test.hpp to fix the typo
* Update cspell.json to exclude bahavior is a valid word in the dictionary
---------
Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>
* Added azure_test resources to test-resources.json
* Add RBAC roles to created eventhubs instances
* Eventhubs samples read from the start of the partition, not the end.
* Scaffolding for eventhubs perf test
* Added eventhubs 'stress' test, which is really a totally broken perf test'
* Added stress test skeleton
* EventHubs Stress test is an actual eventhubs test now
* EventHubs throws exceptions on producer client failure. Rationalized error reporting from AMQP - message sender and receiver generate the same errors.
* Rationalize AMQP error results; throw exceptions on eventhubs errors
* Fixed amqp management test; added HTTP status code for management triggered exceptions
* Event Data binary no longer takes an AMQP binary; Preliminary readme.md for eventhubs (still many go constructs in the readme)
* Created the first eventhubs samples - they don't do much but they work
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* API Review feedback
* Added isTransient flag to eventhubs exception based on Java implementation
* Updated AMQP changelog to reflect recent changes
---------
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Storage/STG90-Data Lake Pagination Delete (#4816)
* add pagination delete
* remove id and secret
* fix spell
* add clientConfiguartion to all clients
* fix doxygen doc
* fix conversation
* add unit tests
* fix cspell
* fix clang format
* update test code
* update test case
* update record
* Storage/Archive to Cold Tier Rehydration (#4825)
* add RehydratePendingToCold
* add unit test
* update changelog.md
* update record
* soft delete test
* enable setTierCold
* IsConnectionReuse in record-playback mode
* DISABLED_UploadPagesFromUriCrc64AccessCondition
* update recording assets
* ClientSecretCredentialWorks works in record-playback mode
* ServiceContainerSasPermissions and ServiceBlobSasPermissions work in record-playback mode
* BlobServiceClientTest.UserDelegationKey works in record-playback mode
* update recordings
* f
* Clean up version requirements
* Revert curl back to 7.44
* Update vcpkg.json
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Move eventhubs under messaging
* Update cmakefile
* cspell
* Do it the other way
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Disable libcurl globalCleanUp test until it has been investigated
* Update curl_connection_pool_private.hpp friend class name for the disabled test
* Update curl_session_private.hpp friend class name for the disabled test
* Increment package version after release of azure-storage-common
* Increment package version after release of azure-storage-blobs
* Increment package version after release of azure-storage-files-datalake
* Increment package version after release of azure-storage-files-shares
* Update vcpkg baseline
* Update in another place as well
* Remove default-features requirement for telemetry and amqp in manifest mode
* Also remove default-features for storage
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Enable phasing out a breaking change in Code in a step-by-step manner
* Update messages
* Fully qualify namespace in Changelog
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Identity: Improve diagnosability
* Update sdk/identity/azure-identity/src/azure_cli_credential.cpp
Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
* GCC fix
* Mac fix
* More agressive sanitizing
* cspell
* minor CI fixes
* Improve
* More tests
* min/max values test
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
* Update key_client_create_test_live.cpp to remove dependency on attestation headers
* Update CMakeLists.txt to remove linking to azure-security-attestation
* Update CMakeLists.txt in hsm unit tests to remove linking to azure-security-attestation
* doxygen fixes
* enable doxygen errors now that doxygen is updated.
---------
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Switched management implementation to use message sender and receiver instead of uAMQP implementation.
* Made value conversion to AmqpValue explicit to work around what appears to be a gcc9 bug
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* pull request feedback
---------
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Fixes#4696 - Added support to Log::Write to use insertion operators for logging
* EnvironmentLogger writes to stderr on errors, stdout for non-errors; Also don't double insert crlf in messages
---------
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Added amqp_definitions_fields to list of 'special' uAMQP headers
* Tidy up x64-static-debug-perftests preset
* Moved test functions to private and use friend functions for tests; Renamed Management to ManagementClient and made it constructable from Session.
---------
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Fix live tests CI compilation (unused variable warning - gets treated as error)
* A warning popped up in opentelemetry due to header reordering
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Disable deprecation warnings in cmakelists.txt to avoid introducing new concepts; removed unnecessary uses of get_env.hpp
* Removed use of GetEnvHelper from AMQP samples
* Removed special case for get_env.hpp
* Increment package version after release of azure-storage-blobs
* Increment package version after release of azure-storage-files-datalake
* Increment package version after release of azure-storage-files-shares
* Standardized header ordering for C++ repo
* Reordered categories to move private headers above public headers; added space between categories to enable future flexibility
* Prep for readonly connection
* Added options for Connection and Session to enable read-only configuration
* Read-only connection and session objects; use message source and target for message sender and receiver
* Enabled read-only session; added tests for incorrect AMQPS port
* Added token reader sample; flushed out eventhubs properties sample, added some timeouts to send async test
* Moved AMQP samples to internal
* Moved samples to use GetEnvHelper
---------
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* add test helper
* constructible from Args
* restucture ClassTraits to ensure portability of static constexpr
* fix Etags tests and format
* clang format
# This pull request moves the core AMQP functionality to main. It is still very much a work in progress, but moving it to main will reduce the complexity associated with working in feature branches.
---------
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com>
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: George Arama <50641385+gearama@users.noreply.github.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Increment package version after release of azure-security-keyvault-keys
* Increment package version after release of azure-security-keyvault-certificates
* Increment package version after release of azure-security-keyvault-secrets
* Increment package version after release of azure-storage-common
* Increment package version after release of azure-storage-files-datalake
* Increment package version after release of azure-storage-files-shares
* Minor tweak to event-processor.yml to trigger cspell checks
* Cosmetic change to context_test.cpp in azure-core to trigger CI pipelines
* Update cspell.json to include OIDC
* Increment package version after release of azure-security-keyvault-keys
* Increment package version after release of azure-security-keyvault-administration
* Increment package version after release of azure-security-keyvault-secrets
* Increment package version after release of azure-security-keyvault-certificates
* Update README.md to fix markdown linter errors
* Re-apply changes to filter out whitespace artifacts
* Add a single space after a period at the end of the sentence.
* Update datetime.cpp
Make a cosmetic change to a src file to trigger CI.
* First cut at migrating Ubuntu 18 to 22 directly in the matricses
* Try 20.04
* Remove azure.list from apt configuration on 22.04
* Parens
* gpp-8 on Ubuntu 20.04
* Remove g++-5
* Move config changes to steps/
* Remove g++-5 from live tests
* Update eng/pipelines/templates/steps/fix-linux-1es-configs.yml
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Review feedback
* Finish renaming
* Setting line coverage target to 91%
---------
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Fix potentially high CPU usage on Windows
* Undo unnecessary formatting
* Undo unnecessary changelog
* Undo unnecessary formatting
* Undo unnecessary formatting
* Uninclude locale
* Add issue link to changelog
* EXPECT_TRUE(a == b) => EXPECT_EQ(a, b)
* Update second changelog with link as well
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Tests: replace most `EXPECT_TRUE(a OP b)` with `EXPECT_OP(a, b)`
* Undo unnecessary change
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Use aka.ms link to Identity troubleshooting
* Update default_azure_credential.cpp
* Update default_azure_credential.cpp
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Increment package version after release of azure-storage-common
* Increment package version after release of azure-storage-blobs
* Increment package version after release of azure-storage-files-shares
* FIrst cut at removing proxy tests
Changed the proxy tests from opt-out to opt-in so they're disabled by default. Removed lines enabling proxy from ci.yml file.
* Identity February Release
* Accumulate changelog entries from previous Beta releases
* Update core minimum version requirement
* Best way to fix which may not work in CI
* Drop version from cmakelists
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* lll
* sss
* oipio
* vcvc
* enable test proxy start at test suite start for KV and storage , example created for attestation, we cannot find the base definitions for the test suites,
* Contrib
* clangs
* clangs
* test logs
* pipeline
* more clangs
* pipeline
* clang
* try try again
* try try again
* try again
* try again
* again
* update paths , moved to macro , call macro in target code
* core
* capitalization
* kv release
* ds
* Update sdk/keyvault/azure-security-keyvault-administration/CHANGELOG.md
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* core to latest GA
* 1.8.0
* update folder list
* put to stable versions
* put back to last GA
* put back to original
* try core 1.8.0
* Revert "try core 1.8.0"
This reverts commit 1e0b612235dfa60e7be60819a2076cb6bc266813.
---------
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Modify files by adding an extra space to trigger spell check on all.
* Modify newer files.
* Modify new files that got added.
* Modify all markdown files to trigger spell check on those.
* Fix spelling errors and update cspell to remove out-dated exceptions.
* Add back mypgrogram exception for the readme from azure-core.
* Revert test edits to markdown files.
* Revert test changes to source and header files.
* Remove modification to leftover source files.
* Compilation fixes for UWP
* More accurate condition
* Fix warnings
* Format files as vcpkg formats them; pull one change back from vcpkg
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Make sure PRs modifying markdown files within the repo get CI triggered
* Update ci.yml for core to trigger on any markdown file change.
* Test to see if wildcards work as expected
* Update wildcard to include any markdown file, with a path
* Revert README.md file change.
* Modify a markdown file in a nested directory to see if core ci is triggered.
* Exclude sdk/core from the trigger to see if wildcard works correctly.
* Add back sdk/core
* Revert samples markdown change.
* Added deprecated constructors for attestation service
* Disable deprecation warnings for clang; improved documentation to reflect deprecated functions
* Use doxygen @deprecated on deprecated functions
*
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
---------
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Policies do not overwrite HTTP headers if they are already set
* Use static constant UserAgent
---------
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Ignore warning C4100 on Windows for unused parameter in OpenTelemetry
headers.
* Disable other warnings like 4244 and 6323 as well.
* Clang format fix.
* Add CI pipeline step and script that validates all files in the repo contain ASCII-only bytes and no UTF-8 BOM
* Update platform-matrix.json to turn on CHECK_ASCII_CHARACTERS
* Fix missing comma in json.
* Update indentation in the ci.test.yml for the bash script
* Exclude the .github folder and test recording json files.
* Remove "recordings" exclusion since it doesn't exist anymore.
* Fixed UTF-8 with BOM and other non-ASCII character issues within the
files in the repo.
* Exclude nlohmann json tests from ASCII validation check.
* Log an intro to the CI console for the validation step.
* Remove codecoverage.cmake exclusion.
* Remove exclusion for docs and tools directories.
- Made Context immutable (including marking the static ApplicationContext as const
- Put back TelemetryPolicy in all pipeline cases and removed User-Agent generation from RequestActivityPolicy (note: This part of the change may end up being reverted). Also updated parameters for TelemetryPolicy to make it clearer that the parameter is a package name, not a service name.
- Changed Az.Namespace value from being the package name to being the service name.
- Change test SpanExporter to fully capture exported values rather than keeping references to the values.
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Experiment with CI and MultipleCrlOperations test
* Switch to an older, less failure-proof version of the test from yesterday
* Switch Ubuntu18 to Azure Pipelines as well
* Undo CI changes just to make sure it fails
* Apply CI machine pool changes
* Move Ubuntu20 to general pool
* Move Ubuntu20 to general pool
* Move Ubuntu20 to perf pool
* Revert all changes in platform-matrix.json
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
* skeletor
* client
* rework
* all works plus test
* sample , self pr
* tests
* clang
* Mind your language .. Sir ...
* comments
* removed preprocessor directives
* removed template class
* dll clang
* Rick PR
* Create ApiViewSettings for most existing packages
* Corrected name for blobs storage review name
* Added cspell settings for DCURL
* Create ApiViewSettings for most existing packages
* Corrected name for blobs storage review name
* Added cspell settings for DCURL
* ApiView settings changes for DataLake
* Renamed includeInternal to allowInternal; Added storage common; Fixed package names
* Fixed spelling error
* If there's an error accessing the site with no CRL checks, don't try it any more
* Stop checking example.com because it doesn't work
* Update sdk/attestation/azure-security-attestation/inc/ApiViewSettings.json
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Update sdk/core/azure-core/inc/ApiViewSettings.json
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Update sdk/keyvault/azure-security-keyvault-secrets/inc/ApiViewSettings.json
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Move Request ctor impl to the request.cpp file instead of http.cpp
* Add the ctors to request.cpp
* Remove null body stream header from http.cpp
* Remove unused namespace using
* Add _internal using namespace for NullBodyStream
* Fix include path
* Remove noexcept specification from Azure::DateTime::clock::now()
* Undo unnecessary change (my local clang-format is broken)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* January release protocol layer (#4102)
* stg85/86 protocol layer
* datalake append/flush with lease (#4110)
* unit_test_for_file_invalid_xml (#4113)
* remove version id inTaggedBlobItem and add unit test for cold tier (#4121)
* fix conversation
* ClientCertificateCredential: Add AuthorityHost override and Azure Stack support
* Use RAII types for handles
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Use nlohmann::json to parse Identity token
* Update sdk/identity/azure-identity/src/token_credential_impl.cpp
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Line coverage / Strict ISO 8601 datetime parse test
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Workaround for the MSVC 19.34 bug
* Use _MSC_VER instead of _VSC_FULL_VER (at least 19.34.31931 and .31933 are affected)
* Remove newline
* Use same code for all compiler versions
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Correct invalid UTF-8 in comment in
/storage/files/shares/share_options.hpp
* Correct invalid UTF-8 in comment in line 291
Correct invalid UTF-8 in comment in line 291 share_options.hpp
* Disable warning C6387 coming from wil in win_http_transport
* Disable warning C6387 coming from wil in win_http_transport header
* Clang format fix for header file
* Clang format fix for source file
* Added ability to switch to OpenSSL 1.1.1n
* Fixed OpenSSL compilation challenges - the CRL stuff works now
* Added instructions on using OpenSSL 1.1.1 to README
* Added vcpkg args to handle openssl variants
* Removed version override for opentelemetry
* Disable deprecation warnings for open telemety tests to guard against future deprecations
* Added explanation for 4996 error; removed InMemoryExporter from documentation
* Checkpoint adding manual telemetry exporter
* Switch from using OpenTelemetry's InMemoryExporter (which is an internal-to-opentelemetry test hook) to our own SpanExporter
* removed unused variables because gcc doesn't like them
* Fixed doxygen comments
* Removed a bunch of unnecessary headers
* Update sdk/core/azure-core-tracing-opentelemetry/test/ut/test_exporter.hpp
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* first take
* grrrrr
* qwqwq
* ewqw
* eewew
* put back
* pipeline
* Set read-only VCPKG_BINARY_SOURCES_SECRET
* Pass InstallLanguageSteps through the perf template
* blop pipeline
* path
* ';l'l;
* add support for sync param
* --sync flag support
* typo
* sync
* sync to y
* for PR
* clang
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
* Removed version override for opentelemetry
* Disable deprecation warnings for open telemety tests to guard against future deprecations
* Added explanation for 4996 error; removed InMemoryExporter from documentation
* core tests
* clang
* vcpkg test
* dswsw
* first take on the vcpkg
* vcpkg
* get vcpkg version
* fix cmake
* separators
* vcpkg
* vcpkg
* test1
* disable verify agent od
* put back verify
* put back yml
* Increment package version after release of azure-security-keyvault-keys
* Increment package version after release of azure-security-keyvault-certificates
* Increment package version after release of azure-security-keyvault-secrets
* Increment package version after release of azure-storage-blobs
* Increment package version after release of azure-storage-files-datalake
* Increment package version after release of azure-storage-files-shares
* Pulled WebSocket fixes into main except for WebSockets functionality
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: George Arama <50641385+gearama@users.noreply.github.com>
Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Increment package version after release of azure-storage-common
* Increment package version after release of azure-storage-blobs
* Increment package version after release of azure-storage-files-shares
When signals are delievered to the process, calls here to poll may be
interrupted and return with a spurious failure. The call instead should be
restarted.
* Increment package version after release of azure-security-keyvault-keys
* Increment package version after release of azure-security-keyvault-secrets
* Increment package version after release of azure-security-keyvault-certificates
* mem leak fix
* PR comments fix
* PR comments
* seems to work?
* clang
* curl again
* add first stress test
* also update gitignore
* missing line
* only linux
* clang typo format
* typo 2
* PR comments
* cspell
* remove terminator
* Update Certificates service version to 7.3 (#3538)
* one commit to rule them all
* update to 7.3 version and comment
* support 7.2
* Update service version for keyvault Keys to 7.3 (#3539)
* one commit to rule them all
* updated to version 7.3 and updated tests and recordings.
* 7.2
* Update service version for keyvault Secrets to 7.3 (#3540)
* one commit to rule them all
* Updated service version to 7.3
* support v7.2
* typo
* Update deps to latest version of core and identity (#3541)
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* bump keys version to 7.3
* Revert "bump keys version to 7.3"
This reverts commit e348e966de56f28996b4cb32104088b4414559ed.
* update the versions for the core and identity deps for the keyvault APIs. needed for some api implementations.
* removed identity dep
* put back ident
* remove ident from folder
* 1.4.0
* update vcpkg commit
* put back ident
* remove again
* update vcpkg commit
* PR comment
* vcpkg commit min for azure core 1.5
* increase timeout
* Key vault work - RNG and rotation policy (#3560)
* one commit to rule them all
* work in progress
* tests for serialize deserialize
* typos
* to lower
* enable test
* guard live
* typos, types, and many more
* maybe now ? please ...
* PR comments
* rotate API (#3602)
* Release key prep (#3597)
* step1
* part2
* code maybe
* working to create exportable with release policy
* still not working
* cleanup
* revert attestation change, fix crypto tests
* fix ut
* format and pedantic chars
* PR
* some UTs
* oops
* what can i do
* PR comments
* Release key API (#3622)
* step1
* part2
* code maybe
* working to create exportable with release policy
* still not working
* Release Key Works now
* format
* qfe
* clean build issues
* build fixes
* PR comments
* cspell
* rework the test to use the source keys instead of jwk. needed to be restored for live tests
* update location
* FIX hsm test (#3630)
* tests pass
* oops
* update hsm path
* clang
* update test resources
* try try again
* try again
* update variable in azure core
* template worx
* clang
* try pipeline1
* see now
* try try again
* darn json
* oh boy
* oh boy
* rwerwerw
* jioijhjui
* maybe now ?
* maybe now ?
* increase timeout and fix ps script
* keyvault permissions
* rebalance regions
* ssssss
* [p]ppi
* try this
* fsdfsdfsd
* maybe now
* test again
* maybe
* maybe
* maybe 2
* try again
* ssssss
* uyufyut
* maybe now ?
* try again
* t/f/1/0
* cleanup
* maybe now
* edeployment output
* oook
* let's see the envs
* fix 2 tests
* another one
* try try again
* oops
* powershell error
* ps again
* i hate this so much right now
* try try again
* try again
* dsaas
* rewrwr
* erwrw
* windows?
* libcurl ?
* ???
* retry
* retyr message , api version
* again
* ok maybe
* dssds
* final updates
* missing line
* Update docs (#3678)
* begining
* update readmes
* Update sdk/keyvault/azure-security-keyvault-certificates/CHANGELOG.md
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/keyvault/azure-security-keyvault-keys/CHANGELOG.md
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/keyvault/azure-security-keyvault-keys/README.md
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Update sdk/keyvault/azure-security-keyvault-secrets/CHANGELOG.md
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* Merge from main (#3760)
* one commit to rule them all
* Sync eng/common directory with azure-sdk-tools for PR 3000 (#3485)
* Sort by client, mgmt, track2, track1
* sort by the type
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* fix the sorting
* Define the order of new and type
* address comments
* fix typo
* Address your comments
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update Generate-DocIndex.ps1
* Update Generate-DocIndex.ps1
* Update eng/common/docgeneration/Generate-DocIndex.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: sima-zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Support BaseName overrides in CI mode for New-TestResources.ps1 (#3559)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Do not pass Generated to -BaseName (#3562)
Co-authored-by: Heath Stewart <heaths@microsoft.com>
* Sort by service name first (#3570)
Co-authored-by: sima-zhu <sizhu@microsoft.com>
* Initialize the suppression file. (#3569)
* Sync eng/common directory with azure-sdk-tools for PR 3169 (#3572)
* Use the batch version of ValidateDocsMsPackagesFn
* Use proper pipelining for GetPackageInfoJson function
Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
* [Tech Docs] Libcurl transport adapter (#3484)
* libcurl transport adapter
* updates
* Update LibcurlTransportAdapter.md
* Update LibcurlTransportAdapter.md
* Update doc/LibcurlTransportAdapter.md
Co-authored-by: Jeffrey Richter <jeffrichter@live.com>
Co-authored-by: Jeffrey Richter <jeffrichter@live.com>
* Skip azcopy download if it already exists (#3576)
Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
* Pin openssl to 1.1.1n (#3575)
* Pin openssl to 1.1.1n
* Updated vcpkg commit to one containing OpenSSL 1.1.1n
* Fixed version number in vcpkg.json
* Fix typo (#3583)
* update curl transport options to support ignore proxy from system (#3564)
* update curl transport options to support ignore proxy from system
* update changelog
* bug fix for cl
* update log level from Retry policy (#3586)
* update log level
* Update sdk/core/azure-core/CHANGELOG.md
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Add batch protocol layer (#3580)
* Add batch protocol layer
* some small fixes on Storage cmakefiles (#3588)
* Migrate to matrix generator (#3553)
* Represent existing matrix in json
* Use new matrix
* Move to stage
* Cloud configuration
* MaxParallel
* DependsOn
* Quote CtestRegex
* Use template for cmake generate tests
* Template name mappings
* Formatting, parameters
* Remove duplicate bypass-local-dns.yml
* Enable Location override
* Add Location
* Add spelling words
* Use Ubuntu 20 where the name specifies Ubuntu 20
* Apply suggestions from code review
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
* PR feedback
* fix storage sample
* Matrix documentation
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Victor Vazquez <vhvb1989@gmail.com>
* Sync eng/common directory with azure-sdk-tools for PR 3212 (#3587)
* bump consumed version of test proxy. update scripting to target the fully cross-platform image tag name.
* update target version of the test-proxy to one that enforces http/1.1
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
* Sync eng/common directory with azure-sdk-tools for PR 3238 (#3590)
* pin proxy version to one that properly sets listenoptions
* update targeted test-proxy docker repo. "testproxy" -> "test-proxy"
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
* Sync eng/common directory with azure-sdk-tools for PR 3221 (#3591)
* Make docs.ms link relative link
* Update Update-DocsMsMetadata.ps1
* Update eng/common/scripts/Update-DocsMsMetadata.ps1
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: sima-zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
* Remove the daily branch before date (#3593)
Co-authored-by: sima-zhu <sizhu@microsoft.com>
* Add ClientCertificateCredential (#3578)
* Add ClientCertificateCredential
* Update unit test
* cspell
* Update Readme
* Cosmetic fixes
* Changelog to mention env cred update
* Fix warning
* cspell
* Tell CI to install openssl
* openssl for all Windows
* update dependency manifest
* Re-phrase changelog
* Clang warnings
* Clang warning
* Clang warning - 2
* Ubuntu18 warning
* Update sdk/identity/azure-identity/CHANGELOG.md
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
* PR feedback
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
* Sync eng/common directory with azure-sdk-tools for PR 3250 (#3595)
* Change the direction of the commit date
* Log on right place
* remove auth
* fix typo
* Add auth token back
* add delete back
* Update eng/common/scripts/Delete-RemoteBranches.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update Delete-RemoteBranches.ps1
* Update Delete-RemoteBranches.ps1
* Update Delete-RemoteBranches.ps1
* Update Delete-RemoteBranches.ps1
* Update Delete-RemoteBranches.ps1
Co-authored-by: sima-zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Create a session handle once in the transport ctor and reuse it for all requests rather than creating a new one each time. (#3585)
* Reuse the same session handle for all requests rather than creating a new one each time.
* Move the session handle creation to the transport adapter ctor.
* Update changelog entry.
* Address PR feedback.
* Change CreateSessionHandle to return a local session handle
* Fix-up the changelog entry link for the curtransportoption bug fix (#3598)
* Remove extra period at ends of exception messages in winhttp transport (#3601)
* fix cmake in storage (#3604)
* Reword the curl proxy fix changelog entry. (#3606)
* Add Emma Zhu as code owner (#3605)
* Short circuit out of msdocs publish if no package locations are specified (#3607)
Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
* sdk/core: Reimplement Md5OpenSSL using EVP API (#3609)
The MD5_Init/Update/Final functions are deprecated in OpenSSL 3.0 and result in
a compile-time warning. Due to the default usage of -Werror during compilation,
these warnings are treated as errors and prevent the SDK from being built on
Ubuntu 22.04, which ships with OpenSSL by default. The deprecated APIs should
be replaced by the EVP APIs, which are already in use for the SHA family of
functions, and supported on all versions of OpenSSL.
* API Review Feedback for Attestation SDK (#3543)
* API Review Feedback for Attestation SDK
* Updated changelog to reflect API Review updates
* Remove version pin for OpenSSL (#3610)
* Remove version pin for OpenSSL
* Gratuitous change to trigger CI pipelines
* Update the version tool to the latest (#3616)
Co-authored-by: sima-zhu <sizhu@microsoft.com>
* Get rid of warnings in nullable.hpp (#3617)
* cl (#3613)
* Update pipeline-generator version (#3623)
Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
* Prepare Attestation SDK for May Release. (#3625)
* Prepare attestation for May release
* Removed some noise from changelog
* Increment package version after release of azure-core (#3624)
* Update CODEOWNERS (#3628)
* Fix identity samples running in CI (#3632)
* azure identity may 2022 release (#3615)
* Increment package version after release of azure-identity (#3637)
* Removed uwp-x86 from platform matrix. (#3629)
* Increment package version after release of azure-security-attestation (#3636)
* Update readme for -pre and -post TestResource scripts (#3645)
Co-authored-by: Christopher Scott <chriss@microsoft.com>
* Fixed a bug where text of XML element cannot be empty. (#3643)
* String parsing improvements to service directory resource names (#3644)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Adding Acknowledgments (#3611)
* cl
* Update sdk/core/azure-core/CHANGELOG.md
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* cspell
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
* Add skip variable for remove test resources to support debugging (#3648)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Storage Blob Stg78 Features (#3650)
* Clean up target_include_directories() (#3641)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Update all-inclusive headers, and CMakeFiles for including all headers (#3640)
* Remove (#3657)
oexcept specifier from Context::IsCancelled()
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Add Language product slug (#3665)
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
* Sync eng/common directory with azure-sdk-tools for PR 3342 (#3664)
* Delete PR and branch which central PR is closed
* more logging changes
* resume the delete operations.
* Change the pr link directly
* fix the regex
* Refactor on regex name
* change the function to inline logic
* change typo
* delete on branch
* make changes on comments
* add commnets
* Update eng/common/scripts/Delete-RemoteBranches.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/scripts/Delete-RemoteBranches.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/scripts/Delete-RemoteBranches.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Update eng/common/scripts/Delete-RemoteBranches.ps1
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: sima-zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
* Split out attestation client factory into separate class (#3654)
* Split out attestation client factory into separate class
* Updated readme; clang-format
* Final set of API review changes
* Replaced () constructors with {} constructors
* Initial implementation of OpenTelemetry APIs. (#3561)
* Start of tracing prototype
* Created initial implementation of azure-core-opentelemetry package
* New version of enabling MSVCRT Lib for static configs
* Attempt to add OpenTelemetry tests to build
* Take a dependency on OpenTelemetry version 1.3
* Added service API level tracing support
* API Review feedback
* storage unittest fix and improvement (#3667)
* main merge
* error
* Sync eng/common directory with azure-sdk-tools for PR 3362 (#3676)
* spell-check skippable by commit
* suceededOrFailed -> succeededOrFailed
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
* Sync eng/common directory with azure-sdk-tools for PR 3378 (#3679)
* Create json package property parent directory
* Fix the issue in script
Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
* Vcpkg sample (#3670)
* one commit to rule them all
* main merge
* error
* all smoke
* typo
* 120 minutes
* timeout param missing on job
* actual url
* Update samples/integration/vcpkg-all-smoke/src/main.cpp
Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
* actual creds
Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
* main merge
* error
* Complete the initial implementation of OpenTelemetry (#3677)
* Added telemetry support for HTTP pipeline elements
* Finish OpenTelemetry implementation
* clang-format and added doxygen comments
* Creadscan skips (#3671)
* one commit to rule them all
* main merge
* error
* add recordings for cred scan skipping
* certificates added
* remove dupe
* cspell
* Moved attestation factory back to static method on attestation class … (#3682)
* Moved attestation factory back to static method on attestation class and return a concrete type not a pointer
* Fixed factory in readme file
* main merge
* error
* main merge
* error
* iyuuyyu
* revert space
* OpenTelemetry API Review Feedback (#3687)
* OpenTelemetry API Review Feedback
* vcpkg version
* typos
* Attestation 1.0.0 GA Release (#3693)
* Prepare attestation for release
* removed references to RetrieveResponseValidationCollateral from docs
* Added C++ SDK team as owners of attestation SDK
* Added Ahmad from attestation team to attestation owners
* Removed dead API; switched attestation back to beta-3
* Disable detached head warnings on sparse checkout to commit (#3680)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Remove samples with docker.io (#3621)
* remove samples using docker.io
* removing docker files
* remove project
* Fix issue where matrix replace was not using imported display names (#3694)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* Additional OpenTelemetry Feedback... (#3691)
* OpenTelemetry API Review Feedback
* Returns std::unique_ptr<DiagnosticTracingFactory instead of raw pointer
* Late breaking pull request feedback
* Renamed clientContext parameter to CreateSpan
* Renamed ContextAndSpanFactory to TracingContextFactory and CreateSpan to CreateTracingContext.
* Added ability to create instance with pointer (#3698)
* Added ability to create instance with pointer
* Pull request feedback
* Core 1.7.0-beta.1 Release (#3684)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Increment package version after release of azure-core (#3699)
* Format vcpkg.json (#3701)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Update README to list all the vcpkgs (#3704)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Removed version>= fields for openssl in vcpkg.json files (#3705)
* Tab vcpkg publishing condition in to apply to the task (#3709)
* Storage June Release (#3686)
* Override live test location default to westus (#3696)
* Changelog updates for secrets and certificates (#3714)
* Changelog updates for secrets and certificates
* Update package versions
* Removed empty sections in changelog (#3718)
* Identity 1.3.0 Release (#3685)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* OpenTelemetry vcpkg fixes (#3716)
* OpenTelemetry vcpkg fixes
* Update ci.yml
* Drop version >= from project-level vcpkg
* find_package only supports numeric versions
* include(AzureBuildTargetForCI)
* Do not build as Windows/UWP DLL
* Docs and package dependencies
* Update condition
* Move condition down
* Move more under condition
* Rephrase condition
* Try hack for CI that won't affect vcpkg
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Increment package version after release of azure-identity (#3721)
* Increment version for storage releases (#3713)
* Increment package version after release of azure-storage-common
* Increment package version after release of azure-storage-blobs
* [EngSys] Get Vcpkg automatically (#3614)
* get vcpkg automatically
* Updated changelog (#3726)
* Increment package version after release of azure-core-tracing-opentelemetry (#3727)
* Increment package version after release of azure-security-attestation (#3717)
* Increment package version after release of azure-security-attestation (#3720)
* Enable Distributed Tracing for Attestation SDK client. (#3706)
* Implement tracing for Attestation and Template services
* Pipeline no longer requires service name if opting into distributed tracing; enable tracing in attestation service
* Generate user-agent header from request activity policy
* Added test to catch the redacted header regression
* Updated documentation to reflect API surface changes
* Make sample service an object library (#3728)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Include pi-version to default list of unredacted query params for logging (#3730)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Sync eng/common directory with azure-sdk-tools for PR 3433 (#3731)
* add condition
* divide line
Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
* Sync eng/common directory with azure-sdk-tools for PR 3267 (#3655)
* Use seperate scripts
* address comments.
* do compare and update
* save on the service level readme
* have the helper for reuse function
* remove mgmt table
* changes
* fix
* no return on error
* return if no contents
* Address comments
* change the table
* address wes comments.
* address wes comments.
* address more comments.
Co-authored-by: sima-zhu <sizhu@microsoft.com>
* Sync eng/common directory with azure-sdk-tools for PR 3386 (#3733)
* Update the order of remarks and examples to align with docs.ms
* change all occurance
* Update class.tmpl.partial
Co-authored-by: sizhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
* ensure conditions all work properly in the case of a previous error (#3732)
Co-authored-by: Scott Beddall <scbedd@microsoft.com>
* InputSanitizer: rename to HttpSanitizer, remove static member (#3736)
* InputSanitizer => HttpSanitizer, remove static
* Update cpp
* Clang format
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Increment version for keyvault releases (#3719)
* Increment package version after release of azure-security-keyvault-certificates
* Increment package version after release of azure-security-keyvault-secrets
* Update DistributedTracing.md (#3715)
Fix typo
* ApiView command line generation script (#3711)
* ApiView command line generation script
* Strongly typed parameters
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
* Add missing license header to http_sanitizer source file (#3739)
* Add ResourceType parameter - Selects live test or perf test resources (#3740)
Co-authored-by: Mike Harder <mharder@microsoft.com>
* Update identity codeowners (#3744)
* ManagedIdentityCredential: Add support for AppServiceV2019 (#3734)
* ManagedIdentityCredential: Add support for AppServiceV2019
* Attempt to create 2019 before 2017
* Changelog update
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* sasa
* format file
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: sima-zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Heath Stewart <heaths@microsoft.com>
Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
Co-authored-by: Jeffrey Richter <jeffrichter@live.com>
Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: JinmingHu <jinmhu@microsoft.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Victor Vazquez <vhvb1989@gmail.com>
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>
Co-authored-by: Jeremi Piotrowski <jeremi.piotrowski@gmail.com>
Co-authored-by: Christopher Scott <chriss@microsoft.com>
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
Co-authored-by: Scott Beddall <scbedd@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
* Per request (#3770)
* Per request
* const
* Jeff feedback , clang, and test
* Updates from API review part 2 (#3775)
* Per request
* const
* Jeff feedback , clang, and test
* API review feedback updates, missed client to update , and some comments that somehow got reverted from the branch
* missed comment
* trigger
* some samll updates
* PR comments
* Fixed punctuation.
* one last round
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: sima-zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Heath Stewart <heaths@microsoft.com>
Co-authored-by: Patrick Hallisey <pahallis@microsoft.com>
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
Co-authored-by: Jeffrey Richter <jeffrichter@live.com>
Co-authored-by: Larry Osterman <LarryOsterman@users.noreply.github.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: JinmingHu <jinmhu@microsoft.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Victor Vazquez <vhvb1989@gmail.com>
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>
Co-authored-by: Jeremi Piotrowski <jeremi.piotrowski@gmail.com>
Co-authored-by: Christopher Scott <chriss@microsoft.com>
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
Co-authored-by: Mariana Rios Flores <mariari@microsoft.com>
Co-authored-by: Scott Beddall <scbedd@microsoft.com>
Co-authored-by: Mike Harder <mharder@microsoft.com>
Jeff has pointed out that the current practice in the SDK of having a ServiceVersion which contains the current API versions of the service (for instance:
```c++
class ServiceVersion final {
public:
explicit ServiceVersion(std::string version) : m_version(std::move(version)) {}
AZ_STORAGE_QUEUES_DLLEXPORT const static ServiceVersion V2018_03_28;
AZ_STORAGE_QUEUES_DLLEXPORT const static ServiceVersion V2020_10_01;
};
)
```
Has a problem because the `ServiceVersion` construct has an implication that each of the `ServiceVersion` values listed is fully supported by the SDK.
The reality is that the SDK client team only tests the most recent API version listed in the SDK (the value which is the default version listed in the `ServiceClient` constructor).
How do we resolve this issue?
There are a few possible solutions that we’ve explored:
1) Test all the API versions listed in the `ServiceVersion` enumeration.
2) Remove the unsupported values from the `ServiceVersion` enumeration.
3) Remove the `ServiceVersion` enumeration
4) Remove the ability to set the API version at all.
Each of these solutions has some fairly significant drawbacks.
1) Test all the API versions listed.
The core problem with this is that the SDK team is small and adding tests to support every possible API version is going to be prohibitively expensive.
2) Remove the unsupported values from the `ServiceVersion` enumeration.
This is a breaking change and it means that moving to a new API version requires a breaking change to the SDK, even if the changes between API versions is strictly additive.
3) Remove the ServiceVersion enumeration.
This is also a breaking change for shipping SDKs (specifically KeyVault and Storage Queues). However, it is a one-time breaking change and we don’t have evidence of customers actually using the feature.
4) Remove the ability to set the API version at all.
Having *some* mechanism to set the API version is an important “escape hatch” which will allow customers to specify a specific API version even if that API version is not fully supported.
After discussing this a LOT, [@Ahson Khan](mailto:ahkha@microsoft.com), [@Rick Winter](mailto:Rick.Winter@microsoft.com), [@Jeffrey Richter](mailto:jeffreyr@microsoft.com), [@George Arama](mailto:George.Arama@microsoft.com), and [@Larry Osterman](mailto:Larry.Osterman@microsoft.com) came to the conclusion that we should probably take option #3, but leave the ClientOptions.Version value as a std::string.
* Removed internal references from public headers
* Updated changelog files
* Updated DistributedTracing.md to reflect Factory construction of Azure::Core::Tracing::OpenTelemetry::OpenTelemetryProvider type
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* one commit to rule them all
* main merge
* error
* main merge
* error
* main merge
* error
* main merge
* error
* example of perf test
* remove file
* create certs and keys in post setup, use to run the test
* PR comments
* ManagedIdentityCredential: Add support for AppServiceV2019
* Attempt to create 2019 before 2017
* Changelog update
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* Increment package version after release of azure-security-keyvault-certificates
* Increment package version after release of azure-security-keyvault-secrets
* Implement tracing for Attestation and Template services
* Pipeline no longer requires service name if opting into distributed tracing; enable tracing in attestation service
* Generate user-agent header from request activity policy
* Added test to catch the redacted header regression
* Updated documentation to reflect API surface changes
* OpenTelemetry vcpkg fixes
* Update ci.yml
* Drop version >= from project-level vcpkg
* find_package only supports numeric versions
* include(AzureBuildTargetForCI)
* Do not build as Windows/UWP DLL
* Docs and package dependencies
* Update condition
* Move condition down
* Move more under condition
* Rephrase condition
* Try hack for CI that won't affect vcpkg
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
* OpenTelemetry API Review Feedback
* Returns std::unique_ptr<DiagnosticTracingFactory instead of raw pointer
* Late breaking pull request feedback
* Renamed clientContext parameter to CreateSpan
* Renamed ContextAndSpanFactory to TracingContextFactory and CreateSpan to CreateTracingContext.
* Prepare attestation for release
* removed references to RetrieveResponseValidationCollateral from docs
* Added C++ SDK team as owners of attestation SDK
* Added Ahmad from attestation team to attestation owners
* Removed dead API; switched attestation back to beta-3
* Start of tracing prototype
* Created initial implementation of azure-core-opentelemetry package
* New version of enabling MSVCRT Lib for static configs
* Attempt to add OpenTelemetry tests to build
* Take a dependency on OpenTelemetry version 1.3
* Added service API level tracing support
* API Review feedback
* Split out attestation client factory into separate class
* Updated readme; clang-format
* Final set of API review changes
* Replaced () constructors with {} constructors
The MD5_Init/Update/Final functions are deprecated in OpenSSL 3.0 and result in
a compile-time warning. Due to the default usage of -Werror during compilation,
these warnings are treated as errors and prevent the SDK from being built on
Ubuntu 22.04, which ships with OpenSSL by default. The deprecated APIs should
be replaced by the EVP APIs, which are already in use for the SHA family of
functions, and supported on all versions of OpenSSL.
* Reuse the same session handle for all requests rather than creating a new one each time.
* Move the session handle creation to the transport adapter ctor.
* Update changelog entry.
* Address PR feedback.
* Change CreateSessionHandle to return a local session handle
* Increment package version after release of azure-storage-common
* Increment package version after release of azure-storage-blobs
* Increment package version after release of azure-storage-queues
* Script that automates updating vcpkg betas
* Wire up to pipeline
* Spelling, commentary
* Clone into repo name
* Remove-Item requires the path to exist, even if -Force is specified
* Bootstrap vcpkg
* Arguments to Test-ShouldReleaseToVcpkg.ps1
* More commit
* Escape quotes
* Quote git commit
* Set strict mode
* Use tags
* Actually tag
* Run git commands
* Invoke-Expression
* Onboard releasing package to vcpkg before attempting to isntall from overaly
* temporarily disable matrix generation (30s tasks sometimes runs for 20+ minutes)
* Test-ShouldReleaseToVcpkg.ps1
* Test-Path
* Test vcpkg build, also ensure we push
* Just the tags... low probability of success given that '--' if frequently treated as a separator
* Add ability to skip link verification for tighter inner loop
* Push tag separately
* Unnecessary condition and conjunction
* Base repo owner: Azure
* Specify remote name
* Tighten inner loop
* git remote -v
* workingDirectory
* Go back to two tags and a regular push
* Saving some progress
* Use original push method
* BaseRepoOwner
* Cleanup, put changes in the default branch (vcpkg does not look at refs outside of the default branch)
* Use default branch