github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Removed 'using namespace' directive from public header (#4514)

Browse Source 
* Removed 'using namespace' directive from public header

* Shortened namespace names (Thanks Antkmsft)

* Update sdk/keyvault/azure-security-keyvault-administration/inc/azure/keyvault/administration/settings_client.hpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

---------

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
This commit is contained in:
Larry Osterman 2023-04-04 11:31:37 -07:00 committed by GitHub
parent fd687c32fa
commit 3cb4993423
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sdk/keyvault/azure-security-keyvault-administration/inc/azure/keyvault/administration/settings_client.hpp
View File

@ -17,8 +17,6 @@
#include <memory>
#include <string>
using namespace Azure::Security::KeyVault::Administration::Models;
namespace Azure { namespace Security { namespace KeyVault { namespace Administration {
/**
* @brief Settings Client class.
@ -67,7 +65,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Administra
*
* @returns Response containing the new updated setting.
*/
Azure::Response<Setting> UpdateSetting(
Azure::Response<Models::Setting> UpdateSetting(
std::string const& name,
std::string const& value,
const Azure::Core::Context& context = Azure::Core::Context{}) const;
@ -80,7 +78,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Administra
*
* @returns response containing the setting.
*/
Azure::Response<Setting> GetSetting(
Azure::Response<Models::Setting> GetSetting(
std::string const& name,
const Azure::Core::Context& context = Azure::Core::Context{}) const;
@ -91,11 +89,11 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Administra
*
* @returns Response containing a list of settings.
*/
Azure::Response<SettingsListResult> GetSettings(
Azure::Response<Models::SettingsListResult> GetSettings(
const Azure::Core::Context& context = Azure::Core::Context{}) const;
private:
Setting ParseSetting(std::vector<uint8_t> const& responseBody) const;
Models::Setting ParseSetting(std::vector<uint8_t> const& responseBody) const;
std::unique_ptr<Azure::Core::Http::RawResponse> SendRequest(
Azure::Core::Http::Request& request,

1
sdk/keyvault/azure-security-keyvault-administration/src/settings_client.cpp
View File

@ -19,6 +19,7 @@ using namespace Azure::Core::Http::Policies;
using namespace Azure::Core::Http::Policies::_internal;
using namespace Azure::Core::Json::_internal;
using namespace Azure::Security::KeyVault::Administration;
using namespace Azure::Security::KeyVault::Administration::Models;
using namespace Azure::Security::KeyVault::Administration::_detail;
std::unique_ptr<Azure::Core::Http::RawResponse> SettingsClient::SendRequest(