github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

blob test cases improvements (#4806)

Browse Source 
* move not-working test assertion to a separate case

* enable AppendBlobClientTest.HighThroughputAppendBlob_LIVEONLY_

* remove incorrect comment
This commit is contained in:
JinmingHu 2023-07-24 11:20:37 +08:00 committed by GitHub
parent 0a175f2c83
commit 9293a6da77
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 28 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
sdk/storage/azure-storage-blobs/test/ut/append_blob_client_test.cpp
View File

@ -327,18 +327,36 @@ namespace Azure { namespace Storage { namespace Test {
options2.TransactionalContentHash.Value().Value = contentMd5;
EXPECT_NO_THROW(
appendBlobClient2.AppendBlockFromUri(appendBlobClient.GetUrl() + GetSas(), options2));
options2.TransactionalContentHash.Value().Algorithm = HashAlgorithm::Crc64;
options2.TransactionalContentHash.Value().Value
= Azure::Core::Convert::Base64Decode(DummyCrc64);
// EXPECT_THROW(
// appendBlobClient2.AppendBlockFromUri(appendBlobClient.GetUrl() + GetSas(), options2),
// StorageException);
options2.TransactionalContentHash.Value().Value = contentCrc64;
EXPECT_NO_THROW(
appendBlobClient2.AppendBlockFromUri(appendBlobClient.GetUrl() + GetSas(), options2));
}
TEST_F(AppendBlobClientTest, DISABLED_LIVEONLY_HighThroughputAppendBlob)
TEST_F(AppendBlobClientTest, DISABLED_AppendBlockFromUriCrc64AccessCondition)
{
auto appendBlobClient = GetAppendBlobClientForTest(RandomString());
const std::vector<uint8_t> blobContent = RandomBuffer(10);
const std::vector<uint8_t> contentCrc64
= Azure::Storage::Crc64Hash().Final(blobContent.data(), blobContent.size());
appendBlobClient.Create();
auto contentStream = Azure::Core::IO::MemoryBodyStream(blobContent.data(), blobContent.size());
appendBlobClient.AppendBlock(contentStream);
auto appendBlobClient2 = GetAppendBlobClientForTest(RandomString());
appendBlobClient2.Create();
Blobs::AppendBlockFromUriOptions options;
options.TransactionalContentHash = ContentHash();
options.TransactionalContentHash.Value().Algorithm = HashAlgorithm::Crc64;
options.TransactionalContentHash.Value().Value = Azure::Core::Convert::Base64Decode(DummyCrc64);
EXPECT_THROW(
appendBlobClient2.AppendBlockFromUri(appendBlobClient.GetUrl() + GetSas(), options),
StorageException);
options.TransactionalContentHash.Value().Value = contentCrc64;
EXPECT_NO_THROW(
appendBlobClient2.AppendBlockFromUri(appendBlobClient.GetUrl() + GetSas(), options));
}
TEST_F(AppendBlobClientTest, HighThroughputAppendBlob_LIVEONLY_)
{
auto appendBlobClient = m_blobContainerClient->GetAppendBlobClient(RandomString());
appendBlobClient.Create();

2
sdk/storage/azure-storage-blobs/test/ut/blob_container_client_test.cpp
View File

@ -402,8 +402,6 @@ namespace Azure { namespace Storage { namespace Test {
EXPECT_TRUE(foundMetadata);
}
// Test uses StartsOn and ExpiresOn values based on time now() + minutes
// Hence, the test can't be recorded and need to run on live mode always.
TEST_F(BlobContainerClientTest, AccessControlList)
{
auto containerClient = *m_blobContainerClient;