github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Disable libcurl globalCleanUp test until it has been investigated (#4797)

Browse Source 
* Disable libcurl globalCleanUp test until it has been investigated

* Update curl_connection_pool_private.hpp friend class name for the disabled test

* Update curl_session_private.hpp friend class name for the disabled test
This commit is contained in:
Ahson Khan 2023-07-17 16:04:11 -07:00 committed by GitHub
parent d1544744bf
commit c85e9bd11f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sdk/core/azure-core/src/http/curl/curl_connection_pool_private.hpp
View File

@ -29,7 +29,7 @@ namespace Azure { namespace Core { namespace Test {
class CurlConnectionPool_connectionPoolTest_Test;
class CurlConnectionPool_uniquePort_Test;
class CurlConnectionPool_connectionClose_Test;
class SdkWithLibcurl_globalCleanUp_Test;
class SdkWithLibcurl_DISABLED_globalCleanUp_Test;
}}} // namespace Azure::Core::Test
#endif
@ -48,7 +48,7 @@ namespace Azure { namespace Core { namespace Http { namespace _detail {
friend class Azure::Core::Test::CurlConnectionPool_connectionPoolTest_Test;
friend class Azure::Core::Test::CurlConnectionPool_uniquePort_Test;
friend class Azure::Core::Test::CurlConnectionPool_connectionClose_Test;
friend class Azure::Core::Test::SdkWithLibcurl_globalCleanUp_Test;
friend class Azure::Core::Test::SdkWithLibcurl_DISABLED_globalCleanUp_Test;
#endif
public:

4
sdk/core/azure-core/src/http/curl/curl_session_private.hpp
View File

@ -22,7 +22,7 @@
// Define the class name that reads from ConnectionPool private members
namespace Azure { namespace Core { namespace Test {
class CurlConnectionPool_connectionPoolTest_Test;
class SdkWithLibcurl_globalCleanUp_Test;
class SdkWithLibcurl_DISABLED_globalCleanUp_Test;
}}} // namespace Azure::Core::Test
#endif
@ -43,7 +43,7 @@ namespace Azure { namespace Core { namespace Http {
#ifdef TESTING_BUILD
// Give access to private to this tests class
friend class Azure::Core::Test::CurlConnectionPool_connectionPoolTest_Test;
friend class Azure::Core::Test::SdkWithLibcurl_globalCleanUp_Test;
friend class Azure::Core::Test::SdkWithLibcurl_DISABLED_globalCleanUp_Test;
#endif
private:
/**

3
sdk/core/azure-core/test/ut/azure_libcurl_core_main_test.cpp
View File

@ -31,7 +31,8 @@
#include <gtest/gtest.h>
namespace Azure { namespace Core { namespace Test {
TEST(SdkWithLibcurl, globalCleanUp)
// This test fails intermittently: https://github.com/Azure/azure-sdk-for-cpp/issues/4332
TEST(SdkWithLibcurl, DISABLED_globalCleanUp)
{
Azure::Core::Http::Request req(
Azure::Core::Http::HttpMethod::Get, Azure::Core::Url("https://httpbin.org/get"));