github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Enable phasing out a breaking change in Core in a step-by-step manner (#4749)

Browse Source 
* Enable phasing out a breaking change in Code in a step-by-step manner

* Update messages

* Fully qualify namespace in Changelog

---------

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
This commit is contained in:
Anton Kolesnyk 2023-07-05 15:39:57 -07:00 committed by GitHub
parent 68be8b4568
commit 8c748719d4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sdk/core/azure-core/CHANGELOG.md
View File

@ -6,11 +6,13 @@
### Breaking Changes
- [[#4662]](https://github.com/Azure/azure-sdk-for-cpp/issues/4662) `Azure::Core::Operation<T>::GetRawResponseInternal()` is now deprecated and no longer requires an overload.
### Bugs Fixed
### Other Changes
Empty diagnostic messages will no longer be generated.
- Empty diagnostic messages will no longer be generated.
## 1.10.0 (2023-06-01)

6
sdk/core/azure-core/inc/azure/core/operation.hpp
View File

@ -31,6 +31,12 @@ namespace Azure { namespace Core {
virtual Response<T> PollUntilDoneInternal(std::chrono::milliseconds period, Context& context)
= 0;
[[deprecated("Do not override and do not use.")]] virtual Azure::Core::Http::RawResponse const&
GetRawResponseInternal() const
{
return *m_rawResponse;
}
protected:
/** @brief the underlying raw response for this operation. */
std::unique_ptr<Azure::Core::Http::RawResponse> m_rawResponse = nullptr;