From 8c748719d483feba8b21039e88de27afa819fd2a Mon Sep 17 00:00:00 2001 From: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com> Date: Wed, 5 Jul 2023 15:39:57 -0700 Subject: [PATCH] Enable phasing out a breaking change in Core in a step-by-step manner (#4749) * Enable phasing out a breaking change in Code in a step-by-step manner * Update messages * Fully qualify namespace in Changelog --------- Co-authored-by: Anton Kolesnyk --- sdk/core/azure-core/CHANGELOG.md | 4 +++- sdk/core/azure-core/inc/azure/core/operation.hpp | 6 ++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/sdk/core/azure-core/CHANGELOG.md b/sdk/core/azure-core/CHANGELOG.md index 453889836..f4faf7d6c 100644 --- a/sdk/core/azure-core/CHANGELOG.md +++ b/sdk/core/azure-core/CHANGELOG.md @@ -6,11 +6,13 @@ ### Breaking Changes +- [[#4662]](https://github.com/Azure/azure-sdk-for-cpp/issues/4662) `Azure::Core::Operation::GetRawResponseInternal()` is now deprecated and no longer requires an overload. + ### Bugs Fixed ### Other Changes -Empty diagnostic messages will no longer be generated. +- Empty diagnostic messages will no longer be generated. ## 1.10.0 (2023-06-01) diff --git a/sdk/core/azure-core/inc/azure/core/operation.hpp b/sdk/core/azure-core/inc/azure/core/operation.hpp index 11e9cce28..05628c0b5 100644 --- a/sdk/core/azure-core/inc/azure/core/operation.hpp +++ b/sdk/core/azure-core/inc/azure/core/operation.hpp @@ -31,6 +31,12 @@ namespace Azure { namespace Core { virtual Response PollUntilDoneInternal(std::chrono::milliseconds period, Context& context) = 0; + [[deprecated("Do not override and do not use.")]] virtual Azure::Core::Http::RawResponse const& + GetRawResponseInternal() const + { + return *m_rawResponse; + } + protected: /** @brief the underlying raw response for this operation. */ std::unique_ptr m_rawResponse = nullptr;