github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Fix an issue that reason phrase is missing as expected from HTTP/2 server (#3879)

Browse Source 
* Fix an issue that reason phrase is missing as expected from HTTP/2 server

* reverse the condition

* compact comments

* fix clang format
This commit is contained in:
keshen-msft 2022-08-10 12:59:47 -07:00 committed by GitHub
parent b5c456c712
commit e019b3ea7e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
sdk/core/azure-core/src/http/winhttp/win_http_transport.cpp
View File

@ -622,17 +622,27 @@ std::unique_ptr<RawResponse> WinHttpTransport::SendRequestAndGetResponse(
std::string reasonPhrase;
DWORD sizeOfReasonPhrase = sizeOfHeaders;
if (WinHttpQueryHeaders(
handleManager->m_requestHandle,
WINHTTP_QUERY_STATUS_TEXT,
WINHTTP_HEADER_NAME_BY_INDEX,
outputBuffer.data(),
&sizeOfReasonPhrase,
WINHTTP_NO_HEADER_INDEX))
// HTTP/2 does not support reason phrase, refer to
// https://www.rfc-editor.org/rfc/rfc7540#section-8.1.2.4.
if (majorVersion == 1)
{
start = outputBuffer.begin();
reasonPhrase
= WideStringToString(std::wstring(start, start + sizeOfReasonPhrase / sizeof(WCHAR)));
if (WinHttpQueryHeaders(
handleManager->m_requestHandle,
WINHTTP_QUERY_STATUS_TEXT,
WINHTTP_HEADER_NAME_BY_INDEX,
outputBuffer.data(),
&sizeOfReasonPhrase,
WINHTTP_NO_HEADER_INDEX))
{
// even with HTTP/1.1, we cannot assume that reason phrase is set since it is optional
// according to https://www.rfc-editor.org/rfc/rfc2616.html#section-6.1.1.
if (sizeOfReasonPhrase > 0)
{
start = outputBuffer.begin();
reasonPhrase
= WideStringToString(std::wstring(start, start + sizeOfReasonPhrase / sizeof(WCHAR)));
}
}
}
// Allocate the instance of the response on the heap with a shared ptr so this memory gets