github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Do not throw an exception during AzureCliCredential construction, but rather delay it on GetToken() call. (#4979)

Browse Source 
* Do not throw an exception during `AzureCliCredential` construction, but rather delay it on GetToken() call.

* Update az cli unsafe chars test.
This commit is contained in:
Ahson Khan 2023-10-05 13:31:29 -07:00 committed by GitHub
parent 9a2c2e1257
commit b5c3c4971d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sdk/identity/azure-identity/src/azure_cli_credential.cpp
View File

@ -92,8 +92,6 @@ AzureCliCredential::AzureCliCredential(
{
static_cast<void>(options);
ThrowIfNotSafeCmdLineInput(m_tenantId, "TenantID");
IdentityLog::Write(
IdentityLog::Level::Informational,
GetCredentialName()
@ -123,6 +121,7 @@ std::string AzureCliCredential::GetAzCommand(std::string const& scopes, std::str
const
{
ThrowIfNotSafeCmdLineInput(scopes, "Scopes");
ThrowIfNotSafeCmdLineInput(m_tenantId, "TenantID");
std::string command = "az account get-access-token --output json --scope \"" + scopes + "\"";
if (!tenantId.empty())

6
sdk/identity/azure-identity/test/ut/azure_cli_credential_test.cpp
View File

@ -325,9 +325,11 @@ TEST(AzureCliCredential, UnsafeChars)
AzureCliCredentialOptions options;
options.TenantId = "01234567-89AB-CDEF-0123-456789ABCDEF";
options.TenantId += Exploit;
AzureCliCredential azCliCred(options);
EXPECT_THROW(
static_cast<void>(std::make_unique<AzureCliCredential>(options)), AuthenticationException);
TokenRequestContext trc;
trc.Scopes.push_back(std::string("https://storage.azure.com/.default"));
EXPECT_THROW(static_cast<void>(azCliCred.GetToken(trc, {})), AuthenticationException);
}
{