github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Added checks to help diagnose intermittent globalCleanUp test failure (#4593)

Browse Source 
* Added checks to help diagnose intermittent globalCleanUp test failure
This commit is contained in:
Larry Osterman 2023-04-28 11:13:02 -07:00 committed by GitHub
parent d8ae044434
commit 2cce17d691
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sdk/core/azure-core/src/http/curl/curl_session_private.hpp
View File

@ -23,6 +23,7 @@
// Define the class name that reads from ConnectionPool private members
namespace Azure { namespace Core { namespace Test {
class CurlConnectionPool_connectionPoolTest_Test;
class SdkWithLibcurl_globalCleanUp_Test;
}}} // namespace Azure::Core::Test
#endif
@ -43,6 +44,7 @@ namespace Azure { namespace Core { namespace Http {
#ifdef TESTING_BUILD
// Give access to private to this tests class
friend class Azure::Core::Test::CurlConnectionPool_connectionPoolTest_Test;
friend class Azure::Core::Test::SdkWithLibcurl_globalCleanUp_Test;
#endif
private:
/**

12
sdk/core/azure-core/test/ut/azure_libcurl_core_main_test.cpp
View File

@ -46,6 +46,12 @@ namespace Azure { namespace Core { namespace Test {
session->Perform(Azure::Core::Context::ApplicationContext);
// Reading all the response
session->ReadToEnd(Azure::Core::Context::ApplicationContext);
// If all three of these conditions are true, the connection should be moved to the connection
// pool.
EXPECT_TRUE(session->IsEOF());
EXPECT_TRUE(session->m_keepAlive);
EXPECT_FALSE(session->m_connectionUpgraded);
}
// Check that after the connection is gone, it is moved back to the pool
EXPECT_EQ(
@ -57,10 +63,10 @@ namespace Azure { namespace Core { namespace Test {
int main(int argc, char** argv)
{
// Declare a signal handler to report unhandled exceptions on Windows - this is not needed for
// other OS's as they will print the exception to stderr in their terminate() function.
// Declare a signal handler to report unhandled exceptions on Windows - this is not needed for
// other OS's as they will print the exception to stderr in their terminate() function.
#if defined(AZ_PLATFORM_WINDOWS)
// Ensure that all calls to abort() no longer pop up a modal dialog on Windows.
// Ensure that all calls to abort() no longer pop up a modal dialog on Windows.
#if defined(_DEBUG) && defined(_MSC_VER)
_CrtSetReportMode(_CRT_ERROR, _CRTDBG_MODE_DEBUG);
#endif