github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

This was first discovered by trying to update curl in vcpkg: https://github.com/microsoft/vcpkg/pull/27778 (#4127)

Browse Source 
Curl is no longer publishing that it depends on ws2_32 when dynamically linked. Azure Core directly uses Ws2_32 things, so it needs that declared dependency. For example:

90fc46693f/sdk/core/azure-core/src/http/curl/curl.cpp (L165)
This commit is contained in:
Billy O'Neal 2022-11-18 16:11:55 -08:00 committed by GitHub
parent 90fc46693f
commit 8934b2118f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sdk/core/azure-core/CMakeLists.txt
View File

@ -179,6 +179,9 @@ endif()
if(BUILD_TRANSPORT_CURL)
target_link_libraries(azure-core PUBLIC CURL::libcurl)
if(WIN32)
target_link_libraries(azure-core PRIVATE Ws2_32)
endif()
endif()
if(BUILD_TRANSPORT_WINHTTP)
target_link_libraries(azure-core PRIVATE winhttp WIL::WIL)