Commit Graph

538 Commits

Author SHA1 Message Date
Victor Vazquez
b0cb94702c
supresss gtest warning from test pw (#2726) 2021-08-10 17:58:22 +00:00
Victor Vazquez
0c041c9bfa
Add core-test recording-playback (#2685)
Recording feature
2021-08-09 15:38:57 -07:00
Azure SDK Bot
4e1cdb985d
Increment package version after release of azure-core (#2715) 2021-08-09 13:20:01 -07:00
Anton Kolesnyk
6bf52bdbde
Update vcpkg version dependencies (#2718) 2021-08-09 13:15:27 -07:00
Victor Vazquez
2b63bc6536
changelog for 1.2.0 release (#2713) 2021-08-05 20:47:51 -07:00
Anton Kolesnyk
7f6930678c
Update changelog to list Clang 11 community contribution (#2707)
* Update changelog for Clang 11 comunity contribution

* Move to correct place, arrange in correct order

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-08-04 10:33:29 -07:00
David Chisnall
eb135023bb
Fix implicit conversion that clang rejects. (#2704)
With clang 11, the build fails with:

```
azure-sdk-for-cpp/sdk/core/azure-core/inc/azure/core/datetime.hpp:285:14: error: no viable conversion from returned value of type 'time_point<Azure::_detail::Clock, typename common_type<duration<long, ratio<1, 10000000> >, duration<long long, ratio<1, 1> > >::type>' (aka 'time_point<Azure::_detail::Clock, duration<long long, ratio<__static_gcd<ratio<1, 10000000>::num, ratio<1, 1>::num>::value, __static_lcm<ratio<1, 10000000>::den, ratio<1, 1>::den>::value> > >') to function return type 'Azure::DateTime'
      return DateTime(1970) + std::chrono::seconds(posixTime);
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
2021-08-03 13:13:16 -07:00
Victor Vazquez
2feed76d86
clang doc fixes (#2697) 2021-08-02 11:55:08 -07:00
Victor Vazquez
554feb13b8
typo (#2700) 2021-08-02 11:54:56 -07:00
JinmingHu
b1c8ea92dc
Change the order of some built-in policies and client policies (#2670) 2021-07-29 10:07:09 +08:00
Anton Kolesnyk
326af88078
Make WinHTTP transport adapter to NOT use SSL/TLS for unsecured HTTP connections (#2678)
* Make WinHTTP transport adapter to NOT use SSL/TLS for unsecured HTTP connections

* Update changelog for identity as well

* LocaleInvariantCaseInsensitiveEqual + micro-optimization to avoid creating&allocating std::string each time

* Update sdk/identity/azure-identity/CHANGELOG.md

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2021-07-28 10:55:54 -07:00
Victor Vazquez
5c14975957
remove prefer ninja (#2675) 2021-07-27 19:26:11 -07:00
Victor Vazquez
a508789c36
Remove warning supress (#2677)
* remove warning suppress not required anymore

* json update

* update the curl header including

* changelog
2021-07-27 18:09:52 -07:00
Victor Vazquez
0567145212
support connection close header (#2672) 2021-07-27 10:03:56 -07:00
George Arama
0d4f138cb3
GetSecret Api implementation for Keyvault Secret (#2656)
* Progress stream reader

* format

* Update sdk/core/azure-core/src/io/body_stream.cpp

Co-authored-by: JinmingHu <jinmhu@microsoft.com>

* PR comments

* remove

* one more comment

* replaced if null with azure_assert

* moved from pointer to reference

* first pass

* src builds

* new line

* huzaaaaa

* readme

* strating point

* get progress, need to deserialize now

* serializer

* some more

* tests

* more tests

* some refactor

* start

* comment and formatting

* working again

* couple of updates

* clang

* remove pedantic ;

* include

* pr comments

* clang format

* trigger

* trigger 2

* PR comments

* name value swap

Co-authored-by: JinmingHu <jinmhu@microsoft.com>
2021-07-23 17:36:04 -07:00
George Arama
1f15e046e0
Progress stream reader (#2563)
* Progress stream reader

* format

* Update sdk/core/azure-core/src/io/body_stream.cpp

Co-authored-by: JinmingHu <jinmhu@microsoft.com>

* PR comments

* remove

* one more comment

* replaced if null with azure_assert

* moved from pointer to reference

* PR comments

* clang

Co-authored-by: JinmingHu <jinmhu@microsoft.com>
2021-07-20 13:28:48 -07:00
Anton Kolesnyk
89222f1950
Remove curl version from vcpkg manifest (#2572) 2021-07-10 01:44:01 -07:00
Azure SDK Bot
0a6a5080a9
Increment package version after release of azure-core (#2553) 2021-07-09 14:33:56 -07:00
George Arama
e8efcd21fd
2559 doc warnings (#2573)
* fix doc warnings

* format
2021-07-07 15:23:22 -07:00
JinmingHu
a8d7a48a07
Fix Bug: libcurl transport layer hangs on 304 response (#2558) 2021-07-06 18:28:32 +00:00
Victor Vazquez
f2413d11f5
update change log (#2551)
* update change log

* update change log
2021-07-02 11:03:11 -07:00
Anton Kolesnyk
6e4e9fd54b
Prepare Core and Identity releases (#2527)
* Prepare Core and Identity releases

* One more file

* Move to Other Changes

* Apply suggestions from code review

Co-authored-by: Ahson Khan <ahkha@microsoft.com>

* identity bugs fixed header

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
2021-07-01 16:06:36 -07:00
Ahson Khan
863e9871e5
Make sure RFE Message is only set to the response body payload. (#2539)
* Make sure RFE Message is only set to the response body payload.

* Add a note about the Message property.

* Jeff likes wordsmithing things for fun.
2021-07-01 15:56:20 -07:00
Ahson Khan
d0ca42643f
Move Sha256Hash and other Hash algorithm types from KeyVault to Azure::Core (#2526)
* Move the SHA256, 384, and 512 Hash implementations to be internal.

* Update changelog and add back missing file.

* Rename SHA256 and others to Sha256Hash and update header name.

* Fix up path in CMakeList by removing quotes.

* Rename the sha.cpp source file to match header.

* Move Sha256Hash and other Hash algorithm types from KeyVault to
Azure::Core.

* Reorder src file in cmakelist to be alpha order just to reset CI

* Revert "Reorder src file in cmakelist to be alpha order just to reset CI"

This reverts commit 6729cf311af76bb8388738cc519ea40092bc362c.
2021-07-01 15:42:36 -07:00
Ahson Khan
731d07c2cc
Fix up the implementation details of the RequestFailedException ctor. (#2536) 2021-07-01 14:08:05 -07:00
Ahson Khan
a2f027f0df
Disable C28020 warning in json.hpp as a stop gap on Windows. (#2535) 2021-07-01 14:04:16 -07:00
Ahson Khan
a6f3b530d5
Move Base64Url helper internal methods from KeyVault to Azure Core. (#2528)
* Move Base64Url helper internal methods from KeyVault to Azure Core.

* Run clang format.
2021-07-01 12:24:38 -07:00
Anton Kolesnyk
d4e347b4f1
Core Readme: reorder Key Concepts, remove Distributed Tracing (#2532)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-07-01 11:00:19 -07:00
Anton Kolesnyk
3f5c5ae664
Managed Identity Credential (#2448) 2021-07-01 09:16:26 -07:00
George Arama
c449e3f9bc
2502 exceptions (#2529)
* first pass

* move exception creation from keyvault to core

* merge fix

* format

* fix includes location and containers

* remove default constructor

* to trigger build

* undo change

* uncomment

* Update sdk/core/azure-core/test/ut/exception_test.cpp

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2021-07-01 04:17:15 +00:00
Anton Kolesnyk
8f1b5b95e3
Move POSIX time converter from KeyVault to Core (#2524)
* Move POSIX time converter from KeyVault to Core

* Move to Core namespace

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-06-30 17:23:20 -07:00
Anton Kolesnyk
f6765e667e
Put dependency versions (#2518)
* Put dependency versions

* Update version

* Core does not have any 1.1 functionality

* Core 1.1

* 1.1.0

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-06-30 17:05:16 -07:00
Anton Kolesnyk
c8006b4673
Readme section on logging (#2521)
* Readme section on logging

* Apply suggestions from code review

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

* Update sdk/core/azure-core/README.md

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2021-06-30 16:49:30 -07:00
Anton Kolesnyk
40ab9315d1
Credit community contributors in changelogs (#2519)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-06-30 15:51:27 -07:00
Wes Haggard
015c34a029
Update links from master to main (#2488)
* Update links from master to main

* Upate other references from master to main
2021-06-24 22:27:14 -07:00
Victor Vazquez
7a31ca5dd3
Fix Main - ignore warning 6101 (#2471)
* Ignoring msvc warning 6101

* remove not required

* not required

* perf issues

* fix livetests build args
2021-06-23 23:50:07 +00:00
Ahson Khan
1950e6d655
Use TCP fast open and false start to reduce RTT from 3 to 1, when using WinHttp on latest Windows OS. (#2253)
* Use TCP fast open and false start to reduce RTT from 3 to 1, when using WinHttp on latest Windows OS.

* Address PR feedback - Remove logging the error.
2021-06-22 16:06:24 -07:00
George Arama
70c3e72763
Add Unit Tests for EnvironmentLogLevelListener (#2454)
* first UT

* formatting

* unused error

* putenv

* some refactoring

* formatting

* casting

* again

* Update sdk/core/azure-core/test/ut/environmentLogLevelListener_test.cpp

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

* some refactoring

* more tests

* format

* no env test

* put back missing empty line

* Update sdk/core/azure-core/test/ut/environmentLogLevelListener_test.cpp

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

* PR comments

* fix signed/unsigned mismatch that causes ci build to fail

Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2021-06-22 21:51:41 +00:00
Victor Vazquez
2ea2cf8b57
updates from review (#2465)
* updates from review

* cast

* use U for unsigned int
2021-06-21 18:34:59 +00:00
Victor Vazquez
da1451586a
Upload blob perf test + RandomStream class for utility (#2433)
* random stream

* upload blob perf test

* upload perf blob test

* undo
2021-06-18 10:05:52 -07:00
Daniel Jurek
fda88bf7b8
Update for "master" -> "main" branch rename (#2455)
* vcpkg.json -- update all links to point to "main" .. This is hardcoded and will go out in future releases.
* ci.yml -- add `- main` to trigger criteria near `- master` ... This adds forward compatilbitiy when we rename the branch in the repo
* archetype-cpp-release.yml use a script which evaluates a repo's default branch and sets that in a global variable, then use that variable instead. When vcpkg updates their branch the publishing scripts will work transparently.
* Collect-Changelogs.ps1 -- Add default hardcoded branch name for use with future releases. This can be optionally overridden with a parameter when invoking the script.
* eng/pipelines/client.yml -- Delete this file. It is no longer in use.
2021-06-18 09:09:27 -07:00
Mitch Denny
01ba0b0c9c
Add main to CI files. (#2462) 2021-06-19 01:55:34 +10:00
Victor Vazquez
81e0d5aab0
use size_t for buffers in libcurl internal impl (#2376)
* use size_t for buffers in libcurl internal impl
2021-06-14 14:28:36 -07:00
JinmingHu
325466ecae
Fix memory leak in Base64Encode (#2441)
* Fix memory leak

* cl
2021-06-10 10:02:01 +08:00
Ahson Khan
479134595b
Consolidate the use of std::size_t and always use size_t instead, since it is a "primitive" type. (#2415)
* Consolidate the use of std::size_t and always use size_t instead, since
it is a type.

* Fix clang formatting.
2021-06-09 11:09:54 -07:00
Jørgen Lind
b2a21c665d
Fix small "Use after free" bug (#2409)
Co-authored-by: Jørgen Lind <jorgen.lind@bluware.com>
2021-06-09 00:42:40 -07:00
JinmingHu
a3be057f59
We should NOT deal with any network connections while holding mutex (#2355)
* try to fix hang issue in core sdk

* clang-format

* fix more

* fix
2021-06-09 00:40:44 -07:00
Azure SDK Bot
d6888ba412
Increment package version after release of azure-core (#2402) 2021-06-09 00:38:37 -07:00
Ahson Khan
af79bf2e72
Update Azure Core Changelog for the upcoming GA release. (#2391)
* Update Azure Core Changelog for the upcoming GA release.

* update version

* Add a bug fix section.

* Update CHANGELOG.md

Co-authored-by: Victor Vazquez <vhvb1989@gmail.com>
2021-06-04 11:38:03 -07:00
Anton Kolesnyk
75a17b00a6
Doxygen PR follow-up (#2390) 2021-06-03 12:41:05 -07:00
Anton Kolesnyk
7a4ebdf73d
Docs: link to root Getting Started section from Core's readme (#2386)
* Docs: link to root Getting Started section from Core's readme

* Update sdk/core/azure-core/README.md

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-06-03 10:59:09 -07:00
Anton Kolesnyk
3b9d29c068
Core: Doxygen: Constructors, destructors, operators, and context parameter (#2378)
* Core: Doxygen: Constructors, destructors, operators, and context parameter.

* '; otherwise, `false`.'

* Clang format

* Fix spelling

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-06-03 10:57:37 -07:00
Anton Kolesnyk
bae5f553a2
Expand docs docs for RetryOptions (#2385)
* Better docs for RetryOptions

* Update sdk/core/azure-core/inc/azure/core/http/policies/policy.hpp

Co-authored-by: Ahson Khan <ahkha@microsoft.com>

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: Ahson Khan <ahkha@microsoft.com>
2021-06-02 17:58:29 -07:00
Victor Vazquez
9fd5806c14
remove move from const (#2375) 2021-06-02 09:37:35 -07:00
Victor Vazquez
32944b61a7
remove extra const (#2371) 2021-06-01 10:07:18 -07:00
Victor Vazquez
da252f76f7
remove duplicated headers and update tests (#2369) 2021-06-01 10:02:55 -07:00
Anton Kolesnyk
15c525d387
Fix empty rethrows, update some catches to catch all (#2362)
* Fix empty rethrows, update some catches to catch all

* AZURE_UNREACHABLE_CODE()

Co-authored-by: JinmingHu <jinmhu@microsoft.com>

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: JinmingHu <jinmhu@microsoft.com>
2021-05-28 09:24:42 -07:00
Anton Kolesnyk
a742608406
Catch as const whenever possible (#2361)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-05-28 01:52:59 -07:00
Anton Kolesnyk
cb862f56b5
Add x-ms-request-id to a default list of unredacted log headers (#2359)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-05-28 01:51:53 -07:00
JinmingHu
3f56fac50c
fix a crash issue when copying a RequestFailedException with null RawResponse #2358 2021-05-27 10:33:36 -07:00
Victor Vazquez
3596685e80
disable warning from Functional header (#2352)
* update the correct warning
2021-05-26 22:50:58 +00:00
Victor Vazquez
73d5ba0d2d
Doc changes for HTTP and removing the "More" link (#2332)
* update docs from classes

* remove more link from classes part II

* http docs

* Update sdk/core/azure-core/inc/azure/core/http/http.hpp

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

* Update cmake-modules/AzureDoxygen.cmake

* doc updates

* update RFC

Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2021-05-25 14:02:14 -07:00
Victor Vazquez
88dc1ac8cf
adding Test file sufix to all tests (#2337)
* azure core

* perf

* identity

* keyvault

* storage
2021-05-25 11:15:30 -07:00
Azure SDK Bot
6012511293
Increment package version after release of azure-core (#2322) 2021-05-21 13:38:07 -07:00
JinmingHu
f2c0546386
Add explicit assignment and desctructor for RawResponse and RequestFailedException (#2312) 2021-05-21 09:44:34 +08:00
Anton Kolesnyk
dcb2506862
Docs: 'base 64' => Base64 (#2327)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-05-19 11:08:14 -07:00
Ahson Khan
0a0bd6fbc2
Update changelog for the upcoming beta release. (#2309)
Holding off to do a review of the commits.

Area owners, please review yourself as well, and fix what might be missing or needs updating.
2021-05-19 04:31:36 +00:00
Ahson Khan
75d17550f2
Add argument validation to public APIs. Throw or Precondition/assert failure? (#2189)
* Add argument validation to public APIs.

* Add exception to spell check.

* Revert "Add exception to spell check."

This reverts commit be54b614cc1427ddb2f154f5927f4e612a4a1e28.

* Turn invalid arg excetion to a precondition assert for bodystream read.

* User assert in more places within body_stream.

* Update valiation for hashing and bodystream and update tests.

* Update  precondition test for size_t and add null ptr check

* Fix clang formatting.

* Update changelog and fix up the message for size_t validation in hash.

* Address PR feedback.

* More PR feedback.

* Remove unnecessary comment from test.

* Fix clang format.
2021-05-18 20:10:14 -07:00
Anton Kolesnyk
e5763720d4
Vcpkg fixes (#2311)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-05-18 19:33:59 -07:00
Ahson Khan
65821ec115
Use size_t for buffers representing data in memory rather than int64_t. (#2285)
* Use size_t for buffers representing data in memory rather than int64_t.

* add a cast from size_t to int64_t

* Address feedback - OnRead return size_t.

* Change Read and ReadToCount to return size_t instead of int64_t.

* Update curl usage and ReadFromSocket.

* Missed one signature.

* Update changelog.

* Update transport layer to use the right size_t size.

* Fix curl use of MBS.

* Cast to size_t since that's all memory stream supprts.

* Add static casts to size_t as temporary workarounds.

* update storage tests.

* More test fixes.
2021-05-18 18:51:20 -07:00
JinmingHu
9261e9ddae
copy constructor for RequestFailedException (#2291)
* copy constructor for RequestFailedException

* Apply suggestions from code review

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2021-05-18 22:58:11 +00:00
Ahson Khan
ff126f1eb7
Explore removing use of int within header files to align with guidelines. (#2276)
Part of https://github.com/Azure/azure-sdk-for-cpp/issues/2226

Trying to focus mainly on headers, depending on the conclusion, we'd want to make cpp file changes as well, but that can be done later.

Assuming this is the guideline we want:
https://azure.github.io/azure-sdk/cpp_implementation.html#integer-sizes

![image](https://user-images.githubusercontent.com/6527137/118341184-00d52580-b4d3-11eb-8e96-937cb5899c92.png)

Some places that we still use `int` is for things like unix file desriptor or where APIs like BIO_read from OpenSSL returns an int. Are those exceptions OK?
0b64ab3845/sdk/core/azure-core/inc/azure/core/io/body_stream.hpp (L166)
308e5363ad/sdk/core/azure-core/src/base64.cpp (L87)
2021-05-18 20:49:53 +00:00
Anton Kolesnyk
898a8aee84
Remove Azure::Core::Diagnostics::Logger::Listener typedef (#2282) 2021-05-18 11:43:11 -07:00
Anton Kolesnyk
00dfcc2beb
Doxygen comment updates (#2280) 2021-05-17 17:05:06 -07:00
Rick Winter
8c5a885299
Documentation updates (#2277) 2021-05-17 23:59:47 +00:00
Victor Vazquez
e4a18b5eb3
Fault injection test (#2265)
* missing line for single docs

* format

* fault injection test

* winHttp

* storage blobs client with fault injector
2021-05-17 10:34:50 -07:00
JinmingHu
af936e052f
use AZURE_ASSERT in storage code (#2262)
* use AZURE_ASSERT in storage code

* fix build

* clang-format

* fix
2021-05-17 10:06:26 +08:00
Rick Winter
92839dcc56
A few spot fixes in docs (#2275) 2021-05-14 23:42:25 +00:00
Ahson Khan
0b64ab3845
Fix the casing of WinHttp and use WinHTTP (#2274)
Part of https://github.com/Azure/azure-sdk-for-cpp/issues/2260
2021-05-14 23:34:39 +00:00
Anton Kolesnyk
efe4772acb
Update upper/lower/other casing (#2267)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-05-14 12:54:16 -07:00
Anton Kolesnyk
00c47e8ec3
Delete vcpkg readme (#2268)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-05-14 12:53:59 -07:00
Victor Vazquez
f4febae12c
missing line for single docs (#2264)
* missing line for single docs

* format
2021-05-13 17:41:48 -07:00
Anton Kolesnyk
530e49b217
Document final/virtual destructor changes (#2256) 2021-05-12 11:38:17 -07:00
Ahson Khan
ffd0860e00
Avoid using WinHttpQueryDataAvailable, and use WinHttpReadData directly for better throughput. (#2245)
* Avoid using WinHttpQueryDataAvailable, and use WinHttpReadData directly for better throughput.

* Add back new line at end of file.

* Reorder some lines for readability.
2021-05-11 20:03:14 -07:00
Anton Kolesnyk
019db35863
Add final specifier (#2237) 2021-05-10 11:57:40 -07:00
Ahson Khan
a103e51869
Rename IsBufferedDownload to ShouldBufferResponse to avoid using a (#2210)
storage specific verb in general purpose Request object.
2021-05-07 16:53:07 -07:00
Ahson Khan
23136690af
Add a key type pair context precondition test. (#2223)
* Add a key type pair context precondition test.

* Fixup test since after overriding the key type getting an int value should fail.
2021-05-07 16:22:01 -07:00
Ahson Khan
fd9c3e5ebb
Fix true spelling errors across all source and header files within the SDK and add exceptions for false positives. (#2209)
Part of https://github.com/Azure/azure-sdk-for-cpp/issues/1277, checking what types of warnings the CI emits.

Verified all SDK product `.cpp`, `.hpp`, `.txt`, and `.md` files, primarily focused on azure-core. They are all clean now. There are some exceptions that needs to be added for keyvault and storage, but they are false positives, so not a concern.

> `cspell lint --config .vscode/cspell.json *.hpp */**/*.hpp`

CSpell: Files checked: 188, Issues found: 0 in 0 files

> `cspell lint --config .vscode/cspell.json *.cpp */**/*.cpp`

CSpell: Files checked: 186, Issues found: 88 in 15 files (keyvault and storage false positives, or tests)

> `cspell lint --config .vscode/cspell.json *.md */**/*.md`

CSpell: Files checked: 45, Issues found: 5 in 2 files (eng/common)

> `cspell lint --config .vscode/cspell.json *.txt */**/*.txt`

CSpell: Files checked: 44, Issues found: 0 in 0 files

> `cspell lint --config .vscode/cspell.json *.* */**/*`

CSpell: Files checked: 646, Issues found: 328 in 69 files (most of these are in eng\docs\api\assets\style.css or eng/common)

Deprioritize and ignored the errors from the test files (including test resource json files), and `eng/common` since those need to be centrally fixed.
2021-05-07 21:04:58 +00:00
Ahson Khan
597aac06c2
Removed the Azure::Core::Http::Request ctor overload that takes both a bodyStream and a bufferedDownload boolean since it is not used anywhere. (#2212)
* Removed the `Azure::Core::Http::Request` ctor overload that takes both a `bodyStream` and a `bufferedDownload` boolean since it is not used anywhere.

* Add back the unit tests by making them friends.

* Add back line at end of file.
2021-05-07 12:45:12 -07:00
Anton Kolesnyk
43ee2ee192
Additional tests for Nullable<T> (#2215)
Closes #1786
2021-05-07 16:11:41 +00:00
Victor Vazquez
08c8147f54
Update abort() for AZURE_ASSERT (#2170)
* remove abort from Core
2021-05-06 15:30:46 -07:00
Ahson Khan
7982417480
Fix up wording in changelog for azure core (#2208)
Addressing https://github.com/Azure/azure-sdk-for-cpp/pull/2200#discussion_r626994352
2021-05-06 20:18:37 +00:00
Victor Vazquez
8e4a1ae59b
Rename download via stream (#2196)
rename parameter for download stream
2021-05-06 02:42:38 +00:00
Ahson Khan
7f0792f114
Add transport layer unit tests with non-ascii host strings as input. (#2198)
* Add transport layer unit tests with non-ascii host strings as input.

* Update test string.
2021-05-05 17:18:46 -07:00
Ahson Khan
e1340dcfa8
Check for context cancellation in more places within the winhttp transport layer before each I/O call. (#2185)
* Check for context cancellation in more places within the winhttp transport layer before each I/O call.

* Update cspell to add exceptions to false positives.

* Address PR feedback.

* Do not check for context cancellation before querying the response headers.
2021-05-05 17:17:54 -07:00
Rick Winter
22770cabbf
Add changelog entry for Uuid improvement (#2200) 2021-05-06 00:09:21 +00:00
Ahson Khan
a77686938a
Remove exposing windows.h header from our public headers and reduce risk of introducing it in non-public headers (#2188)
Fixes https://github.com/Azure/azure-sdk-for-cpp/issues/1853
2021-05-05 23:49:18 +00:00
Victor Vazquez
10d244e511
LRO operation resume token - following factory method design (#2195)
* Add tests for resume token pattern

* update deleteKeyOperation
2021-05-05 23:14:31 +00:00
Victor Vazquez
aa3b6f18f3
Adding noexcpt to isCancelled (#2197)
* Adding noexcpt to isCancelled

* revert cl
2021-05-05 22:01:01 +00:00
Rick Winter
0490d69e02
Ensure random Uuid generation (#2194)
Posix platforms do not generate secure random bytes with random_device().

On posix platforms use the openSSL random byte generator which generates cryptographically secure random bytes

**NOTE**: Once the assert work is done this abort() will be switched over to assert.
2021-05-05 21:41:39 +00:00