Remove warning supress (#2677)

* remove warning suppress not required anymore

* json update

* update the curl header including

* changelog

doc/LibCurlTransportAdatper.md

@@ -1,37 +0,0 @@
-# Libcurl Transport Adapter
-
-The Azure SDK for C++ provides an HTTP transport adapter implementation using the well known libcurl library. There are some general guidelines that you should know if you decide to use this implementation.
-
-## Global init and clean up
-
-Libcurl provides the functions [curl_global_init](https://curl.se/libcurl/c/curl_global_init.html) and [curl_global_cleanup](https://curl.se/libcurl/c/curl_global_cleanup.html) which are expected to be called at the start and before exiting the application. However, for a modular part of the application, like a library, it is expected that each library using libcurl will call the `curl_global_init` and `curl_global_cleanup`. From [libcurl global constants documentation](https://curl.se/libcurl/c/libcurl.html):
-
-> Note that if multiple modules in the program use libcurl, they all will separately call the libcurl functions, and that's OK because only the first curl_global_init and the last curl_global_cleanup in a program change anything. (libcurl uses a reference count in static memory).
-
-Consider the next example:
-
-```cpp
-// Copyright (c) Microsoft Corporation. All rights reserved.
-// SPDX-License-Identifier: MIT
-
-/**
- * @file Demonstrate how to use libcurl and the Azure SDK for C++.
- *
- */
-
-#include <curl/curl.h>
-#include <azure/storage/blob/blobs.hpp>
-
-int main(int argc, char** argv)
-{
-  curl_global_init(CURL_GLOBAL_ALL);
-
-  // Use the Azure SDK clients.
-
-  curl_global_cleanup();
-  return 0;
-}
-
-```
-
-If the application is not using libcurl at all, only the Azure SDK library will call `curl_global_init` and `curl_global_cleanup`. If the application is calling the global functions and using libcurl, then the calls to these functions from the Azure SDK library won't change anything. So, as an application or library owner, you only need to worry about calling the global libcurl functions if you will be using libcurl directly.

sdk/core/azure-core/CHANGELOG.md

@@ -11,6 +11,7 @@
 ### Bugs Fixed
 
 - [2647](https://github.com/Azure/azure-sdk-for-cpp/issues/2647) Make the curl transport adapter to check the connection close header.
+- [2474](https://github.com/Azure/azure-sdk-for-cpp/issues/2474) Fix compiling with MSVC and /analyze.
 
 ### Other Changes
 

sdk/core/azure-core/CMakeLists.txt

@@ -152,12 +152,6 @@ if(BUILD_TRANSPORT_WINHTTP)
   target_link_libraries(azure-core PRIVATE winhttp)
 endif()
 
-if (MSVC)
-  # Disable warnings:
-  # - C6101: Returning uninitialized memory '*Mtu' -> libcurl calling WSAGetIPUserMtu from WS2tcpip.h
-  target_compile_options(azure-core PUBLIC /wd6101)
-endif()
-
 get_az_version("${CMAKE_CURRENT_SOURCE_DIR}/src/private/package_version.hpp")
 generate_documentation(azure-core ${AZ_LIBRARY_VERSION})
 

sdk/core/azure-core/inc/azure/core/internal/json/json.hpp

@@ -2176,7 +2176,7 @@ _az_JSON_HEDLEY_DIAGNOSTIC_PUSH
     class exception : public std::exception {
     public:
       /// returns the explanatory string
-      _az_JSON_HEDLEY_RETURNS_NON_NULL const char* what() const noexcept override
+      const char* what() const noexcept override
       {
         return m.what();
       }

sdk/core/azure-core/src/http/curl/curl.cpp

@@ -27,7 +27,6 @@
 #endif
 
 #include <algorithm>
-#include <curl/curl.h>
 #include <string>
 #include <thread>
 

sdk/core/azure-core/src/http/curl/curl_connection_pool_private.hpp

@@ -17,7 +17,6 @@
 #include <atomic>
 #include <azure/core/http/curl_transport.hpp>
 #include <condition_variable>
-#include <curl/curl.h>
 #include <list>
 #include <map>
 #include <memory>

sdk/core/azure-core/src/http/curl/curl_connection_private.hpp

@@ -12,9 +12,20 @@
 #include "azure/core/http/http.hpp"
 
 #include <chrono>
-#include <curl/curl.h>
 #include <string>
 
+#if defined(_MSC_VER)
+// C6101 : Returning uninitialized memory '*Mtu'->libcurl calling WSAGetIPUserMtu from WS2tcpip.h
+#pragma warning(push)
+#pragma warning(disable : 6101)
+#endif
+
+#include <curl/curl.h>
+
+#if defined(_MSC_VER)
+#pragma warning(pop)
+#endif
+
 namespace Azure { namespace Core { namespace Http {
 
   namespace _detail {

sdk/core/azure-core/test/ut/azure_core_test.cpp

@@ -5,7 +5,6 @@
 
 #if defined(BUILD_CURL_HTTP_TRANSPORT_ADAPTER)
 #include <azure/core/platform.hpp>
-#include <curl/curl.h>
 #include <signal.h>
 #endif
 

sdk/core/azure-core/test/ut/azure_libcurl_core_main_test.cpp

@@ -16,8 +16,6 @@
 
 #include <gtest/gtest.h>
 
-#include <curl/curl.h>
-
 #include <azure/core/context.hpp>
 #include <azure/core/http/curl_transport.hpp>
 #include <azure/core/http/http.hpp>

sdk/core/azure-core/test/ut/curl_session_test.hpp

@@ -19,7 +19,6 @@
 #endif // _MSC_VER
 
 #include <azure/core/http/curl_transport.hpp>
-#include <curl/curl.h>
 #include <gmock/gmock.h>
 #include <gtest/gtest.h>
 #include <string>

sdk/core/perf/test/inc/azure/perf/test/curl_http_client_get_test.hpp

@@ -13,8 +13,6 @@
 
 #include <azure/core/http/curl_transport.hpp>
 
-#include <curl/curl.h>
-
 namespace Azure { namespace Perf { namespace Test {
   /**
    * @brief A performance test that defines a test option.

sdk/identity/azure-identity/test/live/azure_identity_live_test.cpp

@@ -3,12 +3,6 @@
 
 #include <gtest/gtest.h>
 
-#if defined(BUILD_CURL_HTTP_TRANSPORT_ADAPTER)
-#include <azure/core/platform.hpp>
-#include <curl/curl.h>
-#include <signal.h>
-#endif
-
 int main(int argc, char** argv)
 {
   testing::InitGoogleTest(&argc, argv);

sdk/keyvault/azure-security-keyvault-keys/test/ut/azure_security_keyvault_keys_test.cpp

@@ -3,10 +3,6 @@
 
 #include "gtest/gtest.h"
 
-#if defined(BUILD_CURL_HTTP_TRANSPORT_ADAPTER)
-#include <curl/curl.h>
-#endif
-
 int main(int argc, char** argv)
 {
   testing::InitGoogleTest(&argc, argv);