github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Removed the Azure::Core::Http::Request ctor overload that takes both a bodyStream and a bufferedDownload boolean since it is not used anywhere. (#2212)

Browse Source 
* Removed the `Azure::Core::Http::Request` ctor overload that takes both a `bodyStream` and a `bufferedDownload` boolean since it is not used anywhere.

* Add back the unit tests by making them friends.

* Add back line at end of file.
This commit is contained in:
Ahson Khan 2021-05-07 12:45:12 -07:00 committed by GitHub
parent 43ee2ee192
commit 597aac06c2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sdk/core/azure-core/CHANGELOG.md
View File

@ -10,6 +10,7 @@
- Removed `Context::GetApplicationContext()` in favor of a new static data member `Context::ApplicationContext`.
- Renamed `Request::IsDownloadViaStream()` to `IsBufferedDownload()`.
- Removed the `Azure::Core::Http::Request` ctor overload that takes both a `bodyStream` and a `bufferedDownload` boolean since it is not useful.
### Bug Fixes

19
sdk/core/azure-core/inc/azure/core/http/http.hpp
View File

@ -36,6 +36,14 @@ namespace Azure { namespace Core { namespace Test {
class TestHttp_RequestStartTry_Test;
class TestURL_getters_Test;
class TestURL_query_parameter_Test;
class TransportAdapter_headWithStream_Test;
class TransportAdapter_putWithStream_Test;
class TransportAdapter_deleteRequestWithStream_Test;
class TransportAdapter_patchWithStream_Test;
class TransportAdapter_putWithStreamOnFail_Test;
class TransportAdapter_SizePutFromFile_Test;
class TransportAdapter_SizePutFromFileDefault_Test;
class TransportAdapter_SizePutFromFileBiggerPage_Test;
}}} // namespace Azure::Core::Test
#endif
@ -119,6 +127,15 @@ namespace Azure { namespace Core { namespace Http {
friend class Azure::Core::Test::TestHttp_RequestStartTry_Test;
friend class Azure::Core::Test::TestURL_getters_Test;
friend class Azure::Core::Test::TestURL_query_parameter_Test;
// make tests classes friends to validate private Request ctor that takes both stream and bool
friend class Azure::Core::Test::TransportAdapter_headWithStream_Test;
friend class Azure::Core::Test::TransportAdapter_putWithStream_Test;
friend class Azure::Core::Test::TransportAdapter_deleteRequestWithStream_Test;
friend class Azure::Core::Test::TransportAdapter_patchWithStream_Test;
friend class Azure::Core::Test::TransportAdapter_putWithStreamOnFail_Test;
friend class Azure::Core::Test::TransportAdapter_SizePutFromFile_Test;
friend class Azure::Core::Test::TransportAdapter_SizePutFromFileDefault_Test;
friend class Azure::Core::Test::TransportAdapter_SizePutFromFileBiggerPage_Test;
#endif
private:
@ -137,7 +154,6 @@ namespace Azure { namespace Core { namespace Http {
// previously called
void StartTry();
public:
/**
* @brief Construct an #Azure::Core::Http::Request.
*
@ -157,6 +173,7 @@ namespace Azure { namespace Core { namespace Http {
{
}
public:
/**
* @brief Construct an #Azure::Core::Http::Request.
*