From 597aac06c2bd7f309e4e26aacbfe2daa07acf674 Mon Sep 17 00:00:00 2001
From: Ahson Khan <ahson_ahmedk@yahoo.com>
Date: Fri, 7 May 2021 12:45:12 -0700
Subject: [PATCH] Removed the `Azure::Core::Http::Request` ctor overload that
 takes both a `bodyStream` and a `bufferedDownload` boolean since it is not
 used anywhere. (#2212)

* Removed the `Azure::Core::Http::Request` ctor overload that takes both a `bodyStream` and a `bufferedDownload` boolean since it is not used anywhere.

* Add back the unit tests by making them friends.

* Add back line at end of file.
---
 sdk/core/azure-core/CHANGELOG.md              |  1 +
 .../azure-core/inc/azure/core/http/http.hpp   | 19 ++++++++++++++++++-
 2 files changed, 19 insertions(+), 1 deletion(-)

diff --git a/sdk/core/azure-core/CHANGELOG.md b/sdk/core/azure-core/CHANGELOG.md
index 6073b77b0..e5920bfee 100644
--- a/sdk/core/azure-core/CHANGELOG.md
+++ b/sdk/core/azure-core/CHANGELOG.md
@@ -10,6 +10,7 @@
 
 - Removed `Context::GetApplicationContext()` in favor of a new static data member `Context::ApplicationContext`.
 - Renamed `Request::IsDownloadViaStream()` to `IsBufferedDownload()`.
+- Removed the `Azure::Core::Http::Request` ctor overload that takes both a `bodyStream` and a `bufferedDownload` boolean since it is not useful.
 
 ### Bug Fixes
 
diff --git a/sdk/core/azure-core/inc/azure/core/http/http.hpp b/sdk/core/azure-core/inc/azure/core/http/http.hpp
index c2beabd90..efe07b868 100644
--- a/sdk/core/azure-core/inc/azure/core/http/http.hpp
+++ b/sdk/core/azure-core/inc/azure/core/http/http.hpp
@@ -36,6 +36,14 @@ namespace Azure { namespace Core { namespace Test {
   class TestHttp_RequestStartTry_Test;
   class TestURL_getters_Test;
   class TestURL_query_parameter_Test;
+  class TransportAdapter_headWithStream_Test;
+  class TransportAdapter_putWithStream_Test;
+  class TransportAdapter_deleteRequestWithStream_Test;
+  class TransportAdapter_patchWithStream_Test;
+  class TransportAdapter_putWithStreamOnFail_Test;
+  class TransportAdapter_SizePutFromFile_Test;
+  class TransportAdapter_SizePutFromFileDefault_Test;
+  class TransportAdapter_SizePutFromFileBiggerPage_Test;
 }}} // namespace Azure::Core::Test
 #endif
 
@@ -119,6 +127,15 @@ namespace Azure { namespace Core { namespace Http {
     friend class Azure::Core::Test::TestHttp_RequestStartTry_Test;
     friend class Azure::Core::Test::TestURL_getters_Test;
     friend class Azure::Core::Test::TestURL_query_parameter_Test;
+    // make tests classes friends to validate private Request ctor that takes both stream and bool
+    friend class Azure::Core::Test::TransportAdapter_headWithStream_Test;
+    friend class Azure::Core::Test::TransportAdapter_putWithStream_Test;
+    friend class Azure::Core::Test::TransportAdapter_deleteRequestWithStream_Test;
+    friend class Azure::Core::Test::TransportAdapter_patchWithStream_Test;
+    friend class Azure::Core::Test::TransportAdapter_putWithStreamOnFail_Test;
+    friend class Azure::Core::Test::TransportAdapter_SizePutFromFile_Test;
+    friend class Azure::Core::Test::TransportAdapter_SizePutFromFileDefault_Test;
+    friend class Azure::Core::Test::TransportAdapter_SizePutFromFileBiggerPage_Test;
 #endif
 
   private:
@@ -137,7 +154,6 @@ namespace Azure { namespace Core { namespace Http {
     // previously called
     void StartTry();
 
-  public:
     /**
      * @brief Construct an #Azure::Core::Http::Request.
      *
@@ -157,6 +173,7 @@ namespace Azure { namespace Core { namespace Http {
     {
     }
 
+  public:
     /**
      * @brief Construct an #Azure::Core::Http::Request.
      *