github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

updates from review (#2465)

Browse Source 
* updates from review

* cast

* use U for unsigned int
This commit is contained in:
Victor Vazquez 2021-06-21 11:34:59 -07:00 committed by GitHub
parent a11e69a18c
commit 2ea2cf8b57
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sdk/core/perf/src/random_stream.cpp
View File

@ -20,7 +20,7 @@ namespace {
static uint8_t RandomChar()
{
const uint8_t charset[] = "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ";
static const uint8_t charset[] = "0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ";
std::uniform_int_distribution<size_t> distribution(0, sizeof(charset) - 2);
return charset[distribution(random_generator)];
}
@ -48,13 +48,15 @@ void RandomBuffer(uint8_t* buffer, size_t length)
}
}
static constexpr size_t DefaultRandomStreamBufferSize = 1024 * 1024;
} // namespace
Azure::Perf::RandomStream::CircularStream::CircularStream(size_t size)
: m_buffer(std::make_unique<std::vector<uint8_t>>(1024 * 1024)), m_length(size),
m_memoryStream(*m_buffer)
: m_buffer(std::make_unique<std::vector<uint8_t>>(DefaultRandomStreamBufferSize)),
m_length(size), m_memoryStream(*m_buffer)
{
RandomBuffer(m_buffer->data(), 1024 * 1024);
RandomBuffer(m_buffer->data(), DefaultRandomStreamBufferSize);
}
size_t Azure::Perf::RandomStream::CircularStream::OnRead(

2
sdk/core/perf/test/src/random_stream_test.cpp
View File

@ -35,7 +35,7 @@ TEST(circular_stream, basic)
// 4nd read
count = r_stream->Read(buffer, chunk, Azure::Core::Context::ApplicationContext);
EXPECT_EQ(count, 0);
EXPECT_EQ(count, 0U);
// should not change buffer
for (size_t i = 0; i != chunk; i++)
{