github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Ensure random Uuid generation (#2194)

Browse Source 
Posix platforms do not generate secure random bytes with random_device().

On posix platforms use the openSSL random byte generator which generates cryptographically secure random bytes

**NOTE**: Once the assert work is done this abort() will be switched over to assert.
This commit is contained in:
Rick Winter 2021-05-05 14:41:39 -07:00 committed by GitHub
parent b5b547f590
commit 0490d69e02
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
sdk/core/azure-core/inc/azure/core/uuid.hpp
View File

@ -8,12 +8,18 @@
#pragma once
#include "azure/core/platform.hpp"
#include <cstring>
#include <new> // for placement new
#include <random>
#include <string>
#include <utility> // for swap and move
#if defined(AZ_PLATFORM_POSIX)
#include <openssl/rand.h> //for RAND_bytes
#endif
namespace Azure { namespace Core {
/**
* @brief Universally unique identifier.
@ -73,15 +79,25 @@ namespace Azure { namespace Core {
*/
static Uuid CreateUuid()
{
std::random_device rd;
uint8_t uuid[UuidSize] = {};
#if defined(AZ_PLATFORM_WINDOWS)
std::random_device rd;
for (int i = 0; i < UuidSize; i += 4)
{
const uint32_t x = rd();
std::memcpy(uuid + i, &x, 4);
}
#elif defined(AZ_PLATFORM_POSIX)
int ret = RAND_bytes(uuid, UuidSize);
if (ret <= 0)
{
abort();
}
#else
abort();
#endif
// SetVariant to ReservedRFC4122
uuid[8] = (uuid[8] | ReservedRFC4122) & 0x7F;