Commit Graph

8628 Commits

Author SHA1 Message Date
cert-manager-prow[bot]
9043facd2e
Merge pull request #6912 from SgtCoDFish/validation-refactor
Minor validation refactoring
2024-04-19 12:10:25 +00:00
cert-manager-prow[bot]
4535d17770
Merge pull request #6915 from SgtCoDFish/readd-tidy
re-add mistakenly removed make tidy target
2024-04-19 11:49:25 +00:00
cert-manager-prow[bot]
6d6aebb602
Merge pull request #6914 from inteon/dynamic_source_bugfix
BUGFIX: Dynamic source CI test failures
2024-04-19 10:36:44 +00:00
Ashley Davis
8f54e130bd
re-add mistakenly removed make tidy target
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
2024-04-19 11:26:00 +01:00
Tim Ramlot
f5a73a9ead
fix bug in dynamic source
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-19 11:50:39 +02:00
cert-manager-prow[bot]
bc7a23da1f
Merge pull request #6911 from inteon/makefile_bugfix
Makefile bugfix
2024-04-19 09:16:44 +00:00
Tim Ramlot
8ee7ada5fa
running make in a make target causes concurrent download of dependencies yielding broken files and downloads
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-18 14:43:40 +02:00
Ashley Davis
61710e3c55
add explicit test of external issuers
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
2024-04-18 13:14:21 +01:00
Ashley Davis
b8e40825ce
add comments explaining issuerRef validation logic
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
2024-04-18 13:04:46 +01:00
Ashley Davis
0f5689e120
replace custom pointer functions with k8s ptr.To
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
2024-04-18 12:52:01 +01:00
Ashley Davis
288fd1cc2e
organize imports
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
2024-04-18 12:51:46 +01:00
Ashley Davis
8e70778f4f
use existing object in more tests
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
2024-04-18 12:43:08 +01:00
Ashley Davis
01cf2d4155
rename some certificate validation tests and test explicit default group
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
2024-04-18 12:42:29 +01:00
cert-manager-prow[bot]
d466fa2a6d
Merge pull request #6904 from cert-manager/dependabot/github_actions/all-421975538a
Bump the all group with 3 updates
2024-04-16 08:36:26 +00:00
dependabot[bot]
487c79e9b3
Bump the all group with 3 updates
Bumps the all group with 3 updates: [ossf/scorecard-action](https://github.com/ossf/scorecard-action), [actions/upload-artifact](https://github.com/actions/upload-artifact) and [github/codeql-action](https://github.com/github/codeql-action).


Updates `ossf/scorecard-action` from 2.0.6 to 2.3.1
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](99c53751e0...0864cf1902)

Updates `actions/upload-artifact` from 3.0.0 to 4.3.1
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](6673cd052c...5d5d22a312)

Updates `github/codeql-action` from 1.0.26 to 3.25.0
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](5f53256358...df5a14dc28)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: all
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: all
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-04-15 16:18:58 +00:00
jetstack-bot
480a45ddb2
Merge pull request #6749 from inteon/use_makefile_modules
Move tools and generate/ verify to Makefile modules
2024-04-15 18:18:21 +02:00
Tim Ramlot
01b298a580
move to Makefile modules
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-10 18:53:40 +02:00
jetstack-bot
d073db1648
Merge pull request #6875 from SgtCoDFish/dodo
Limit DigitalOcean records for cleanup to TXT only
2024-04-10 15:31:22 +02:00
jetstack-bot
27c201f285
Merge pull request #6888 from ThatsMrTalbot/chore/add-thatsmrtalbot-as-approver
Add @ThatsMrTalbot as approver
2024-04-10 11:42:21 +02:00
Adam Talbot
4c0536c1c3 chore: add @ThatsMrTalbot as approver
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
2024-04-08 15:07:28 +01:00
jetstack-bot
b61de55abd
Merge pull request #6865 from wallrj/5803-cert-manager-user-agent-venafi-issuer
Add user-agent header in requests to Venafi API
2024-03-27 15:33:00 +01:00
Ashley Davis
d17c9cc513
limit DigitalOcean records for cleanup to TXT only
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
2024-03-26 10:27:54 +00:00
jetstack-bot
6b723ce63b
Merge pull request #6871 from inteon/bugfix_exitcodes
BUGFIX: exit with correct exit codes
2024-03-25 12:31:39 +01:00
jetstack-bot
0e5001da6d
Merge pull request #6870 from deterclosed/master
chore: remove repetitive words
2024-03-23 14:26:50 +01:00
Tim Ramlot
bfd7a51618
BUGFIX: exit with correct exit codes
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-03-23 14:21:33 +01:00
deterclosed
e50052aded chore: remove repetitive words
Signed-off-by: deterclosed <fliter@outlook.com>
2024-03-23 13:37:59 +08:00
jetstack-bot
99fc8fb5f8
Merge pull request #6723 from inteon/add_generate_csr_test
Add new testcase that generates a non-critical SAN extension to the GenerateCSR tests
2024-03-22 21:51:34 +01:00
jetstack-bot
953d8b5478
Merge pull request #6277 from inteon/controller_configfile_fuzzer
ControllerConfiguration fuzzer, only set the value in case the random value is empty
2024-03-22 17:12:34 +01:00
Richard Wall
30db9e2ad5 Link to upstream vcert issues that would allow us to simplify the cert-manager code
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-03-20 14:16:38 +00:00
Richard Wall
dd0762e71b Refactor the httpClientForVcert function so that it can also be used for Venafi Cloud
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-03-20 13:19:56 +00:00
Richard Wall
95a347cbc2 Supply tests with a non-nil REST config in controller.Context
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-03-20 12:21:48 +00:00
Richard Wall
cca333d1db Supply User-Agent string to the Venafi controllers
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-03-20 11:35:10 +00:00
Richard Wall
04ee7fe0e9 Set the User-Agent header in all Venafi API requests
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-03-20 11:02:18 +00:00
Richard Wall
112c7b2e9e An http.RoundTripper which adds the HTTP User-Agent header to all requests
This code existed in cert-manager once before and I'm reviving it.
Here's the history:

 * Added:
 https://github.com/cert-manager/cert-manager/pull/422
 * Moved: https://github.com/cert-manager/cert-manager/pull/432
 * Obsoleted: https://github.com/cert-manager/cert-manager/pull/797
 * Deleted: https://github.com/cert-manager/cert-manager/pull/966

Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-03-20 10:24:47 +00:00
jetstack-bot
f56fc1ed1a
Merge pull request #6792 from inteon/bugfix_literalsubject
bugfix: LiteralSubject match function reports incorrect mismatch
2024-03-15 10:54:01 +01:00
jetstack-bot
c2cecf8ead
Merge pull request #6854 from wallrj/bump-go-jose-CVE-2024-28180
Bump github.com/go-jose/go-jose to v3.0.3 to fix CVE-2024-28180
2024-03-14 16:58:22 +01:00
Richard Wall
6e784bb6f4 make update-licenses
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-03-14 14:51:38 +00:00
Richard Wall
4314c3ae78 Bump github.com/go-jose/go-jose to v3.0.3 to fix CVE-2024-28180
find . -name go.mod -execdir go get github.com/go-jose/go-jose/v3@v3.0.3 \;
make tidy

Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-03-14 14:23:41 +00:00
jetstack-bot
5213a53593
Merge pull request #6839 from mangeshhambarde/ingress-annotations-for-secret-template
Add secretTemplate to Certificate resources created by ingress-shim
2024-03-14 12:49:22 +01:00
Mangesh Hambarde
f3bfc93bba JSON encoded secretTemplate as Ingress annotation
Signed-off-by: Mangesh Hambarde <1411192+mangeshhambarde@users.noreply.github.com>
2024-03-13 14:37:28 +00:00
Mangesh Hambarde
717269e809 Add tests
Signed-off-by: Mangesh Hambarde <1411192+mangeshhambarde@users.noreply.github.com>
2024-03-13 14:18:21 +00:00
Mangesh Hambarde
efe2e06288 New Ingress annotation for copying custom annotations to secret template
Signed-off-by: Mangesh Hambarde <1411192+mangeshhambarde@users.noreply.github.com>
2024-03-13 14:18:21 +00:00
jetstack-bot
3a26313c51
Merge pull request #6784 from inteon/fix_dynamic_source
Refactor the webhook dynamic source and add unit tests
2024-03-12 13:50:25 +01:00
Tim Ramlot
9dcb422164
use errors.Is()
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-03-11 19:33:01 +01:00
Tim Ramlot
f4ae942b8e
add test that validates leaderelection behavior
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-03-11 19:22:38 +01:00
Tim Ramlot
b32382fead
improve the dynamic source implementation and add a lot of unit tests
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-03-11 15:10:39 +01:00
jetstack-bot
b9bbbf5a83
Merge pull request #6771 from inteon/fix_loggers_and_contexts
Initialize logger and create root context in main.go
2024-03-11 14:07:45 +01:00
Tim Ramlot
23373e4323
correctly initialize loggers, create contexts and pass contexts
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-03-08 14:32:31 +01:00
jetstack-bot
fe39c52aaf
Merge pull request #6807 from bwaldrep/bw/alias
feat: Add optional flag to specify jks keystore alias
2024-03-07 18:27:06 +01:00
jetstack-bot
b2d7284881
Merge pull request #6840 from inteon/bump_base_images
Run ./hack/latest-base-images.sh
2024-03-07 17:55:06 +01:00