weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

rename some certificate validation tests and test explicit default group

Browse Source 
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
This commit is contained in:
Ashley Davis 2024-04-18 12:42:29 +01:00
parent d466fa2a6d
commit 01cf2d4155
No known key found for this signature in database
1 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
internal/apis/certmanager/validation/certificate_test.go
View File

@ -77,7 +77,7 @@ func TestValidateCertificate(t *testing.T) {
},
a: someAdmissionRequest,
},
"valid with blank issuerRef kind": {
"valid with blank issuerRef kind and no group": {
cfg: &internalcmapi.Certificate{
Spec: internalcmapi.CertificateSpec{
CommonName: "testcn",
@ -89,7 +89,7 @@ func TestValidateCertificate(t *testing.T) {
},
a: someAdmissionRequest,
},
"valid with 'Issuer' issuerRef kind": {
"valid with 'Issuer' issuerRef kind and no group": {
cfg: &internalcmapi.Certificate{
Spec: internalcmapi.CertificateSpec{
CommonName: "testcn",
@ -115,6 +115,20 @@ func TestValidateCertificate(t *testing.T) {
},
a: someAdmissionRequest,
},
"valid with 'Issuer' issuerRef kind and explicit internal group": {
cfg: &internalcmapi.Certificate{
Spec: internalcmapi.CertificateSpec{
CommonName: "testcn",
SecretName: "abc",
IssuerRef: cmmeta.ObjectReference{
Name: "valid",
Kind: "Issuer",
Group: "cert-manager.io",
},
},
},
a: someAdmissionRequest,
},
"invalid issuerRef kind": {
cfg: &internalcmapi.Certificate{
Spec: internalcmapi.CertificateSpec{
@ -168,7 +182,7 @@ func TestValidateCertificate(t *testing.T) {
field.Invalid(fldPath, "", "at least one of commonName (from the commonName field or from a literalSubject), dnsNames, uriSANs, ipAddresses, emailSANs or otherNames must be set"),
},
},
"certificate with no issuerRef": {
"invalid with no issuerRef": {
cfg: &internalcmapi.Certificate{
Spec: internalcmapi.CertificateSpec{
CommonName: "testcn",