weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

add explicit test of external issuers

Browse Source 
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
This commit is contained in:
Ashley Davis 2024-04-18 13:14:21 +01:00
parent b8e40825ce
commit 61710e3c55
No known key found for this signature in database
1 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
internal/apis/certmanager/validation/certificate_test.go
View File

@ -122,22 +122,36 @@ func TestValidateCertificate(t *testing.T) {
},
a: someAdmissionRequest,
},
"invalid issuerRef kind": {
"invalid with external issuerRef kind and empty group": {
cfg: &internalcmapi.Certificate{
Spec: internalcmapi.CertificateSpec{
CommonName: "testcn",
SecretName: "abc",
IssuerRef: cmmeta.ObjectReference{
Name: "valid",
Kind: "invalid",
Name: "abc",
Kind: "AWSPCAClusterIssuer",
},
},
},
a: someAdmissionRequest,
errs: []*field.Error{
field.Invalid(fldPath.Child("issuerRef", "kind"), "invalid", "must be one of Issuer or ClusterIssuer"),
field.Invalid(fldPath.Child("issuerRef", "kind"), "AWSPCAClusterIssuer", "must be one of Issuer or ClusterIssuer"),
},
},
"valid with external issuerRef kind and external group": {
cfg: &internalcmapi.Certificate{
Spec: internalcmapi.CertificateSpec{
CommonName: "testcn",
SecretName: "abc",
IssuerRef: cmmeta.ObjectReference{
Name: "abc",
Kind: "AWSPCAClusterIssuer",
Group: "awspca.cert-manager.io",
},
},
},
a: someAdmissionRequest,
},
"certificate missing secretName": {
cfg: &internalcmapi.Certificate{
Spec: internalcmapi.CertificateSpec{