Fixes https://github.com/Azure/azure-sdk-for-cpp/issues/2334
# Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the [contributing guide](https://github.com/Azure/azure-sdk-for-cpp/blob/master/CONTRIBUTING.md#pull-requests).
- [x] [C++ Guidelines](https://azure.github.io/azure-sdk/cpp_introduction.html)
- [x] Doxygen docs
- [x] Unit tests
- [x] No unwanted commits/changes
- [x] Descriptive title/description
- [x] PR is single purpose
- [x] Related issue listed
- [x] Comments in source
- [x] No typos
- [x] Update changelog
- [x] Not work-in-progress
- [x] External references or docs updated
- [x] Self review of PR done
- [x] Any breaking changes?
* Increment package version after release of azure-storage-common
* Increment package version after release of azure-storage-blobs
* Increment package version after release of azure-storage-files-datalake
* Increment package version after release of azure-storage-files-shares
* Add argument validation to public APIs.
* Add exception to spell check.
* Revert "Add exception to spell check."
This reverts commit be54b614cc1427ddb2f154f5927f4e612a4a1e28.
* Turn invalid arg excetion to a precondition assert for bodystream read.
* User assert in more places within body_stream.
* Update valiation for hashing and bodystream and update tests.
* Update precondition test for size_t and add null ptr check
* Fix clang formatting.
* Update changelog and fix up the message for size_t validation in hash.
* Address PR feedback.
* More PR feedback.
* Remove unnecessary comment from test.
* Fix clang format.
* Use size_t for buffers representing data in memory rather than int64_t.
* add a cast from size_t to int64_t
* Address feedback - OnRead return size_t.
* Change Read and ReadToCount to return size_t instead of int64_t.
* Update curl usage and ReadFromSocket.
* Missed one signature.
* Update changelog.
* Update transport layer to use the right size_t size.
* Fix curl use of MBS.
* Cast to size_t since that's all memory stream supprts.
* Add static casts to size_t as temporary workarounds.
* update storage tests.
* More test fixes.
* copy constructor for RequestFailedException
* Apply suggestions from code review
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
Co-authored-by: Rick Winter <rick.winter@microsoft.com>
* Avoid using WinHttpQueryDataAvailable, and use WinHttpReadData directly for better throughput.
* Add back new line at end of file.
* Reorder some lines for readability.
Part of https://github.com/Azure/azure-sdk-for-cpp/issues/1277, checking what types of warnings the CI emits.
Verified all SDK product `.cpp`, `.hpp`, `.txt`, and `.md` files, primarily focused on azure-core. They are all clean now. There are some exceptions that needs to be added for keyvault and storage, but they are false positives, so not a concern.
> `cspell lint --config .vscode/cspell.json *.hpp */**/*.hpp`
CSpell: Files checked: 188, Issues found: 0 in 0 files
> `cspell lint --config .vscode/cspell.json *.cpp */**/*.cpp`
CSpell: Files checked: 186, Issues found: 88 in 15 files (keyvault and storage false positives, or tests)
> `cspell lint --config .vscode/cspell.json *.md */**/*.md`
CSpell: Files checked: 45, Issues found: 5 in 2 files (eng/common)
> `cspell lint --config .vscode/cspell.json *.txt */**/*.txt`
CSpell: Files checked: 44, Issues found: 0 in 0 files
> `cspell lint --config .vscode/cspell.json *.* */**/*`
CSpell: Files checked: 646, Issues found: 328 in 69 files (most of these are in eng\docs\api\assets\style.css or eng/common)
Deprioritize and ignored the errors from the test files (including test resource json files), and `eng/common` since those need to be centrally fixed.
* Removed the `Azure::Core::Http::Request` ctor overload that takes both a `bodyStream` and a `bufferedDownload` boolean since it is not used anywhere.
* Add back the unit tests by making them friends.
* Add back line at end of file.
