github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Incorrect use of hashing Final/Append APIs now have an assert failure. (#2317)

Browse Source 
Follow up from https://github.com/Azure/azure-sdk-for-cpp/pull/2189
This commit is contained in:
Ahson Khan 2021-05-18 21:18:16 -07:00 committed by GitHub
parent 75d17550f2
commit 2a4dfd2f0d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
sdk/storage/azure-storage-common/test/crypt_functions_test.cpp
View File

@ -127,14 +127,22 @@ namespace Azure { namespace Storage { namespace Test {
const uint8_t* ptr = reinterpret_cast<const uint8_t*>(data.data());
Crc64Hash instance;
EXPECT_THROW(instance.Final(nullptr, 1), std::invalid_argument);
EXPECT_THROW(instance.Append(nullptr, 1), std::invalid_argument);
ASSERT_DEATH(instance.Final(nullptr, 1), "");
ASSERT_DEATH(instance.Append(nullptr, 1), "");
EXPECT_EQ(
Azure::Core::Convert::Base64Encode(instance.Final(ptr, data.length())), "AAAAAAAAAAA=");
EXPECT_THROW(instance.Final(), std::runtime_error);
EXPECT_THROW(instance.Final(ptr, data.length()), std::runtime_error);
EXPECT_THROW(instance.Append(ptr, data.length()), std::runtime_error);
#if defined(NDEBUG)
// Release build won't provide assert msg
ASSERT_DEATH(instance.Final(), "");
ASSERT_DEATH(instance.Final(ptr, data.length()), "");
ASSERT_DEATH(instance.Append(ptr, data.length()), "");
#else
ASSERT_DEATH(instance.Final(), "Cannot call Final");
ASSERT_DEATH(instance.Final(ptr, data.length()), "Cannot call Final");
ASSERT_DEATH(instance.Append(ptr, data.length()), "Cannot call Append after calling Final");
#endif
}
TEST(CryptFunctionsTest, Crc64Hash_CtorDtor)