Commit Graph

136 Commits

Author SHA1 Message Date
Ahson Khan
90bdfd8408
Other than options and model types (which are property bags), make everything that has functions, a class. (#2631)
* Other than options and model types (which are property bags), make
everything that has functions, a class.

* Fix clang formatting.
2021-07-15 11:25:30 -07:00
Victor Vazquez
76fd63b2b3
rename types (#2594)
* rename header

* format

* update name

* changelog

* format

* name updates
2021-07-15 10:36:21 -07:00
Ahson Khan
e69f6e182a
Use forward declaration to avoid exposing private/src headers from public headers. (#2626)
* Remove InitRequest helper method

* Rename KeyVaultPipeline to KeyVaultProtocolClient along with headers.

* Move the KeyVaultProtocolClient into private imlpementation detail of
Keys.

* Update doc comments.

* Stop building keyvault common for now since it contains no sources.

* Don't generate keyvault common docs since there are no files.

* Stop building azure-security-keyvault-common as part of CI.

* Use forward declaration to avoid exposing private/src headers from
public headers.

* Simplify after the merge from main.
2021-07-14 20:21:42 -07:00
Ahson Khan
c4af969569
Remove vcpkg dependency from keyvault-keys on keyvault-common. (#2630) 2021-07-14 16:55:18 -07:00
Ahson Khan
61f11aa39a
Update keyvault keys readme to use C++ specific links (#2628)
Fixes https://github.com/Azure/azure-sdk-for-cpp/issues/2598
2021-07-14 23:39:50 +00:00
Ahson Khan
427e892582
Removed the /internal/ directory in Keyvault Keys and move headers to private that don't need to be public. (#2625)
* Removed the /internal/ directory in Keyvault Keys and move headers to
private that don't need to be public.

* Clang format.

* Move CryptographyProvider and RCC into private headers as well.

* Fix clang formatting.
2021-07-14 15:26:23 -07:00
Ahson Khan
c4ff48e8a5
Rename KeyVaultPipeline to KeyVaultProtocolClient and make it an impl detail (move it to _detail) within the keys package instead of common (#2618)
* Remove InitRequest helper method

* Rename KeyVaultPipeline to KeyVaultProtocolClient along with headers.

* Move the KeyVaultProtocolClient into private imlpementation detail of
Keys.

* Update doc comments.

* Stop building keyvault common for now since it contains no sources.

* Don't generate keyvault common docs since there are no files.

* Stop building azure-security-keyvault-common as part of CI.
2021-07-14 12:42:13 -07:00
Ahson Khan
a10b507e42
Adding BackupKeyResult struct wrapper as a return type model for BackupKey. (#2619)
* Adding BackupKeyResult struct wrapper as a return type model for
BackupKey.

* Update sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/backup_key_result.hpp

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2021-07-14 12:22:15 -07:00
Ahson Khan
05ebec8b50
Removed the MaxPageResults field from GetPropertiesOfKeysOptions, GetPropertiesOfKeyVersionsOptions, and GetDeletedKeysOptions. (#2620)
* Remove the MaxPageResults options on KeyVault GetPropertiesOfKeys and other APIs.

* Update CL
2021-07-14 12:12:40 -07:00
Ahson Khan
c8cefb044a
Fix up doc typos in the PagedResponse KeyVault APIs. (#2621) 2021-07-14 12:07:05 -07:00
Ahson Khan
404fd94710
Remove unused internal helper method from KeyVaultPipeline. (#2623) 2021-07-14 12:00:10 -07:00
Victor Vazquez
5ddebe53bf
Rename list_keys_result KeyVault header to list_keys_responses to match PagedResponse naming pattern (#2592)
* rename header

* format
2021-07-13 20:12:35 -07:00
Ahson Khan
92aef8a8c6
Add missing key vault keys cryptography headers to the simplified header. (#2597)
* Add missing key vault keys cryptography headers to the simplified header.

* Fix sort order according to clang format, which seems to differ from Windows dir file system command.
2021-07-12 14:31:13 -07:00
Ahson Khan
07861a9687
Avoid inheriting from an internal base class for KeyVault PagedResponse Options and expose fields directly (#2590)
* Avoid inheriting from an internal base class for KeyVault PagedResponse Options and expose fields directly

* fix for compilation

Co-authored-by: Victor Vazquez <vhvb1989@gmail.com>
2021-07-09 15:36:16 -07:00
Victor Vazquez
480f867cec
keyvault changelog and version update (#2575) 2021-07-08 16:46:38 -07:00
Victor Vazquez
eabfb523d9
Update header names (#2580)
* Update header names

* cl
2021-07-08 16:39:25 -07:00
Victor Vazquez
33d4b72a4d
remove encrypt decrypt overload (#2574)
* remove encrypt decrypt overload

* cl

* format
2021-07-07 21:01:52 -07:00
George Arama
ecbf8d0784
add some more uts for create (#2510)
* add some more uts for create

* format

* remove unused include

* Update sdk/keyvault/azure-security-keyvault-keys/test/ut/mocked_transport_adapter_test.hpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* put back include, it doesn't work otherwise

* format

* Revert "format"

This reverts commit afefd264868ededefe8ad715dd1674a333fd1176.

* Revert "put back include, it doesn't work otherwise"

This reverts commit 54f05fe8d2b63f089e76931c5592b64e80f98b5e.

* Revert "Update sdk/keyvault/azure-security-keyvault-keys/test/ut/mocked_transport_adapter_test.hpp"

This reverts commit 8ce4f0b3a2e893be69afdfc710c060fe76c5493a.

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2021-07-07 21:00:11 -07:00
Victor Vazquez
9b06fc8f33
compile samples (#2556)
* compile samples
2021-07-07 06:50:05 -07:00
Ahson Khan
d0ca42643f
Move Sha256Hash and other Hash algorithm types from KeyVault to Azure::Core (#2526)
* Move the SHA256, 384, and 512 Hash implementations to be internal.

* Update changelog and add back missing file.

* Rename SHA256 and others to Sha256Hash and update header name.

* Fix up path in CMakeList by removing quotes.

* Rename the sha.cpp source file to match header.

* Move Sha256Hash and other Hash algorithm types from KeyVault to
Azure::Core.

* Reorder src file in cmakelist to be alpha order just to reset CI

* Revert "Reorder src file in cmakelist to be alpha order just to reset CI"

This reverts commit 6729cf311af76bb8388738cc519ea40092bc362c.
2021-07-01 15:42:36 -07:00
Ahson Khan
a6f3b530d5
Move Base64Url helper internal methods from KeyVault to Azure Core. (#2528)
* Move Base64Url helper internal methods from KeyVault to Azure Core.

* Run clang format.
2021-07-01 12:24:38 -07:00
Ahson Khan
773beffd64
Rename SHA256 and others to Sha256Hash and update header name. (#2525)
First review https://github.com/Azure/azure-sdk-for-cpp/pull/2523

Relevant commit to review: f207fe80b9

Second step of of https://github.com/Azure/azure-sdk-for-cpp/issues/2500#issuecomment-871761727
2021-07-01 18:55:58 +00:00
Victor Vazquez
5b5cb9b5f7
ApiView requested changes (#2493)
* ApiView requested changes

* update test

* Apply suggestions from code review

Co-authored-by: Ahson Khan <ahkha@microsoft.com>

* update private field name

Co-authored-by: Ahson Khan <ahkha@microsoft.com>
2021-07-01 18:45:43 +00:00
George Arama
c449e3f9bc
2502 exceptions (#2529)
* first pass

* move exception creation from keyvault to core

* merge fix

* format

* fix includes location and containers

* remove default constructor

* to trigger build

* undo change

* uncomment

* Update sdk/core/azure-core/test/ut/exception_test.cpp

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2021-07-01 04:17:15 +00:00
Ahson Khan
e51e693640
Move the SHA256, 384, and 512 Hash implementations to be internal. (#2523)
* Move the SHA256, 384, and 512 Hash implementations to be internal.

* Update changelog and add back missing file.

* Update samples to not use the SHA256 API since it is internal now.
2021-06-30 18:14:11 -07:00
Anton Kolesnyk
8f1b5b95e3
Move POSIX time converter from KeyVault to Core (#2524)
* Move POSIX time converter from KeyVault to Core

* Move to Core namespace

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-06-30 17:23:20 -07:00
Anton Kolesnyk
f6765e667e
Put dependency versions (#2518)
* Put dependency versions

* Update version

* Core does not have any 1.1 functionality

* Core 1.1

* 1.1.0

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-06-30 17:05:16 -07:00
George Arama
e105bcdca3
Keyvault unit tests for non standard key sizes. (#2495)
* param tests

* ooops

* remove get suffix

* uneeded define

* remove define

* update initi location to prevent multiple  runs

* formatting

* added negative numbers and some above 2048
2021-06-29 01:10:24 -07:00
Wes Haggard
015c34a029
Update links from master to main (#2488)
* Update links from master to main

* Upate other references from master to main
2021-06-24 22:27:14 -07:00
Victor Vazquez
f052feffa1
update telemetry key for keyvault keys (#2472) 2021-06-23 16:17:25 -07:00
Victor Vazquez
a11e69a18c
Key Vault Keys crypto samples (#2450)
* encrypt_decrypt

* sign verify

* wrap and unwrap

* Apply suggestions from code review

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2021-06-21 18:34:41 +00:00
Daniel Jurek
fda88bf7b8
Update for "master" -> "main" branch rename (#2455)
* vcpkg.json -- update all links to point to "main" .. This is hardcoded and will go out in future releases.
* ci.yml -- add `- main` to trigger criteria near `- master` ... This adds forward compatilbitiy when we rename the branch in the repo
* archetype-cpp-release.yml use a script which evaluates a repo's default branch and sets that in a global variable, then use that variable instead. When vcpkg updates their branch the publishing scripts will work transparently.
* Collect-Changelogs.ps1 -- Add default hardcoded branch name for use with future releases. This can be optionally overridden with a parameter when invoking the script.
* eng/pipelines/client.yml -- Delete this file. It is no longer in use.
2021-06-18 09:09:27 -07:00
Mitch Denny
01ba0b0c9c
Add main to CI files. (#2462) 2021-06-19 01:55:34 +10:00
Ahson Khan
479134595b
Consolidate the use of std::size_t and always use size_t instead, since it is a "primitive" type. (#2415)
* Consolidate the use of std::size_t and always use size_t instead, since
it is a type.

* Fix clang formatting.
2021-06-09 11:09:54 -07:00
Azure SDK Bot
5a477ad533
Increment version for keyvault releases (#2437)
* Increment package version after release of azure-security-keyvault-common

* Increment package version after release of azure-security-keyvault-keys
2021-06-09 00:40:14 -07:00
Victor Vazquez
30bf45788e
update changelog (#2436) 2021-06-09 00:08:35 -07:00
Victor Vazquez
cd6fd9d92d
missing change for common (#2432) 2021-06-08 18:06:40 -07:00
Victor Vazquez
d82f28616a
update changelog (#2424) 2021-06-08 13:25:39 -07:00
Ahson Khan
1d39b9c761
Fix keyvault changelog nit (#2430)
Followup from https://github.com/Azure/azure-sdk-for-cpp/pull/2399#discussion_r646846373
2021-06-08 19:27:48 +00:00
Victor Vazquez
17b91ffe59
update uint32_t to int32_t (#2399) 2021-06-07 19:36:14 +00:00
Victor Vazquez
ecdadddc23
Update keyvault internal private header location (#2405)
* Move keyvault common headers to the right directory
2021-06-07 10:20:19 -07:00
Victor Vazquez
8f8c4e55ce
update uint64 to int64_t (#2398) 2021-06-03 21:47:37 -07:00
Anton Kolesnyk
cdcdac5c58
Docs: link to root Getting Started section from Key Vault Keys' readme (#2387)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-06-03 10:59:16 -07:00
Victor Vazquez
141878670f
update variable to compile (#2373) 2021-06-01 10:03:51 -07:00
Anton Kolesnyk
15c525d387
Fix empty rethrows, update some catches to catch all (#2362)
* Fix empty rethrows, update some catches to catch all

* AZURE_UNREACHABLE_CODE()

Co-authored-by: JinmingHu <jinmhu@microsoft.com>

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: JinmingHu <jinmhu@microsoft.com>
2021-05-28 09:24:42 -07:00
Anton Kolesnyk
78703658a2
Fix throw new (#2360)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-05-28 01:52:39 -07:00
Victor Vazquez
9e7fa34c34
Keyvault readme update (#2350)
* progress

* update keyvault keys readme

* Apply suggestions from code review

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2021-05-28 06:52:52 +00:00
Victor Vazquez
88dc1ac8cf
adding Test file sufix to all tests (#2337)
* azure core

* perf

* identity

* keyvault

* storage
2021-05-25 11:15:30 -07:00
Azure SDK Bot
069f753464
Increment version for keyvault releases (#2324)
* Increment package version after release of azure-security-keyvault-common

* Increment package version after release of azure-security-keyvault-keys
2021-05-21 13:37:48 -07:00
Ahson Khan
0a0bd6fbc2
Update changelog for the upcoming beta release. (#2309)
Holding off to do a review of the commits.

Area owners, please review yourself as well, and fix what might be missing or needs updating.
2021-05-19 04:31:36 +00:00