github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Removed the MaxPageResults field from GetPropertiesOfKeysOptions, GetPropertiesOfKeyVersionsOptions, and GetDeletedKeysOptions. (#2620)

Browse Source 
* Remove the MaxPageResults options on KeyVault GetPropertiesOfKeys and other APIs.

* Update CL
This commit is contained in:
Ahson Khan 2021-07-14 12:12:40 -07:00 committed by GitHub
parent c8cefb044a
commit 05ebec8b50
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sdk/keyvault/azure-security-keyvault-keys/CHANGELOG.md
View File

@ -15,6 +15,7 @@
- Removed access to `Iv` field member from `EncryptParameters` and `DecryptParameters`.
- Removed `Encrypt(EncryptionAlgorithm, std::vector, context)`.
- Removed `Decrypt(DecryptAlgorithm, std::vector, context)`.
- Removed the `MaxPageResults` field from `GetPropertiesOfKeysOptions`, `GetPropertiesOfKeyVersionsOptions`, and `GetDeletedKeysOptions`.
- Renamed header `list_keys_single_page_result.hpp` to `list_keys_responses.hpp`.
## 4.0.0-beta.3 (2021-06-08)

3
sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/list_keys_responses.hpp
View File

@ -125,7 +125,6 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys {
struct GetPropertiesOfKeysOptions final
{
Azure::Nullable<std::string> NextPageToken;
Azure::Nullable<int32_t> MaxPageResults;
};
/**
@ -135,7 +134,6 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys {
struct GetPropertiesOfKeyVersionsOptions final
{
Azure::Nullable<std::string> NextPageToken;
Azure::Nullable<int32_t> MaxPageResults;
};
/**
@ -145,6 +143,5 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys {
struct GetDeletedKeysOptions final
{
Azure::Nullable<std::string> NextPageToken;
Azure::Nullable<int32_t> MaxPageResults;
};
}}}} // namespace Azure::Security::KeyVault::Keys

24
sdk/keyvault/azure-security-keyvault-keys/src/key_client.cpp
View File

@ -45,14 +45,6 @@ static inline RequestWithContinuationToken BuildRequestFromContinuationToken(
request.Path.clear();
request.Path.emplace_back(nextPageUrl.GetPath());
}
if (options.MaxPageResults)
{
if (request.Query == nullptr)
{
request.Query = std::make_unique<std::map<std::string, std::string>>();
}
request.Query->emplace("maxResults", std::to_string(options.MaxPageResults.Value()));
}
return request;
}
@ -72,14 +64,6 @@ static inline RequestWithContinuationToken BuildRequestFromContinuationToken(
request.Path.clear();
request.Path.emplace_back(nextPageUrl.GetPath());
}
if (options.MaxPageResults)
{
if (request.Query == nullptr)
{
request.Query = std::make_unique<std::map<std::string, std::string>>();
}
request.Query->emplace("maxResults", std::to_string(options.MaxPageResults.Value()));
}
return request;
}
@ -99,14 +83,6 @@ static inline RequestWithContinuationToken BuildRequestFromContinuationToken(
request.Path.clear();
request.Path.emplace_back(nextPageUrl.GetPath());
}
if (options.MaxPageResults)
{
if (request.Query == nullptr)
{
request.Query = std::make_unique<std::map<std::string, std::string>>();
}
request.Query->emplace("maxResults", std::to_string(options.MaxPageResults.Value()));
}
return request;
}
} // namespace