Update keyvault internal private header location (#2405)

* Move keyvault common headers to the right directory

sdk/keyvault/azure-security-keyvault-common/CMakeLists.txt

@@ -32,13 +32,13 @@ set(
     inc/azure/keyvault/common/internal/keyvault_pipeline.hpp
     inc/azure/keyvault/common/internal/single_page.hpp
     inc/azure/keyvault/common/internal/unix_time_helper.hpp
-    inc/azure/keyvault/common/keyvault_constants.hpp
-    inc/azure/keyvault/common/keyvault_exception.hpp
+    inc/azure/keyvault/common/internal/keyvault_exception.hpp
     inc/azure/keyvault/common/sha.hpp
 )
 
 set(
   AZURE_KEYVAULT_COMMON_SOURCE
+    src/private/keyvault_constants.hpp
     src/private/package_version.hpp
     src/keyvault_exception.cpp
     src/keyvault_pipeline.cpp

sdk/keyvault/azure-security-keyvault-common/inc/azure/keyvault/common/internal/keyvault_exception.hpp

@@ -15,7 +15,7 @@
 #include <stdexcept>
 #include <string>
 
-namespace Azure { namespace Security { namespace KeyVault { namespace _detail {
+namespace Azure { namespace Security { namespace KeyVault { namespace _internal {
   /**
    * @brief Container for static methods to parse Key Vault payloads to Azure Core Exception.
    *
@@ -31,4 +31,4 @@ namespace Azure { namespace Security { namespace KeyVault { namespace _detail {
     static Azure::Core::RequestFailedException CreateException(
         std::unique_ptr<Azure::Core::Http::RawResponse> rawResponse);
   };
-}}}} // namespace Azure::Security::KeyVault::_detail
+}}}} // namespace Azure::Security::KeyVault::_internal

sdk/keyvault/azure-security-keyvault-common/src/keyvault_exception.cpp

@@ -1,8 +1,8 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-#include "azure/keyvault/common/keyvault_exception.hpp"
-#include "azure/keyvault/common/keyvault_constants.hpp"
+#include "azure/keyvault/common/internal/keyvault_exception.hpp"
+#include "private/keyvault_constants.hpp"
 
 #include <azure/core/http/policies/policy.hpp>
 
@@ -12,7 +12,7 @@
 using namespace Azure::Security::KeyVault;
 using namespace Azure::Core::Http::_internal;
 
-Azure::Core::RequestFailedException _detail::KeyVaultException::CreateException(
+Azure::Core::RequestFailedException _internal::KeyVaultException::CreateException(
     std::unique_ptr<Azure::Core::Http::RawResponse> rawResponse)
 {
   std::vector<uint8_t> bodyBuffer = std::move(rawResponse->GetBody());

sdk/keyvault/azure-security-keyvault-common/src/keyvault_pipeline.cpp

@@ -3,9 +3,9 @@
 
 #include <azure/core/http/http.hpp>
 
+#include "azure/keyvault/common/internal/keyvault_exception.hpp"
 #include "azure/keyvault/common/internal/keyvault_pipeline.hpp"
-#include "azure/keyvault/common/keyvault_constants.hpp"
-#include "azure/keyvault/common/keyvault_exception.hpp"
+#include "private/keyvault_constants.hpp"
 
 using namespace Azure::Security::KeyVault;
 using namespace Azure::Core::Http::_internal;
@@ -70,7 +70,7 @@ std::unique_ptr<Azure::Core::Http::RawResponse> _internal::KeyVaultPipeline::Sen
     case Azure::Core::Http::HttpStatusCode::NoContent:
       break;
     default:
-      throw Azure::Security::KeyVault::_detail::KeyVaultException::CreateException(
+      throw Azure::Security::KeyVault::_internal::KeyVaultException::CreateException(
           std::move(response));
   }
   return response;

sdk/keyvault/azure-security-keyvault-keys/CMakeLists.txt

@@ -30,31 +30,24 @@ set(
   AZURE_KEYVAULT_KEYS_HEADER
     inc/azure/keyvault/keys/cryptography/cryptography_client_options.hpp
     inc/azure/keyvault/keys/cryptography/cryptography_client.hpp
-    inc/azure/keyvault/keys/cryptography/cryptography_provider.hpp
-    inc/azure/keyvault/keys/cryptography/cryptography_serializers.hpp
     inc/azure/keyvault/keys/cryptography/decrypt_parameters.hpp
     inc/azure/keyvault/keys/cryptography/decrypt_result.hpp
     inc/azure/keyvault/keys/cryptography/encrypt_parameters.hpp
     inc/azure/keyvault/keys/cryptography/encrypt_result.hpp
     inc/azure/keyvault/keys/cryptography/encryption_algorithm.hpp
-    inc/azure/keyvault/keys/cryptography/key_sign_parameters.hpp
-    inc/azure/keyvault/keys/cryptography/key_verify_parameters.hpp
     inc/azure/keyvault/keys/cryptography/key_wrap_algorithm.hpp
-    inc/azure/keyvault/keys/cryptography/key_wrap_parameters.hpp
-    inc/azure/keyvault/keys/cryptography/local_cryptography_provider_factory.hpp
-    inc/azure/keyvault/keys/cryptography/local_cryptography_provider.hpp
-    inc/azure/keyvault/keys/cryptography/remote_cryptography_client.hpp
-    inc/azure/keyvault/keys/cryptography/rsa_cryptography_provider.hpp
     inc/azure/keyvault/keys/cryptography/sign_result.hpp
     inc/azure/keyvault/keys/cryptography/signature_algorithm.hpp
     inc/azure/keyvault/keys/cryptography/wrap_result.hpp
     inc/azure/keyvault/keys/cryptography/unwrap_result.hpp
     inc/azure/keyvault/keys/cryptography/verify_result.hpp
+    inc/azure/keyvault/keys/internal/cryptography/cryptography_provider.hpp
+    inc/azure/keyvault/keys/internal/cryptography/local_cryptography_provider_factory.hpp
+    inc/azure/keyvault/keys/internal/cryptography/local_cryptography_provider.hpp
+    inc/azure/keyvault/keys/internal/cryptography/remote_cryptography_client.hpp
+    inc/azure/keyvault/keys/internal/cryptography/rsa_cryptography_provider.hpp
     inc/azure/keyvault/keys/delete_key_operation.hpp
     inc/azure/keyvault/keys/deleted_key.hpp
-    inc/azure/keyvault/keys/details/key_backup.hpp
-    inc/azure/keyvault/keys/details/key_constants.hpp
-    inc/azure/keyvault/keys/details/key_request_parameters.hpp
     inc/azure/keyvault/keys/import_key_options.hpp
     inc/azure/keyvault/keys/json_web_key.hpp
     inc/azure/keyvault/keys/key_client.hpp
@@ -89,6 +82,14 @@ set(
     src/cryptography/wrap_result.cpp
     src/cryptography/unwrap_result.cpp
     src/cryptography/verify_result.cpp
+    src/private/cryptography_serializers.hpp
+    src/private/key_backup.hpp
+    src/private/key_constants.hpp
+    src/private/key_request_parameters.hpp
+    src/private/key_serializers.hpp
+    src/private/key_sign_parameters.hpp
+    src/private/key_verify_parameters.hpp
+    src/private/key_wrap_parameters.hpp
     src/private/package_version.hpp
     src/delete_key_operation.cpp
     src/deleted_key.cpp

sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/cryptography/cryptography_client.hpp

@@ -14,12 +14,12 @@
 #include <azure/core/io/body_stream.hpp>
 
 #include "azure/keyvault/keys/cryptography/cryptography_client_options.hpp"
-#include "azure/keyvault/keys/cryptography/cryptography_provider.hpp"
 #include "azure/keyvault/keys/cryptography/encrypt_parameters.hpp"
 #include "azure/keyvault/keys/cryptography/encrypt_result.hpp"
-#include "azure/keyvault/keys/cryptography/remote_cryptography_client.hpp"
 #include "azure/keyvault/keys/cryptography/sign_result.hpp"
 #include "azure/keyvault/keys/cryptography/wrap_result.hpp"
+#include "azure/keyvault/keys/internal/cryptography/cryptography_provider.hpp"
+#include "azure/keyvault/keys/internal/cryptography/remote_cryptography_client.hpp"
 
 #include <memory>
 #include <string>

sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/internal/cryptography/local_cryptography_provider.hpp

@@ -9,7 +9,7 @@
 
 #pragma once
 
-#include "azure/keyvault/keys/cryptography/cryptography_provider.hpp"
+#include "azure/keyvault/keys/internal/cryptography/cryptography_provider.hpp"
 #include "azure/keyvault/keys/key_vault_key.hpp"
 
 #include <memory>

sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/internal/cryptography/local_cryptography_provider_factory.hpp

@@ -9,8 +9,8 @@
 
 #pragma once
 
-#include "azure/keyvault/keys/cryptography/cryptography_provider.hpp"
-#include "azure/keyvault/keys/cryptography/rsa_cryptography_provider.hpp"
+#include "azure/keyvault/keys/internal/cryptography/cryptography_provider.hpp"
+#include "azure/keyvault/keys/internal/cryptography/rsa_cryptography_provider.hpp"
 #include "azure/keyvault/keys/key_vault_key.hpp"
 
 #include <memory>

sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/internal/cryptography/remote_cryptography_client.hpp

@@ -15,9 +15,9 @@
 #include <azure/keyvault/common/internal/keyvault_pipeline.hpp>
 
 #include "azure/keyvault/keys/cryptography/cryptography_client_options.hpp"
-#include "azure/keyvault/keys/cryptography/cryptography_provider.hpp"
 #include "azure/keyvault/keys/cryptography/encrypt_parameters.hpp"
 #include "azure/keyvault/keys/cryptography/encrypt_result.hpp"
+#include "azure/keyvault/keys/internal/cryptography/cryptography_provider.hpp"
 #include "azure/keyvault/keys/key_vault_key.hpp"
 
 #include <memory>

sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/internal/cryptography/rsa_cryptography_provider.hpp

@@ -9,7 +9,7 @@
 
 #pragma once
 
-#include "azure/keyvault/keys/cryptography/local_cryptography_provider.hpp"
+#include "azure/keyvault/keys/internal/cryptography/local_cryptography_provider.hpp"
 
 #include <memory>
 #include <string>

sdk/keyvault/azure-security-keyvault-keys/src/cryptography/cryptography_client.cpp

@@ -9,7 +9,7 @@
 #include <azure/core/http/policies/policy.hpp>
 
 #include "azure/keyvault/keys/cryptography/cryptography_client.hpp"
-#include "azure/keyvault/keys/cryptography/local_cryptography_provider_factory.hpp"
+#include "azure/keyvault/keys/internal/cryptography/local_cryptography_provider_factory.hpp"
 #include "azure/keyvault/keys/key_operation.hpp"
 
 #include <memory>

sdk/keyvault/azure-security-keyvault-keys/src/cryptography/decrypt_parameters.cpp

@@ -2,8 +2,8 @@
 // SPDX-License-Identifier: MIT
 
 #include "azure/keyvault/keys/cryptography/decrypt_parameters.hpp"
-#include "azure/keyvault/keys/cryptography/cryptography_serializers.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
+#include "../private/cryptography_serializers.hpp"
+#include "../private/key_constants.hpp"
 
 #include <azure/keyvault/common/internal/base64url.hpp>
 

sdk/keyvault/azure-security-keyvault-keys/src/cryptography/decrypt_result.cpp

@@ -3,9 +3,9 @@
 
 #include <azure/core/internal/json/json.hpp>
 
-#include "azure/keyvault/keys/cryptography/cryptography_serializers.hpp"
+#include "../private/cryptography_serializers.hpp"
+#include "../private/key_constants.hpp"
 #include "azure/keyvault/keys/cryptography/decrypt_result.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
 
 #include <azure/keyvault/common/internal/base64url.hpp>
 

sdk/keyvault/azure-security-keyvault-keys/src/cryptography/encrypt_parameters.cpp

@@ -2,8 +2,8 @@
 // SPDX-License-Identifier: MIT
 
 #include "azure/keyvault/keys/cryptography/encrypt_parameters.hpp"
-#include "azure/keyvault/keys/cryptography/cryptography_serializers.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
+#include "../private/cryptography_serializers.hpp"
+#include "../private/key_constants.hpp"
 
 #include <azure/keyvault/common/internal/base64url.hpp>
 

sdk/keyvault/azure-security-keyvault-keys/src/cryptography/encrypt_result.cpp

@@ -3,9 +3,9 @@
 
 #include <azure/core/internal/json/json.hpp>
 
-#include "azure/keyvault/keys/cryptography/cryptography_serializers.hpp"
+#include "../private/cryptography_serializers.hpp"
+#include "../private/key_constants.hpp"
 #include "azure/keyvault/keys/cryptography/encrypt_result.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
 
 #include <azure/keyvault/common/internal/base64url.hpp>
 

sdk/keyvault/azure-security-keyvault-keys/src/cryptography/encryption_algorithm.cpp

@@ -2,7 +2,7 @@
 // SPDX-License-Identifier: MIT
 
 #include "azure/keyvault/keys/cryptography/encryption_algorithm.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
+#include "../private/key_constants.hpp"
 
 namespace Azure {
   namespace Security {

sdk/keyvault/azure-security-keyvault-keys/src/cryptography/key_sign_parameters.cpp

@@ -1,9 +1,9 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-#include "azure/keyvault/keys/cryptography/key_sign_parameters.hpp"
-#include "azure/keyvault/keys/cryptography/cryptography_serializers.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
+#include "../private/key_sign_parameters.hpp"
+#include "../private/cryptography_serializers.hpp"
+#include "../private/key_constants.hpp"
 
 #include <azure/keyvault/common/internal/base64url.hpp>
 

sdk/keyvault/azure-security-keyvault-keys/src/cryptography/key_verify_parameters.cpp

@@ -1,9 +1,9 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-#include "azure/keyvault/keys/cryptography/key_verify_parameters.hpp"
-#include "azure/keyvault/keys/cryptography/cryptography_serializers.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
+#include "../private/key_verify_parameters.hpp"
+#include "../private/cryptography_serializers.hpp"
+#include "../private/key_constants.hpp"
 
 #include <azure/keyvault/common/internal/base64url.hpp>
 

sdk/keyvault/azure-security-keyvault-keys/src/cryptography/key_wrap_algorithm.cpp

@@ -2,7 +2,7 @@
 // SPDX-License-Identifier: MIT
 
 #include "azure/keyvault/keys/cryptography/key_wrap_algorithm.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
+#include "../private/key_constants.hpp"
 
 namespace Azure {
   namespace Security {

sdk/keyvault/azure-security-keyvault-keys/src/cryptography/key_wrap_parameters.cpp

@@ -1,9 +1,9 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-#include "azure/keyvault/keys/cryptography/cryptography_serializers.hpp"
+#include "../private/cryptography_serializers.hpp"
+#include "../private/key_constants.hpp"
 #include "azure/keyvault/keys/cryptography/encrypt_parameters.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
 
 #include <azure/keyvault/common/internal/base64url.hpp>
 

sdk/keyvault/azure-security-keyvault-keys/src/cryptography/remote_cryptography_client.cpp

@@ -5,13 +5,13 @@
 #include <azure/core/http/http.hpp>
 #include <azure/core/http/policies/policy.hpp>
 
-#include "azure/keyvault/keys/cryptography/cryptography_serializers.hpp"
-#include "azure/keyvault/keys/cryptography/key_sign_parameters.hpp"
-#include "azure/keyvault/keys/cryptography/key_verify_parameters.hpp"
-#include "azure/keyvault/keys/cryptography/key_wrap_parameters.hpp"
-#include "azure/keyvault/keys/cryptography/remote_cryptography_client.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
-#include "azure/keyvault/keys/details/key_serializers.hpp"
+#include "../private/cryptography_serializers.hpp"
+#include "../private/key_constants.hpp"
+#include "../private/key_serializers.hpp"
+#include "../private/key_sign_parameters.hpp"
+#include "../private/key_verify_parameters.hpp"
+#include "../private/key_wrap_parameters.hpp"
+#include "azure/keyvault/keys/internal/cryptography/remote_cryptography_client.hpp"
 
 #include <memory>
 #include <string>

sdk/keyvault/azure-security-keyvault-keys/src/cryptography/rsa_cryptography_provider.cpp

@@ -1,7 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-#include "azure/keyvault/keys/cryptography/rsa_cryptography_provider.hpp"
+#include "azure/keyvault/keys/internal/cryptography/rsa_cryptography_provider.hpp"
 
 #include <memory>
 #include <string>

sdk/keyvault/azure-security-keyvault-keys/src/cryptography/sign_result.cpp

@@ -3,9 +3,9 @@
 
 #include <azure/core/internal/json/json.hpp>
 
-#include "azure/keyvault/keys/cryptography/cryptography_serializers.hpp"
+#include "../private/cryptography_serializers.hpp"
+#include "../private/key_constants.hpp"
 #include "azure/keyvault/keys/cryptography/sign_result.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
 
 #include <azure/keyvault/common/internal/base64url.hpp>
 

sdk/keyvault/azure-security-keyvault-keys/src/cryptography/signature_algorithm.cpp

@@ -3,8 +3,8 @@
 
 #include <azure/keyvault/common/sha.hpp>
 
+#include "../private/key_constants.hpp"
 #include "azure/keyvault/keys/cryptography/signature_algorithm.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
 
 namespace Azure {
   namespace Security {

sdk/keyvault/azure-security-keyvault-keys/src/cryptography/unwrap_result.cpp

@@ -3,9 +3,9 @@
 
 #include <azure/core/internal/json/json.hpp>
 
-#include "azure/keyvault/keys/cryptography/cryptography_serializers.hpp"
+#include "../private/cryptography_serializers.hpp"
+#include "../private/key_constants.hpp"
 #include "azure/keyvault/keys/cryptography/unwrap_result.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
 
 #include <azure/keyvault/common/internal/base64url.hpp>
 

sdk/keyvault/azure-security-keyvault-keys/src/cryptography/verify_result.cpp

@@ -3,9 +3,9 @@
 
 #include <azure/core/internal/json/json.hpp>
 
-#include "azure/keyvault/keys/cryptography/cryptography_serializers.hpp"
+#include "../private/cryptography_serializers.hpp"
+#include "../private/key_constants.hpp"
 #include "azure/keyvault/keys/cryptography/verify_result.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
 
 #include <azure/keyvault/common/internal/base64url.hpp>
 

sdk/keyvault/azure-security-keyvault-keys/src/cryptography/wrap_result.cpp

@@ -3,9 +3,9 @@
 
 #include <azure/core/internal/json/json.hpp>
 
-#include "azure/keyvault/keys/cryptography/cryptography_serializers.hpp"
+#include "../private/cryptography_serializers.hpp"
+#include "../private/key_constants.hpp"
 #include "azure/keyvault/keys/cryptography/wrap_result.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
 
 #include <azure/keyvault/common/internal/base64url.hpp>
 

sdk/keyvault/azure-security-keyvault-keys/src/delete_key_operation.cpp

@@ -3,12 +3,12 @@
 
 #include <azure/core/exception.hpp>
 
-#include <azure/keyvault/common/keyvault_exception.hpp>
+#include <azure/keyvault/common/internal/keyvault_exception.hpp>
 
 #include "azure/keyvault/keys/delete_key_operation.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
-#include "azure/keyvault/keys/details/key_serializers.hpp"
 #include "azure/keyvault/keys/key_client.hpp"
+#include "private/key_constants.hpp"
+#include "private/key_serializers.hpp"
 
 using namespace Azure::Security::KeyVault::Keys;
 using namespace Azure::Security::KeyVault;
@@ -43,7 +43,7 @@ Azure::Security::KeyVault::Keys::DeleteKeyOperation::PollInternal(
         break;
       }
       default:
-        throw Azure::Security::KeyVault::_detail::KeyVaultException::CreateException(
+        throw Azure::Security::KeyVault::_internal::KeyVaultException::CreateException(
             std::move(rawResponse));
     }
 

sdk/keyvault/azure-security-keyvault-keys/src/deleted_key.cpp

@@ -7,9 +7,9 @@
 #include <azure/keyvault/common/internal/unix_time_helper.hpp>
 
 #include "azure/keyvault/keys/deleted_key.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
-#include "azure/keyvault/keys/details/key_serializers.hpp"
 #include "azure/keyvault/keys/key_vault_key.hpp"
+#include "private/key_constants.hpp"
+#include "private/key_serializers.hpp"
 
 using namespace Azure::Security::KeyVault::Keys;
 using namespace Azure::Core::Json::_internal;

sdk/keyvault/azure-security-keyvault-keys/src/import_key_options.cpp

@@ -6,9 +6,9 @@
 
 #include <azure/keyvault/common/internal/unix_time_helper.hpp>
 
-#include "azure/keyvault/keys/details/key_constants.hpp"
-#include "azure/keyvault/keys/details/key_serializers.hpp"
 #include "azure/keyvault/keys/import_key_options.hpp"
+#include "private/key_constants.hpp"
+#include "private/key_serializers.hpp"
 
 #include <string>
 

sdk/keyvault/azure-security-keyvault-keys/src/json_web_key.cpp

@@ -4,10 +4,10 @@
 #include <azure/core/internal/json/json_optional.hpp>
 #include <azure/keyvault/common/internal/base64url.hpp>
 
-#include "azure/keyvault/keys/details/key_constants.hpp"
-#include "azure/keyvault/keys/details/key_serializers.hpp"
 #include "azure/keyvault/keys/json_web_key.hpp"
 #include "azure/keyvault/keys/key_curve_name.hpp"
+#include "private/key_constants.hpp"
+#include "private/key_serializers.hpp"
 
 #include <map>
 #include <string>

sdk/keyvault/azure-security-keyvault-keys/src/key_backup.cpp

@@ -6,8 +6,8 @@
 
 #include <azure/keyvault/common/internal/base64url.hpp>
 
-#include "azure/keyvault/keys/details/key_backup.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
+#include "private/key_backup.hpp"
+#include "private/key_constants.hpp"
 
 #include <string>
 

sdk/keyvault/azure-security-keyvault-keys/src/key_client.cpp

@@ -7,11 +7,11 @@
 
 #include <azure/keyvault/common/internal/single_page.hpp>
 
-#include "azure/keyvault/keys/details/key_backup.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
-#include "azure/keyvault/keys/details/key_request_parameters.hpp"
-#include "azure/keyvault/keys/details/key_serializers.hpp"
 #include "azure/keyvault/keys/key_client.hpp"
+#include "private/key_backup.hpp"
+#include "private/key_constants.hpp"
+#include "private/key_request_parameters.hpp"
+#include "private/key_serializers.hpp"
 
 #include <memory>
 #include <string>

sdk/keyvault/azure-security-keyvault-keys/src/key_curve_name.cpp

@@ -2,7 +2,7 @@
 // SPDX-License-Identifier: MIT
 
 #include "azure/keyvault/keys/key_curve_name.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
+#include "private/key_constants.hpp"
 
 namespace Azure { namespace Security { namespace KeyVault { namespace Keys {
 

sdk/keyvault/azure-security-keyvault-keys/src/key_request_parameters.cpp

@@ -6,8 +6,8 @@
 
 #include <azure/keyvault/common/internal/unix_time_helper.hpp>
 
-#include "azure/keyvault/keys/details/key_constants.hpp"
-#include "azure/keyvault/keys/details/key_request_parameters.hpp"
+#include "private/key_constants.hpp"
+#include "private/key_request_parameters.hpp"
 
 #include <string>
 

sdk/keyvault/azure-security-keyvault-keys/src/key_type.cpp

@@ -2,7 +2,7 @@
 // SPDX-License-Identifier: MIT
 
 #include "azure/keyvault/keys/key_type.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
+#include "private/key_constants.hpp"
 
 #include <stdexcept>
 

sdk/keyvault/azure-security-keyvault-keys/src/key_vault_key.cpp

@@ -8,9 +8,9 @@
 
 #include <azure/keyvault/common/internal/unix_time_helper.hpp>
 
-#include "azure/keyvault/keys/details/key_constants.hpp"
-#include "azure/keyvault/keys/details/key_serializers.hpp"
 #include "azure/keyvault/keys/key_vault_key.hpp"
+#include "private/key_constants.hpp"
+#include "private/key_serializers.hpp"
 
 using namespace Azure::Security::KeyVault::Keys;
 using namespace Azure::Core::Json::_internal;

sdk/keyvault/azure-security-keyvault-keys/src/list_keys_single_page_result.cpp

@@ -2,9 +2,9 @@
 // SPDX-License-Identifier: MIT
 
 #include "azure/keyvault/keys/list_keys_single_page_result.hpp"
-#include "azure/keyvault/keys/details/key_constants.hpp"
-#include "azure/keyvault/keys/details/key_serializers.hpp"
 #include "azure/keyvault/keys/key_client.hpp"
+#include "private/key_constants.hpp"
+#include "private/key_serializers.hpp"
 
 #include <azure/keyvault/common/internal/unix_time_helper.hpp>
 

sdk/keyvault/azure-security-keyvault-keys/src/private/cryptography_serializers.hpp

@@ -17,13 +17,13 @@
 #include "azure/keyvault/keys/cryptography/decrypt_result.hpp"
 #include "azure/keyvault/keys/cryptography/encrypt_parameters.hpp"
 #include "azure/keyvault/keys/cryptography/encrypt_result.hpp"
-#include "azure/keyvault/keys/cryptography/key_sign_parameters.hpp"
-#include "azure/keyvault/keys/cryptography/key_verify_parameters.hpp"
-#include "azure/keyvault/keys/cryptography/key_wrap_parameters.hpp"
 #include "azure/keyvault/keys/cryptography/sign_result.hpp"
 #include "azure/keyvault/keys/cryptography/unwrap_result.hpp"
 #include "azure/keyvault/keys/cryptography/verify_result.hpp"
 #include "azure/keyvault/keys/cryptography/wrap_result.hpp"
+#include "key_sign_parameters.hpp"
+#include "key_verify_parameters.hpp"
+#include "key_wrap_parameters.hpp"
 
 #include <string>
 

sdk/keyvault/azure-security-keyvault-keys/src/recover_deleted_key_operation.cpp

@@ -1,12 +1,12 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // SPDX-License-Identifier: MIT
 
-#include <azure/keyvault/common/keyvault_exception.hpp>
+#include <azure/keyvault/common/internal/keyvault_exception.hpp>
 
-#include "azure/keyvault/keys/details/key_constants.hpp"
-#include "azure/keyvault/keys/details/key_serializers.hpp"
 #include "azure/keyvault/keys/key_client.hpp"
 #include "azure/keyvault/keys/recover_deleted_key_operation.hpp"
+#include "private/key_constants.hpp"
+#include "private/key_serializers.hpp"
 
 using namespace Azure::Security::KeyVault::Keys;
 using namespace Azure::Security::KeyVault;
@@ -40,7 +40,7 @@ Azure::Security::KeyVault::Keys::RecoverDeletedKeyOperation::PollInternal(
         break;
       }
       default:
-        throw Azure::Security::KeyVault::_detail::KeyVaultException::CreateException(
+        throw Azure::Security::KeyVault::_internal::KeyVaultException::CreateException(
             std::move(rawResponse));
     }
     if (m_status == Azure::Core::OperationStatus::Succeeded)

sdk/keyvault/azure-security-keyvault-keys/test/ut/CMakeLists.txt

@@ -56,6 +56,9 @@ endif()
 
 target_link_libraries(azure-security-keyvault-keys-test-live PRIVATE azure-security-keyvault-keys azure-identity gtest gmock)
 
+# Adding private headers so we can test the private APIs with no relative paths include.
+target_include_directories (azure-security-keyvault-keys-test-live PRIVATE $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../../src>)
+
 # gtest_discover_tests will scan the test from azure-core-test and call add_test
 # for each test to ctest. This enables `ctest -r` to run specific tests directly.
 gtest_discover_tests(azure-security-keyvault-keys-test-live

sdk/keyvault/azure-security-keyvault-keys/test/ut/key_client_backup_test_live.cpp

@@ -12,7 +12,7 @@
 #include <azure/core/base64.hpp>
 #include <azure/core/internal/json/json.hpp>
 #include <azure/keyvault/key_vault_keys.hpp>
-#include <azure/keyvault/keys/details/key_constants.hpp>
+#include <private/key_constants.hpp>
 
 #include <iostream>
 #include <string>

sdk/keyvault/azure-security-keyvault-keys/test/ut/key_client_create_test_live.cpp

@@ -10,7 +10,7 @@
 #include "key_client_base_test.hpp"
 
 #include <azure/keyvault/key_vault_keys.hpp>
-#include <azure/keyvault/keys/details/key_constants.hpp>
+#include <private/key_constants.hpp>
 
 #include <string>
 

sdk/keyvault/azure-security-keyvault-keys/test/ut/key_client_delete_test_live.cpp

@@ -10,7 +10,7 @@
 #include "key_client_base_test.hpp"
 
 #include <azure/keyvault/key_vault_keys.hpp>
-#include <azure/keyvault/keys/details/key_constants.hpp>
+#include <private/key_constants.hpp>
 
 #include <string>
 

sdk/keyvault/azure-security-keyvault-keys/test/ut/key_client_get_test_live.cpp

@@ -10,7 +10,7 @@
 #include "key_client_base_test.hpp"
 
 #include <azure/keyvault/key_vault_keys.hpp>
-#include <azure/keyvault/keys/details/key_constants.hpp>
+#include <private/key_constants.hpp>
 
 #include <string>
 

sdk/keyvault/azure-security-keyvault-keys/test/ut/key_client_import_test_live.cpp

@@ -10,7 +10,6 @@
 #include <azure/core/exception.hpp>
 
 #include <azure/keyvault/common/internal/base64url.hpp>
-#include <azure/keyvault/common/keyvault_exception.hpp>
 #include <azure/keyvault/key_vault_keys.hpp>
 
 #include "key_client_base_test.hpp"

sdk/keyvault/azure-security-keyvault-keys/test/ut/key_client_update_test_live.cpp

@@ -11,7 +11,7 @@
 
 #include <azure/core/datetime.hpp>
 #include <azure/keyvault/key_vault_keys.hpp>
-#include <azure/keyvault/keys/details/key_constants.hpp>
+#include <private/key_constants.hpp>
 
 #include <string>