github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Keyvault unit tests for non standard key sizes. (#2495)

Browse Source 
* param tests

* ooops

* remove get suffix

* uneeded define

* remove define

* update initi location to prevent multiple  runs

* formatting

* added negative numbers and some above 2048
This commit is contained in:
George Arama 2021-06-29 01:10:24 -07:00 committed by GitHub
parent 0874e1c1c9
commit e105bcdca3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sdk/keyvault/azure-security-keyvault-keys/test/ut/key_client_base_test.hpp
View File

@ -6,7 +6,6 @@
* @brief The base class to construct and init a Key Vault client.
*
*/
#include <gtest/gtest.h>
#include <azure/core/context.hpp>
@ -19,7 +18,7 @@
namespace Azure { namespace Security { namespace KeyVault { namespace Keys { namespace Test {
class KeyVaultClientTest : public ::testing::Test {
class KeyVaultClientTest : public ::testing::TestWithParam<int> {
private:
std::string GetEnv(const std::string& name)
{
@ -121,5 +120,4 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Keys { nam
}
}
};
}}}}} // namespace Azure::Security::KeyVault::Keys::Test

34
sdk/keyvault/azure-security-keyvault-keys/test/ut/key_cryptographic_client_test_live.cpp
View File

@ -20,13 +20,13 @@ using namespace Azure::Security::KeyVault::Keys::Test;
using namespace Azure::Security::KeyVault::Keys;
using namespace Azure::Security::KeyVault::Keys::Cryptography;
TEST_F(KeyVaultClientTest, RemoteEncrypt)
TEST_P(KeyVaultClientTest, RemoteEncrypt)
{
KeyClient keyClient(m_keyVaultUrl, m_credential);
std::string keyName(GetUniqueName());
CreateRsaKeyOptions rsaKeyOptions(keyName);
rsaKeyOptions.KeySize = 2048;
rsaKeyOptions.KeySize = GetParam();
auto rsaKey = keyClient.CreateRsaKey(rsaKeyOptions).Value;
// init crypto client from key ID. The remote client will get the key and try to create a local
@ -49,13 +49,13 @@ TEST_F(KeyVaultClientTest, RemoteEncrypt)
}
}
TEST_F(KeyVaultClientTest, RemoteWrap)
TEST_P(KeyVaultClientTest, RemoteWrap)
{
KeyClient keyClient(m_keyVaultUrl, m_credential);
std::string keyName(GetUniqueName());
CreateRsaKeyOptions rsaKeyOptions(keyName);
rsaKeyOptions.KeySize = 2048;
rsaKeyOptions.KeySize = GetParam();
auto rsaKey = keyClient.CreateRsaKey(rsaKeyOptions).Value;
// init crypto client from key ID. The remote client will get the key and try to create a local
@ -78,13 +78,13 @@ TEST_F(KeyVaultClientTest, RemoteWrap)
}
}
TEST_F(KeyVaultClientTest, RemoteSignVerifyRSA256)
TEST_P(KeyVaultClientTest, RemoteSignVerifyRSA256)
{
KeyClient keyClient(m_keyVaultUrl, m_credential);
std::string keyName(GetUniqueName());
CreateRsaKeyOptions rsaKeyOptions(keyName);
rsaKeyOptions.KeySize = 2048;
rsaKeyOptions.KeySize = GetParam();
auto rsaKey = keyClient.CreateRsaKey(rsaKeyOptions).Value;
// init crypto client from key ID. The remote client will get the key and try to create a local
@ -182,13 +182,13 @@ TEST_F(KeyVaultClientTest, RemoteSignVerifyES256)
}
}
TEST_F(KeyVaultClientTest, RemoteSignVerifyRSA384)
TEST_P(KeyVaultClientTest, RemoteSignVerifyRSA384)
{
KeyClient keyClient(m_keyVaultUrl, m_credential);
std::string keyName(GetUniqueName());
CreateRsaKeyOptions rsaKeyOptions(keyName);
rsaKeyOptions.KeySize = 2048;
rsaKeyOptions.KeySize = GetParam();
auto rsaKey = keyClient.CreateRsaKey(rsaKeyOptions).Value;
// init crypto client from key ID. The remote client will get the key and try to create a local
@ -233,13 +233,13 @@ TEST_F(KeyVaultClientTest, RemoteSignVerifyRSA384)
}
}
TEST_F(KeyVaultClientTest, RemoteSignVerifyDataRSA256)
TEST_P(KeyVaultClientTest, RemoteSignVerifyDataRSA256)
{
KeyClient keyClient(m_keyVaultUrl, m_credential);
std::string keyName(GetUniqueName());
CreateRsaKeyOptions rsaKeyOptions(keyName);
rsaKeyOptions.KeySize = 2048;
rsaKeyOptions.KeySize = GetParam();
auto rsaKey = keyClient.CreateRsaKey(rsaKeyOptions).Value;
// init crypto client from key ID. The remote client will get the key and try to create a local
@ -276,3 +276,17 @@ TEST_F(KeyVaultClientTest, RemoteSignVerifyDataRSA256)
EXPECT_TRUE(verifyResult.IsValid);
}
}
namespace {
static std::string GetSuffix(const testing::TestParamInfo<int>& info)
{
auto stringValue = std::to_string(abs(info.param));
return info.param < 0 ? "Minus" + stringValue : stringValue;
}
} // namespace
INSTANTIATE_TEST_SUITE_P(
Parametrized,
KeyVaultClientTest,
::testing::Values(-215, -100, 0, 13, 55, 233, 987, 1597, 2048, 3072, 4096),
GetSuffix);