Commit Graph

162 Commits

Author SHA1 Message Date
Victor Vazquez
83295c69ed
Re implement keyvault keys (#2705)
* updated-create-key with no protocol client
2021-08-05 23:20:29 +00:00
George Arama
697f45a454
PurgeDeletedSecret (#2696)
* working

* comment
2021-08-05 10:26:57 -07:00
Victor Vazquez
2feed76d86
clang doc fixes (#2697) 2021-08-02 11:55:08 -07:00
George Arama
d830de4afc
Backup / Restore secret (#2683)
* fix doc warnings

* get rid of bad merge

* fix doc warnings

* get rid of bad merge

* fix doc warnings

* get rid of bad merge

* code complete

* fix doc warnings

* get rid of bad merge

* fix doc warnings

* get rid of bad merge

* fix doc warnings

* get rid of bad merge

* test

* also restore

* new line

* fix doc warnings

* get rid of bad merge

* fix doc warnings

* get rid of bad merge

* fix doc warnings

* get rid of bad merge

* fixes for PR and build issues

* add header for linux build

* fix UT for mac

* remove offending issues

* rename from data to response

* added overload

* response -> result

* remove overload
2021-07-29 12:12:44 -07:00
George Arama
f14199e649
Update secret api (#2669)
* fix doc warnings

* working

* update the tag serialization

* get rid of files that were not supposed to be edited

* add convenience method

* fix doc warnings

* get rid of bad merge

* fix doc warnings

* get rid of bad merge

* fix doc warnings

* get rid of bad merge

* updates for merge

* PR comments
2021-07-27 20:08:21 -07:00
Victor Vazquez
5c14975957
remove prefer ninja (#2675) 2021-07-27 19:26:11 -07:00
Victor Vazquez
a508789c36
Remove warning supress (#2677)
* remove warning suppress not required anymore

* json update

* update the curl header including

* changelog
2021-07-27 18:09:52 -07:00
Victor Vazquez
bd1beaf0b4
remove the const double ref and use move instead (#2674) 2021-07-27 17:39:26 -07:00
George Arama
72b9cf9487
Set secret (#2663)
* Progress stream reader

* format

* Update sdk/core/azure-core/src/io/body_stream.cpp

Co-authored-by: JinmingHu <jinmhu@microsoft.com>

* PR comments

* remove

* one more comment

* replaced if null with azure_assert

* moved from pointer to reference

* first pass

* src builds

* new line

* huzaaaaa

* readme

* strating point

* get progress, need to deserialize now

* serializer

* some more

* tests

* more tests

* some refactor

* start

* comment and formatting

* set secret serializer

* added serializer ut

* add headers

* working again

* add cmake

* cleanup relative paths

* couple of updates

* clang

* working as expected

* remove pedantic ;

* include

* pr comments

* clang format

* trigger

* trigger 2

* PR comments

* name value swap

* updates from merge

* pre PR

* format

* remove hpp from list

* remove unused #include

* put back hpp file

* put the methods in a namespace

* PR comments

* some more comments

* fixes

Co-authored-by: JinmingHu <jinmhu@microsoft.com>
2021-07-27 15:01:51 -07:00
George Arama
65d560dc11
GetDeletedSecret API (#2666)
* fix doc warnings

* fix doc warnings

* GetDeletedSecretAPI

* undo uneeded changes

* comments
2021-07-27 13:10:14 -07:00
Victor Vazquez
c8a45ad7ac
Remove extra whitespace from header 2021-07-27 08:26:39 -07:00
George Arama
0d4f138cb3
GetSecret Api implementation for Keyvault Secret (#2656)
* Progress stream reader

* format

* Update sdk/core/azure-core/src/io/body_stream.cpp

Co-authored-by: JinmingHu <jinmhu@microsoft.com>

* PR comments

* remove

* one more comment

* replaced if null with azure_assert

* moved from pointer to reference

* first pass

* src builds

* new line

* huzaaaaa

* readme

* strating point

* get progress, need to deserialize now

* serializer

* some more

* tests

* more tests

* some refactor

* start

* comment and formatting

* working again

* couple of updates

* clang

* remove pedantic ;

* include

* pr comments

* clang format

* trigger

* trigger 2

* PR comments

* name value swap

Co-authored-by: JinmingHu <jinmhu@microsoft.com>
2021-07-23 17:36:04 -07:00
George Arama
4805900fb6
Fix build break in vcpkg (#2662)
The issue came from a missformatted json file , the fix is straight forward ,
The number of commits can be ignored, the merge is squashed,
the operations i performed were : \

git checkout pipeline
git pull upstream main
git push
^^^^^
Enumerating objects: 1, done.
Counting objects: 100% (1/1), done.
Writing objects: 100% (1/1), 276 bytes | 276.00 KiB/s, done.
Total 1 (delta 0), reused 0 (delta 0), pack-reused 0
To https://github.com/gearama/azure-sdk-for-cpp.git
85b8e3f..032f2b3 pipeline -> pipeline
* Progress stream reader

* format

* Update sdk/core/azure-core/src/io/body_stream.cpp

Co-authored-by: JinmingHu <jinmhu@microsoft.com>

* PR comments

* fix doc warnings

* remove

* one more comment

* replaced if null with azure_assert

* moved from pointer to reference

* first pass

* src builds

* new line

* huzaaaaa

* maybe

* add resource for tests

* readme

* formatting

* build break url

* put proper link

* darn link

* comments from PR

* update to use gtest_main

* fix vcpkg build break

Co-authored-by: JinmingHu <jinmhu@microsoft.com>
2021-07-23 15:40:19 -07:00
Ahson Khan
e0c57f703e
Avoid duplication of a method by expanding out the struct into their constituting fields. (#2595) 2021-07-22 13:48:18 -07:00
Ahson Khan
d90d5c761e
Consolidate keyvault and cryptography client options and model files into single headers. (#2640)
* Consolidate keyvault options and model files into single headers.

* Consolidate cryptography client model headers into a single header.

* Fix up merge conflict

* Consolidate LROs into one, and fixup PagedResponse name.

* Fix up clang formatting and match cpp file name with hpp.

* Fix clang formatting.

* Move LROs and PagedResponse types into models as well.

* Move encrypt and decrypt parameter types into cryptography model header
file.

* Fix clang format, reodering of headers.

* Update to match recent changes.

* Update CL
2021-07-22 11:48:55 -07:00
George Arama
e4d5e31371
Pipeline for keyvault secrets (#2654)
* Progress stream reader

* format

* Update sdk/core/azure-core/src/io/body_stream.cpp

Co-authored-by: JinmingHu <jinmhu@microsoft.com>

* PR comments

* fix doc warnings

* remove

* one more comment

* replaced if null with azure_assert

* moved from pointer to reference

* first pass

* src builds

* new line

* huzaaaaa

* maybe

* add resource for tests

* readme

* formatting

* build break url

* put proper link

* darn link

* comments from PR

* update to use gtest_main

Co-authored-by: JinmingHu <jinmhu@microsoft.com>
2021-07-22 08:46:21 -07:00
George Arama
7da78d4cc9
Setup secrets boilerplate code from templates (#2650)
* Progress stream reader

* format

* Update sdk/core/azure-core/src/io/body_stream.cpp

Co-authored-by: JinmingHu <jinmhu@microsoft.com>

* PR comments

* fix doc warnings

* remove

* one more comment

* replaced if null with azure_assert

* moved from pointer to reference

* first pass

* src builds

* new line

* huzaaaaa

* readme

* formatting

* build break url

* put proper link

* darn link

* comments from PR

* update to use gtest_main

Co-authored-by: JinmingHu <jinmhu@microsoft.com>
2021-07-21 14:13:19 -07:00
Victor Vazquez
7af67c509d
fix broken link (#2651) 2021-07-21 20:13:54 +00:00
Azure SDK Bot
c1ef7545c8
Increment package version after release of azure-security-keyvault-keys (#2649) 2021-07-20 13:33:53 -07:00
Ahson Khan
157e4875f1
Update CL version for key vault for the beta release (#2646)
* Update CL version for key vault for the beta release
2021-07-20 09:50:25 -07:00
Victor Vazquez
82ca4cfc83
update polling timeout to 5 min (#2641)
* update polling timeout to 5 min

* update all polling intervals

* disable purge testing until it is again supported by service

* update live tests

* update test to avoid checking number of keys

* fix test - look keys in deleted keys

* max timeout
2021-07-20 07:35:50 +00:00
Victor Vazquez
0140a4add6
remove local support for crypto client (#2638) 2021-07-15 18:15:21 -07:00
Ahson Khan
7d7d036136
Use std::vector instead of std::list for KeyOperation arrays. (#2636)
* Use std::vector instead of std::list for KeyOperation arrays.

* Add change log entry.
2021-07-15 15:41:10 -07:00
Ahson Khan
ca220a8fde
Remove unnecessary methods in the header that aren't called by anyone else. (#2633) 2021-07-15 13:37:42 -07:00
Ahson Khan
b9a7a014ac
Remove JsonWebKey.HasPrivateKey() since it is not required by anyone. (#2634)
* Remove JsonWebKey.HasPrivateKey() since it is not required by anyone.

* Update CL.

* Update CL to be consistent.
2021-07-15 13:37:10 -07:00
Ahson Khan
fb1d66ee0c
Avoid separating key and vault in file names, change key_vault_ to (#2635)
keyvault_.
2021-07-15 13:00:33 -07:00
Ahson Khan
90bdfd8408
Other than options and model types (which are property bags), make everything that has functions, a class. (#2631)
* Other than options and model types (which are property bags), make
everything that has functions, a class.

* Fix clang formatting.
2021-07-15 11:25:30 -07:00
Victor Vazquez
76fd63b2b3
rename types (#2594)
* rename header

* format

* update name

* changelog

* format

* name updates
2021-07-15 10:36:21 -07:00
Ahson Khan
e69f6e182a
Use forward declaration to avoid exposing private/src headers from public headers. (#2626)
* Remove InitRequest helper method

* Rename KeyVaultPipeline to KeyVaultProtocolClient along with headers.

* Move the KeyVaultProtocolClient into private imlpementation detail of
Keys.

* Update doc comments.

* Stop building keyvault common for now since it contains no sources.

* Don't generate keyvault common docs since there are no files.

* Stop building azure-security-keyvault-common as part of CI.

* Use forward declaration to avoid exposing private/src headers from
public headers.

* Simplify after the merge from main.
2021-07-14 20:21:42 -07:00
Ahson Khan
c4af969569
Remove vcpkg dependency from keyvault-keys on keyvault-common. (#2630) 2021-07-14 16:55:18 -07:00
Ahson Khan
61f11aa39a
Update keyvault keys readme to use C++ specific links (#2628)
Fixes https://github.com/Azure/azure-sdk-for-cpp/issues/2598
2021-07-14 23:39:50 +00:00
Ahson Khan
427e892582
Removed the /internal/ directory in Keyvault Keys and move headers to private that don't need to be public. (#2625)
* Removed the /internal/ directory in Keyvault Keys and move headers to
private that don't need to be public.

* Clang format.

* Move CryptographyProvider and RCC into private headers as well.

* Fix clang formatting.
2021-07-14 15:26:23 -07:00
Ahson Khan
c4ff48e8a5
Rename KeyVaultPipeline to KeyVaultProtocolClient and make it an impl detail (move it to _detail) within the keys package instead of common (#2618)
* Remove InitRequest helper method

* Rename KeyVaultPipeline to KeyVaultProtocolClient along with headers.

* Move the KeyVaultProtocolClient into private imlpementation detail of
Keys.

* Update doc comments.

* Stop building keyvault common for now since it contains no sources.

* Don't generate keyvault common docs since there are no files.

* Stop building azure-security-keyvault-common as part of CI.
2021-07-14 12:42:13 -07:00
Ahson Khan
a10b507e42
Adding BackupKeyResult struct wrapper as a return type model for BackupKey. (#2619)
* Adding BackupKeyResult struct wrapper as a return type model for
BackupKey.

* Update sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/backup_key_result.hpp

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2021-07-14 12:22:15 -07:00
Ahson Khan
05ebec8b50
Removed the MaxPageResults field from GetPropertiesOfKeysOptions, GetPropertiesOfKeyVersionsOptions, and GetDeletedKeysOptions. (#2620)
* Remove the MaxPageResults options on KeyVault GetPropertiesOfKeys and other APIs.

* Update CL
2021-07-14 12:12:40 -07:00
Ahson Khan
c8cefb044a
Fix up doc typos in the PagedResponse KeyVault APIs. (#2621) 2021-07-14 12:07:05 -07:00
Ahson Khan
404fd94710
Remove unused internal helper method from KeyVaultPipeline. (#2623) 2021-07-14 12:00:10 -07:00
Victor Vazquez
5ddebe53bf
Rename list_keys_result KeyVault header to list_keys_responses to match PagedResponse naming pattern (#2592)
* rename header

* format
2021-07-13 20:12:35 -07:00
Ahson Khan
92aef8a8c6
Add missing key vault keys cryptography headers to the simplified header. (#2597)
* Add missing key vault keys cryptography headers to the simplified header.

* Fix sort order according to clang format, which seems to differ from Windows dir file system command.
2021-07-12 14:31:13 -07:00
Ahson Khan
07861a9687
Avoid inheriting from an internal base class for KeyVault PagedResponse Options and expose fields directly (#2590)
* Avoid inheriting from an internal base class for KeyVault PagedResponse Options and expose fields directly

* fix for compilation

Co-authored-by: Victor Vazquez <vhvb1989@gmail.com>
2021-07-09 15:36:16 -07:00
Victor Vazquez
480f867cec
keyvault changelog and version update (#2575) 2021-07-08 16:46:38 -07:00
Victor Vazquez
eabfb523d9
Update header names (#2580)
* Update header names

* cl
2021-07-08 16:39:25 -07:00
Victor Vazquez
33d4b72a4d
remove encrypt decrypt overload (#2574)
* remove encrypt decrypt overload

* cl

* format
2021-07-07 21:01:52 -07:00
George Arama
ecbf8d0784
add some more uts for create (#2510)
* add some more uts for create

* format

* remove unused include

* Update sdk/keyvault/azure-security-keyvault-keys/test/ut/mocked_transport_adapter_test.hpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* put back include, it doesn't work otherwise

* format

* Revert "format"

This reverts commit afefd264868ededefe8ad715dd1674a333fd1176.

* Revert "put back include, it doesn't work otherwise"

This reverts commit 54f05fe8d2b63f089e76931c5592b64e80f98b5e.

* Revert "Update sdk/keyvault/azure-security-keyvault-keys/test/ut/mocked_transport_adapter_test.hpp"

This reverts commit 8ce4f0b3a2e893be69afdfc710c060fe76c5493a.

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2021-07-07 21:00:11 -07:00
Victor Vazquez
9b06fc8f33
compile samples (#2556)
* compile samples
2021-07-07 06:50:05 -07:00
Ahson Khan
d0ca42643f
Move Sha256Hash and other Hash algorithm types from KeyVault to Azure::Core (#2526)
* Move the SHA256, 384, and 512 Hash implementations to be internal.

* Update changelog and add back missing file.

* Rename SHA256 and others to Sha256Hash and update header name.

* Fix up path in CMakeList by removing quotes.

* Rename the sha.cpp source file to match header.

* Move Sha256Hash and other Hash algorithm types from KeyVault to
Azure::Core.

* Reorder src file in cmakelist to be alpha order just to reset CI

* Revert "Reorder src file in cmakelist to be alpha order just to reset CI"

This reverts commit 6729cf311af76bb8388738cc519ea40092bc362c.
2021-07-01 15:42:36 -07:00
Ahson Khan
a6f3b530d5
Move Base64Url helper internal methods from KeyVault to Azure Core. (#2528)
* Move Base64Url helper internal methods from KeyVault to Azure Core.

* Run clang format.
2021-07-01 12:24:38 -07:00
Ahson Khan
773beffd64
Rename SHA256 and others to Sha256Hash and update header name. (#2525)
First review https://github.com/Azure/azure-sdk-for-cpp/pull/2523

Relevant commit to review: f207fe80b9

Second step of of https://github.com/Azure/azure-sdk-for-cpp/issues/2500#issuecomment-871761727
2021-07-01 18:55:58 +00:00
Victor Vazquez
5b5cb9b5f7
ApiView requested changes (#2493)
* ApiView requested changes

* update test

* Apply suggestions from code review

Co-authored-by: Ahson Khan <ahkha@microsoft.com>

* update private field name

Co-authored-by: Ahson Khan <ahkha@microsoft.com>
2021-07-01 18:45:43 +00:00
George Arama
c449e3f9bc
2502 exceptions (#2529)
* first pass

* move exception creation from keyvault to core

* merge fix

* format

* fix includes location and containers

* remove default constructor

* to trigger build

* undo change

* uncomment

* Update sdk/core/azure-core/test/ut/exception_test.cpp

Co-authored-by: Rick Winter <rick.winter@microsoft.com>

Co-authored-by: Rick Winter <rick.winter@microsoft.com>
2021-07-01 04:17:15 +00:00