weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
5,399 Commits 45 Branches 0 Tags 96 MiB
ecc552a7de
Commit Graph

2363 Commits

Author SHA1 Message Date
Edward Lynes
ecc552a7de Update Aka issuer to use v2 API 
Signed-off-by: Edward Lynes <elynes@akamai.com>
 2021-05-14 13:31:13 -04:00
jetstack-bot
e941307bdc
Merge pull request #3938 from irbekrm/3879_test_acme_issuer_setup 
3879 test acme issuer setup
 2021-05-14 13:35:50 +01:00
irbekrm
9ecf896130 Implement feedback from code review 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-05-14 12:40:30 +01:00
jetstack-bot
0ff2b8778c
Merge pull request #3983 from JoshVanL/parse-certificate-chain-venafi 
Parse certificate chain venafi
 2021-05-13 14:21:14 +01:00
jetstack-bot
22ff380f39
Merge pull request #3984 from JoshVanL/parse-certificate-chain-acme 
Parse certificate chain acme
 2021-05-13 13:50:14 +01:00
jetstack-bot
96ea5e51d4
Merge pull request #3985 from JoshVanL/parse-certificate-chain-ca 
Parse certificate chain CA Issuer
 2021-05-13 13:23:14 +01:00
jetstack-bot
595d753339
Merge pull request #3982 from JoshVanL/parse-certificate-chain 
Change Vault Issuer to construct the certificate chain to populate the CertificateRequest CA with the root most cert.
 2021-05-12 17:34:13 +01:00
joshvanl
58a25314f7 Changes CR CA controller to use ECDSA keys 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-05-12 15:07:25 +01:00
joshvanl
ea2cfdc3c9 Updates CA issuer to updates SignCSRTemplate and propagate CA 
certificate down

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-05-12 14:22:59 +01:00
joshvanl
d327d40297 Updates SignCSRTemplate to use ParseCertificateChain 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-05-12 14:22:59 +01:00
joshvanl
9622b664bf Adds SecretTLSKeyPairAndCA to parse a certificate chain and CA from a 
target Secret

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-05-12 14:22:59 +01:00
joshvanl
e4d3d3f725 Change ParseCertificateChain to ParseSingleCertificateChain 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-05-12 14:17:41 +01:00
joshvanl
33fcf0d082 Uses ParseCertificateChainPEM for ACME Order Response 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-05-12 14:17:02 +01:00
joshvanl
d69a4e1a3c Change ParseCertificateChain to ParseSingleCertificateChain 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-05-12 14:15:54 +01:00
joshvanl
1030bbadb5 Change Venafi Signer to use ParseCertificateChain to populate Status.CA 
correctly

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-05-12 14:14:47 +01:00
joshvanl
68aeb330b7 Change ParseCertificateChain to ParseSingleCertificateChain to show 
intention better

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-05-12 14:12:06 +01:00
Jake Sanders
ef2a830614
./hack/update-bazel.sh 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-05-11 14:50:28 +01:00
Jake Sanders
79d8d9cb7b
Revert "Merge pull request #3724 from inteon/istio-virtualservice-for-http01" 
This reverts commit 80f27739b5, reversing
changes made to 96604d02a3.

Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-05-11 14:50:25 +01:00
Jake Sanders
423e82b65b
Revert "Merge pull request #3939 from JoshVanL/istio-api-to-internal-apis" 
This reverts commit f2a74ade5e, reversing
changes made to 7ff54e61e9.

Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-05-11 14:50:23 +01:00
Jake Sanders
8ca19b26f9
Revert "Merge pull request #3946 from inteon/fix_kubectl_apply" 
This reverts commit c7514d9262, reversing
changes made to 49cbedf262.

Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-05-11 14:50:18 +01:00
jetstack-bot
bd817cce0a
Merge pull request #3936 from irbekrm/webhook_warnings 
Webhook warnings
 2021-05-11 13:43:53 +01:00
irbekrm
6cb57c4c33 Makes ACME EAB key algo warning value unexported 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-05-11 13:14:33 +01:00
joshvanl
88693435b8 Change ParseCertificateChain test func to use ECDSA keys to speed up 
runtime

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-05-10 19:13:31 +01:00
joshvanl
d17626c927 Changes vault issuer to use ParseCertificateChain from response from 
vault

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-05-10 19:07:31 +01:00
joshvanl
744906ebaf Adds ParseCertificateChain to parse and test a pem bundle to ensure its 
a valid flat chain. Returns a chain and optional CA

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
 2021-05-10 19:06:21 +01:00
irbekrm
e82ea35744 Adds a unit test for ACME issuer Setup function 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-05-10 09:53:53 +01:00
irbekrm
c97b14a216 Fix FakeRegistry.AddClient + ensure that FakeACME implements accounts.Registry 
Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-05-10 09:52:34 +01:00
irbekrm
f438ae30ab Refactor Setup to make it more DRY + use consts instead of string literals 
This commit also ensures that issuer's observed generation is updated in cases where the issuer spec has changed, but the re-registration is skipped as the current registration seems already valid

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-05-10 09:51:24 +01:00
irbekrm
d8367cbac8 Remove direct calls to external deps from Setup function 
Allow the functionality to set up a new ACME client and to retrieve and decode ACME account's key to be stubbed in tests

Signed-off-by: irbekrm <irbekrm@gmail.com>
 2021-05-10 09:51:07 +01:00
jetstack-bot
3434c78188
Merge pull request #3960 from wallrj/538-lint-fixes-richardw 
Fix some linting errors
 2021-05-07 11:50:34 +01:00
Richard Wall
fc1f6ffea9 ./hack/update-deps.sh 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2021-05-07 09:55:09 +01:00
Richard Wall
3811847872 Fail benchmark if scheduleN returns an error 
pkg/controller/acmechallenges/scheduler/scheduler_test.go:84:16                          errcheck     Error return value of `s.scheduleN` is not checked
pkg/controller/acmechallenges/scheduler/scheduler_test.go:98:16                          errcheck     Error return value of `s.scheduleN` is not checked
pkg/controller/acmechallenges/scheduler/scheduler_test.go:112:16                         errcheck     Error return value of `s.scheduleN` is not checked
pkg/controller/acmechallenges/scheduler/scheduler_test.go:314:51                         errcheck     Error return value of `` is not checked

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2021-05-07 09:55:09 +01:00
Richard Wall
c9eb75c447 Remove unused test-case field 
pkg/controller/certificaterequests/venafi/venafi_test.go:787:2                           structcheck  `issuer` is unused

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2021-05-07 09:55:09 +01:00
Richard Wall
b35ae551bf Fail test of Register returns an error 
pkg/controller/issuers/sync_test.go:55:12                                                errcheck     Error return value of `c.Register` is not checked

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2021-05-07 09:55:09 +01:00
Richard Wall
98d2672d3a Fail test on unexpected errors 
pkg/issuer/acme/dns/rfc2136/rfc2136_test.go:58:23                                        errcheck     Error return value of `server.Shutdown` is not checked
pkg/issuer/acme/dns/rfc2136/rfc2136_test.go:336:12                                       errcheck     Error return value of `w.WriteMsg` is not checked
pkg/issuer/acme/dns/rfc2136/rfc2136_test.go:355:12                                       errcheck     Error return value of `w.WriteMsg` is not checked
pkg/issuer/acme/dns/rfc2136/rfc2136_test.go:361:12                                       errcheck     Error return value of `w.WriteMsg` is not checked

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2021-05-07 09:55:09 +01:00
Jake Sanders
98c3b56e43
close stopch in failure cases 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-05-06 12:18:56 +01:00
Jake Sanders
bb519a59b9
Log a message when test framework fails to parse cover profile flag 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-05-05 16:40:16 +01:00
Jake Sanders
eab7c954a2
Use %v to log errors 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-05-05 16:28:46 +01:00
Jake Sanders
196e42c221
Tidy godoc comments 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-05-05 16:21:24 +01:00
Jake Sanders
f194d9b732
Add godoc comments 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-05-05 15:59:02 +01:00
Jake Sanders
f2a9d5f655
staticcheck: error strings should not be capitlized (ST1005) 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-05-04 15:58:46 +01:00
Jake Sanders
03cc4dc24d
Update bazel 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-05-04 15:24:12 +01:00
Jake Sanders
2390264fd4
staticcheck: package "github.com/jetstack/cert-manager/pkg/apis/certmanager/v1" is being imported more than once (ST1019) 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-05-04 15:05:32 +01:00
Richard Wall
f8b4934e7c Use consistent pointer receiver 
pkg/controller/controller.go:135:1: receiver name b should be consistent with previous receiver name c for controller

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2021-05-04 15:03:56 +01:00
Jake Sanders
8a8bf6fbca
staticcheck: error strings should not be capitlized (ST1005) 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-05-04 15:03:10 +01:00
Jake Sanders
bab9efaa8f
staticcheck: package imported more than once 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-05-04 14:58:23 +01:00
Richard Wall
6c544dafa0 Simplify the return statement 
pkg/controller/certificates/trigger/trigger_controller_test.go:257:12: if block ends with a return statement, so drop this else and outdent its block

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2021-05-04 14:57:20 +01:00
Jake Sanders
62aa7aa33e
staticcheck: error strings should not be capitalized (ST1005) 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-05-04 14:54:05 +01:00
Richard Wall
c15d30742d Remove duplicate import 
pkg/controller/certificaterequests/venafi/venafi_test.go:43:2: package "github.com/jetstack/cert-manager/pkg/controller/test" is being imported more than once (ST1019)
pkg/controller/certificaterequests/venafi/venafi_test.go:44:2: other import of "github.com/jetstack/cert-manager/pkg/controller/test"

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
 2021-05-04 14:50:37 +01:00
Jake Sanders
e01d96381c
errheck: Error return value of source.Run is not checked 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
 2021-05-04 14:45:45 +01:00