These tests are currently failing- we should investigate and re-enable
them.
This reverts commit c769432db5.
Signed-off-by: irbekrm <irbekrm@gmail.com>
The controller-gen tool is quite rude and won't tell you when one of the
CRD manifests cannot be parsed when the option schemapatch is used. As
an example, the following:
sed -i 's/RFC8555/RFC8556/g' pkg/apis/certmanager/v1/types_issuer.go
controller-gen schemapatch:manifests=./deploy/crds output:dir=./deploy/crds paths=./pkg/apis/...
should trigger a change in the crd-clusterissuers.yaml:
@@ -3184,7 +3184,7 @@ spec:
type: object
properties:
acme:
- description: ACME [...] communicate with a RFC8555
+ description: ACME [...] communicate with a RFC8556
type: object
Unfortunately, controller-gen v0.2.9-0.20200414181213-645d44dca7c0
silently skips faulty CRD manifests. In our case, the CRD had become a
non-YAML file (we need to use some if statements):
{{- if .Values.webhook.url.host }}
url: https://{{ .Values.webhook.url.host }}/convert
{{- else }}
service:
name: {{ template "webhook.fullname" . }}
namespace: {{ .Release.Namespace | quote }}
path: /convert
{{- end }}
Two issues can be found (we can use a YAML parser like yq for that):
1. The pipe "|" used in ".Release.Namespace | quote" makes it an invalid
YAML file. We could rewrite that to
{{ quote .Release.Namespace }}
but I decided to go with actual quotes like with the rest of the
file.
2. The {{ if }}, {{ else }} and {{ end }} are also invalid YAML syntax,
and one easy workaround is to comment them.
So many workarounds... but it now works!
Signed-off-by: Maël Valais <mael@vls.dev>
This commit also ensures that issuer's observed generation is updated in cases where the issuer spec has changed, but the re-registration is skipped as the current registration seems already valid
Signed-off-by: irbekrm <irbekrm@gmail.com>
Allow the functionality to set up a new ACME client and to retrieve and decode ACME account's key to be stubbed in tests
Signed-off-by: irbekrm <irbekrm@gmail.com>
pkg/controller/acmechallenges/scheduler/scheduler_test.go:84:16 errcheck Error return value of `s.scheduleN` is not checked
pkg/controller/acmechallenges/scheduler/scheduler_test.go:98:16 errcheck Error return value of `s.scheduleN` is not checked
pkg/controller/acmechallenges/scheduler/scheduler_test.go:112:16 errcheck Error return value of `s.scheduleN` is not checked
pkg/controller/acmechallenges/scheduler/scheduler_test.go:314:51 errcheck Error return value of `` is not checked
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
pkg/controller/issuers/sync_test.go:55:12 errcheck Error return value of `c.Register` is not checked
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
pkg/issuer/acme/dns/rfc2136/rfc2136_test.go:58:23 errcheck Error return value of `server.Shutdown` is not checked
pkg/issuer/acme/dns/rfc2136/rfc2136_test.go:336:12 errcheck Error return value of `w.WriteMsg` is not checked
pkg/issuer/acme/dns/rfc2136/rfc2136_test.go:355:12 errcheck Error return value of `w.WriteMsg` is not checked
pkg/issuer/acme/dns/rfc2136/rfc2136_test.go:361:12 errcheck Error return value of `w.WriteMsg` is not checked
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
