weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Use consistent pointer receiver

Browse Source 
pkg/controller/controller.go:135:1: receiver name b should be consistent with previous receiver name c for controller

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
This commit is contained in:
Richard Wall 2021-05-04 15:03:56 +01:00
parent 6c544dafa0
commit f8b4934e7c
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
pkg/controller/controller.go
View File

@ -132,12 +132,12 @@ func (c *controller) Run(workers int, stopCh <-chan struct{}) error {
return nil
}
func (b *controller) worker(ctx context.Context) {
log := logf.FromContext(b.ctx)
func (c *controller) worker(ctx context.Context) {
log := logf.FromContext(c.ctx)
log.V(logf.DebugLevel).Info("starting worker")
for {
obj, shutdown := b.queue.Get()
obj, shutdown := c.queue.Get()
if shutdown {
break
}
@ -145,7 +145,7 @@ func (b *controller) worker(ctx context.Context) {
var key string
// use an inlined function so we can use defer
func() {
defer b.queue.Done(obj)
defer c.queue.Done(obj)
var ok bool
if key, ok = obj.(string); !ok {
return
@ -154,9 +154,9 @@ func (b *controller) worker(ctx context.Context) {
log.V(logf.DebugLevel).Info("syncing item")
// Increase sync count for this controller
b.metrics.IncrementSyncCallCount(b.name)
c.metrics.IncrementSyncCallCount(c.name)
err := b.syncHandler(ctx, key)
err := c.syncHandler(ctx, key)
if err != nil {
if strings.Contains(err.Error(), genericregistry.OptimisticLockErrorMsg) {
log.Info("re-queuing item due to optimistic locking on resource", "error", err.Error())
@ -164,11 +164,11 @@ func (b *controller) worker(ctx context.Context) {
log.Error(err, "re-queuing item due to error processing")
}
b.queue.AddRateLimited(obj)
c.queue.AddRateLimited(obj)
return
}
log.V(logf.DebugLevel).Info("finished processing work item")
b.queue.Forget(obj)
c.queue.Forget(obj)
}()
}
log.V(logf.DebugLevel).Info("exiting worker loop")