Commit Graph

6536 Commits

Author SHA1 Message Date
joshvanl
d1ffb0ad0d Adds roundtrip tests for issuer and cluster issuer serialize
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:26:56 +00:00
joshvanl
3e23b6fd8a Adds patch permissions to cert-manager controller for issuers and
clusterissuers

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:26:56 +00:00
joshvanl
5f1249efe9 Adds issuer and cluster issuer integration tests to ensure mapped
conditions

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:26:56 +00:00
joshvanl
085b2bf34b Updates issuer and cluster issuer controllers to optionally user server
side apply

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:26:56 +00:00
joshvanl
5c37326e36 Adds issuer apply helper
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:26:56 +00:00
joshvanl
49108a0278 Adds list map type to Conditions for both Issuers and Cluster Issuers
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:26:56 +00:00
jetstack-bot
07c665e001
Merge pull request #4842 from SgtCoDFish/ctlintegrationtime
Change handling of time in ctl integration tests
2022-02-11 14:33:01 +00:00
jetstack-bot
9ff7568f4e
Merge pull request #4809 from JoshVanL/ca-injector-remove-auditsinks-permissions
Remove auditsinks permissions from ca-injector as it is no longer supported
2022-02-11 13:56:01 +00:00
jetstack-bot
4f11cc27dd
Merge pull request #4822 from JoshVanL/devel-feature-gates-parse
Parse and distribute feature gates in devel script
2022-02-11 13:19:01 +00:00
jetstack-bot
0bee3ec8f2
Merge pull request #4843 from SgtCoDFish/unsoundsched
Increase margin of error in an otherwise unsound test
2022-02-11 12:10:01 +00:00
jetstack-bot
3ffab472ce
Merge pull request #4845 from jahrlin/user-bazelrc
support user.bazelrc
2022-02-11 10:27:01 +00:00
Ashley Davis
89bb5481cb
Increase margin of error in an otherwise unsound test
This test can easily fail on a heavily loaded machine, such as one
running many tests in parallel.

1. The afterFunc could be delayed _massively_ on a heavily loaded
   machine, such as one running a lot of tests in parallel.
2. Requiring an accuracy of 1ms seems like a flake waiting to happen
   (as it was in this case)
3. When we write code which uses this scheduler, we can't even
   safely assume the afterFunc will _ever_ be run, let alone run
   within a 1% margin of time error. As such I don't think this
   test is providing any value beyond a general sanity check.

By increasing the allowable delta massively, we keep this test as a
sanity check but basically remove the chance of a flake. The test
essentially becomes "does afterFunc work, generally?".

Also adds a check that the elapsed time is greater than the expected
time.

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2022-02-11 10:14:34 +00:00
Joakim Ahrlin
906f45beac support user.bazelrc
Signed-off-by: Joakim Ahrlin <joakim.ahrlin@gmail.com>
2022-02-11 10:41:30 +01:00
Ashley Davis
fc4f130755
Change handling of time in ctl integration tests
Two main changes:

1. Timezones

Because the tests were run in bazel or in CI environments, they always
ran in UTC, but the behaviour of ctl is based on local time, not UTC. We
show "not after" in the local timezone.

Now, we parse the "not after" time from the output so that its timezone
is respected and should pass on any developer laptop even outside of
bazel.

2. Created At

There was previously a pretty big regex for checking that "Created at"
was a valid timestamp. Now, we simply parse the timestamp using the Go
standard library to confirm that it's a valid RFC3339 timestamp.

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2022-02-10 15:29:51 +00:00
jetstack-bot
2c254545d7
Merge pull request #4813 from JoshVanL/controllers-post-issuance-additional-output-formats
Post Issuance Check: Certificate's AdditionalOutputFormats
2022-02-09 07:27:47 +00:00
joshvanl
4de248e883 Updates comments to read better
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-08 16:07:04 +00:00
jetstack-bot
bef0795301
Merge pull request #4833 from jakexks/validation
Relax the validation on the default Issuer Kind for certificate-shim
2022-02-08 15:23:46 +00:00
Jake Sanders
f225637e20
Relax the validation on the default Issuer Kind for certificate-shim
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2022-02-08 13:50:13 +00:00
joshvanl
23603775e1 Change import jetstack/cert-manager -> cert-manager/cert-manager
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-07 15:05:06 +00:00
joshvanl
19b68c9ba2 Update SecretTemplate comments on policy checks
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-07 15:02:51 +00:00
joshvanl
079f2b0fd9 Add AdditionalCertificateOutputFormats=true to FEATURE_GATES default
value in /devel/run-e2e.sh

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-07 14:43:25 +00:00
joshvanl
d5365af662 Adds e2e tests for additional output formats
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-07 14:43:25 +00:00
joshvanl
ab45d640ea Adds integration tests for additional output formats
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-07 14:42:04 +00:00
joshvanl
9ca869c2cf Add tests to secret manager for additional output formats
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-07 14:41:45 +00:00
joshvanl
fdf7743f21 Adds PostIssuanceChecks for Certificate's AdditionalOutputFormats
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-07 14:40:51 +00:00
joshvanl
c314fa5980 Adds comment for registered_feature_gates_for function
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-07 14:39:47 +00:00
joshvanl
0bba16e0f9 Adds empty feature set for cainjector. Parses feature gates in devel
script, and passes them on to each component

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-07 14:39:46 +00:00
jetstack-bot
c16105bffe
Merge pull request #4826 from SgtCoDFish/newpath
Add note about import paths to README
2022-02-07 10:13:48 +00:00
Ashley Davis
8d2149a5c9
add note about import paths to README
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2022-02-04 16:54:43 +00:00
jetstack-bot
b1180c59ad
Merge pull request #4587 from SgtCoDFish/bigrename
Rename import path
2022-02-03 11:56:12 +00:00
jetstack-bot
3c8eee34ae
Merge pull request #4815 from JoshVanL/controllers-certificates-issuing-secrets-manager-always-force
Always Force apply in issuing controller's secret manager
2022-02-02 15:40:40 +00:00
jetstack-bot
d16a79db13
Merge pull request #4793 from fvlaicu/change-route53-acme-challenge-record-creation
Use multivalue records instead of simple records
2022-02-02 12:18:39 +00:00
Ashley Davis
b084e5804c
fix violations of our coding conventions on import ordering
this is exposed by the rename when cert-manager internal imports are mixed in with
external imports

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2022-02-02 11:53:39 +00:00
Ashley Davis
3a055cc2f5
rename all uses of github.com/jetstack/cert-manager
This was done by running the following command twice:

 ```bash
 grep -Ri "github.com/jetstack/cert-manager" . | \
 cut -d":" -f1 | \
 sort | \
 uniq | \
 xargs sed -i
 "s/github.com\/jetstack\/cert-manager/github.com\/cert-manager\/cert-manager/"
 ```

Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2022-02-02 09:08:31 +00:00
jetstack-bot
ee8ec69fad
Merge pull request #4814 from JoshVanL/bug-webhook-additional-ouput-formats-feature
Bug: Fix Certificate's AdditionalOutputFormat in admission within Webhook
2022-02-01 18:06:39 +00:00
joshvanl
c737c3d9c6 Update secret manager test to no longer expect a non-force apply
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-01 18:04:42 +00:00
joshvanl
e5e3cf1fa2 Always Force apply in issuing controller's secret manager
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-01 17:57:22 +00:00
joshvanl
35fba365bf Update AdditionalOutputFormats comment to reflect addition of feature to
webhook set.

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-01 17:04:55 +00:00
joshvanl
8b219a45b2 Fix AdditationOutputFormat validation, and adds unit tests. Use correct
feature set

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-01 17:03:37 +00:00
joshvanl
1cf06889bf Add AdditionalCertificateOutputFormats feature to webhook set. Make
@joshvanl owner of feature in controller.

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-01 17:02:48 +00:00
joshvanl
83f738d665 Remove auditsinks permissions from ca-injector as it is no longer
supported

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-01-31 18:46:52 +00:00
jetstack-bot
ee2c4aacbb
Merge pull request #4773 from JoshVanL/controllers-user-agent
User Agents
2022-01-31 14:44:28 +00:00
joshvanl
4445f85d62 Update bazel deps
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-01-31 13:44:43 +00:00
joshvanl
364c02d36e Ensure RateLimiter is preserved across all built Contexts
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-01-31 13:38:45 +00:00
joshvanl
834e6bcb04 Set RESTConfig burst and QPS inside context factory so all clients
inherit these values

Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-01-31 11:34:09 +00:00
Florin Vlaicu
ff6b627401 use multivalue records instead of simple records to allow having multiple txt records for a domain.
Signed-off-by: Florin Vlaicu <19238716+fvlaicu@users.noreply.github.com>
2022-01-28 18:05:48 +02:00
joshvanl
fb6e0b9f00 Pass FieldManager down to issuing controller->secrets manager
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-01-27 13:56:29 +00:00
joshvanl
d6c34987ef Updates controller start with ControllerFactory
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-01-27 12:51:49 +00:00
joshvanl
1df5afc028 Update secret template e2e test for new issuing controller field manager
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-01-27 12:51:49 +00:00
joshvanl
07d8d4ee3c Pipes user agent down to acme clients
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-01-27 12:51:49 +00:00