weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Adds roundtrip tests for issuer and cluster issuer serialize

Browse Source 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
This commit is contained in:
joshvanl 2022-02-07 14:16:33 +00:00
parent 3e23b6fd8a
commit d1ffb0ad0d
3 changed files with 32 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
internal/controller/issuers/apply_test.go
View File

@ -17,6 +17,7 @@ limitations under the License.
package issuers
import (
"encoding/json"
"strconv"
"sync"
"testing"
@ -52,6 +53,11 @@ func Test_serializeApplyIssuerStatus(t *testing.T) {
assert.NoError(t, err)
assert.Regexp(t, expReg, string(issuerData))
// Test round trip preserves the status.
var rtIssuer cmapi.Issuer
assert.NoError(t, json.Unmarshal(issuerData, &rtIssuer))
assert.Equal(t, issuer.Status, rtIssuer.Status)
// String match on empty status.
issuer.Status = cmapi.IssuerStatus{}
issuerData, err = serializeApplyIssuerStatus(&issuer)
@ -95,6 +101,11 @@ func Test_serializeApplyClusterIssuerStatus(t *testing.T) {
assert.NoError(t, err)
assert.Regexp(t, expReg, string(issuerData))
// Test round trip preserves the status.
var rtIssuer cmapi.ClusterIssuer
assert.NoError(t, json.Unmarshal(issuerData, &rtIssuer))
assert.Equal(t, issuer.Status, rtIssuer.Status)
// String match on empty status.
issuer.Status = cmapi.IssuerStatus{}
issuerData, err = serializeApplyClusterIssuerStatus(&issuer)

34
test/integration/issuers/BUILD.bazel
View File

@ -1,21 +1,4 @@
load("@io_bazel_rules_go//go:def.bzl", "go_library")
go_library(
name = "go_default_library",
srcs = ["issuers.go"],
importpath = "github.com/jetstack/cert-manager/test/integration/issuers",
visibility = ["//visibility:public"],
deps = [
"//internal/controller/issuers:go_default_library",
"//pkg/apis/certmanager/v1:go_default_library",
"//pkg/apis/meta/v1:go_default_library",
"//pkg/util:go_default_library",
"//test/integration/framework:go_default_library",
"@com_github_stretchr_testify//assert:go_default_library",
"@io_k8s_api//core/v1:go_default_library",
"@io_k8s_apimachinery//pkg/apis/meta/v1:go_default_library",
],
)
load("@io_bazel_rules_go//go:def.bzl", "go_test")
filegroup(
name = "package-srcs",
@ -30,3 +13,18 @@ filegroup(
tags = ["automanaged"],
visibility = ["//visibility:public"],
)
go_test(
name = "go_default_test",
srcs = ["condition_list_type_test.go"],
deps = [
"//internal/controller/issuers:go_default_library",
"//pkg/apis/certmanager/v1:go_default_library",
"//pkg/apis/meta/v1:go_default_library",
"//pkg/util:go_default_library",
"//test/integration/framework:go_default_library",
"@com_github_stretchr_testify//assert:go_default_library",
"@io_k8s_api//core/v1:go_default_library",
"@io_k8s_apimachinery//pkg/apis/meta/v1:go_default_library",
],
)

10
test/integration/issuers/issuers.go → test/integration/issuers/condition_list_type_test.go
View File

@ -25,11 +25,11 @@ import (
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
internalissuers "github.com/jetstack/cert-manager/internal/controller/issuers"
cmapi "github.com/jetstack/cert-manager/pkg/apis/certmanager/v1"
cmmeta "github.com/jetstack/cert-manager/pkg/apis/meta/v1"
"github.com/jetstack/cert-manager/pkg/util"
"github.com/jetstack/cert-manager/test/integration/framework"
internalissuers "github.com/cert-manager/cert-manager/internal/controller/issuers"
cmapi "github.com/cert-manager/cert-manager/pkg/apis/certmanager/v1"
cmmeta "github.com/cert-manager/cert-manager/pkg/apis/meta/v1"
"github.com/cert-manager/cert-manager/pkg/util"
"github.com/cert-manager/cert-manager/test/integration/framework"
)
func Test_ConditionsListType_Issuers(t *testing.T) {