Commit Graph

404 Commits

Author SHA1 Message Date
Tim Ramlot
c58b08e7b7
pki match: remove return values that are always nil
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-07-02 13:38:35 +02:00
Yuedong Wu
df37eba376 fix API fields description for venafi tpp
Signed-off-by: Yuedong Wu <dwcn22@outlook.com>
2024-07-01 20:55:51 +08:00
cert-manager-prow[bot]
50abeda40d
Merge pull request #6987 from cbroglie/renew-before-pct
feat: Add renewBeforePercentage alternative to renewBefore
2024-07-01 09:45:23 +00:00
Christopher Broglie
0f74d7536e Add renewBeforePercentage alternative to renewBefore
Since the actual duration is unknown until a cert has been issued,
providing an absolute duration for renewBefore can result in accidental
renewal loops. The new renewBeforePercentage field computes the
effective renewBefore using the actual duration, allowing users to
better express intent while maintaining backwards compatibility.

Fixes #4423, resolves #5821

Signed-off-by: Christopher Broglie <cbroglie@cloudflare.com>
2024-06-29 21:18:15 -07:00
cert-manager-prow[bot]
837c6a1e06
Merge pull request #7036 from fidelity-contributions/feature/5514-venafi-issuer-ca-ref-support
Feature/5514 - Add SecretRef support for venafi TPP issuer CA Bundle
2024-06-24 14:18:20 +00:00
Tim Ramlot
9e649cc8f1
only retry when encountering a Vault non-InvalidData error
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-06-20 13:35:02 +02:00
cert-manager-prow[bot]
9f8707d0f8
Merge pull request #4330 from joshmue/vault_client_cert_auth
Add client certificate auth method for Vault issuer
2024-06-18 12:19:57 +00:00
Tim Ramlot
363a63ac96
Add client certificate authentication for Vault issuers
Co-authored-by: Maël Valais <mael@vls.dev>
Signed-off-by: Joshua Mühlfort <muehlfort@gonicus.de>
2024-06-17 09:16:26 +02:00
Tim Ramlot
e0cdfd37bf
introduce gen.CSRForCertificate and gen.CSRWithSignerForCertificate and use it to deduplicate test code
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-06-14 15:53:18 +02:00
cert-manager-prow[bot]
055f08d67e
Merge pull request #7015 from inteon/support_duration_string
Support duration strings in config API
2024-05-17 13:19:52 +00:00
cert-manager-prow[bot]
d04fecf112
Merge pull request #7014 from inteon/improve_config_validation
Improve config validation
2024-05-17 09:43:53 +00:00
Tim Ramlot
e51f4a46db
update CRD field comments
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-05-14 17:49:56 +02:00
Tim Ramlot
b4dc162156
Complete validation logic for config API and obtain 100% coverage for its tests.
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-05-14 17:31:37 +02:00
Tim Ramlot
60324bcb5e
Add support for duration values in "Go time.ParseDuration" format.
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-05-14 17:31:23 +02:00
Tim Ramlot
1aacfd826a
promote the LiteralCertificateSubject feature to Beta
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-05-14 17:25:28 +02:00
cert-manager-prow[bot]
ac287e1f26
Merge pull request #7013 from inteon/deduplicate_shared_config
Deduplicate shared config API structs
2024-05-14 14:28:50 +00:00
Tim Ramlot
cfe974b775
deduplicate shared config API structs
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-05-14 09:28:10 +02:00
pwhitehead
35571e014d refactor to use token request API
Signed-off-by: Paul Whitehead <pwhitehead@splunk.com>
2024-05-07 11:11:21 -06:00
Paul Whitehead
528428b31f support assumeRoleWithWebIdentity for Route53 issuer
Signed-off-by: Paul Whitehead <pwhitehead@splunk.com>

fix test signature
2024-05-07 11:10:17 -06:00
Tim Ramlot
52320fbeea
fix contextcheck linter
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-05-07 12:19:41 +02:00
Tim Ramlot
dd4f5f4e39
fix unparam linter
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-30 10:47:21 +02:00
Tim Ramlot
24e47ff364
fix predeclared linter
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-29 17:32:49 +02:00
Tim Ramlot
b86af60308
fix usestdlibvars linter
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-29 16:54:13 +02:00
Tim Ramlot
ae98ba806b
fix gocritic linter
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-29 15:50:47 +02:00
Tim Ramlot
042f59d283
fix unused linter
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-29 15:29:00 +02:00
Tim Ramlot
085136068a
fix misspell linter
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-29 15:21:07 +02:00
Tim Ramlot
a8b5178fc5
fix dupword linter
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-29 13:47:25 +02:00
Tim Ramlot
bdb8f6d70c
fix tagalign linter
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-29 13:47:25 +02:00
Tim Ramlot
9db044b232
fix gci linter
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-29 13:47:25 +02:00
cert-manager-prow[bot]
54feeece10
Merge pull request #6970 from erikgb/additional-formats-beta
Promote AdditionalCertificateOutputFormats feature gate to Beta
2024-04-29 07:42:36 +00:00
Erik Godding Boye
003c1b12e8
Promote AdditionalCertificateOutputFormats feature gate to Beta and enable by default
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
2024-04-28 17:29:35 +02:00
Erik Godding Boye
8f99f40cbb
Upgrade K8s dependencies to v0.30.0
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
2024-04-28 13:02:36 +02:00
cert-manager-prow[bot]
410b7a6ffb
Merge pull request #6963 from inteon/graduate_DisallowInsecureCSRUsageDefinition
Graduate 'DisallowInsecureCSRUsageDefinition' to GA (part 2)
2024-04-26 17:22:35 +00:00
cert-manager-prow[bot]
4fe21418f1
Merge pull request #6961 from ThatsMrTalbot/feat/graduate-gateway-api-to-beta
feat: graduate gateway-api to beta and enable by default
2024-04-26 14:27:34 +00:00
Tim Ramlot
38cd0accdb
graduate 'DisallowInsecureCSRUsageDefinition' to GA
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-26 16:14:31 +02:00
cert-manager-prow[bot]
76153b3bf2
Merge pull request #6949 from findnature/master
chore: remove repetitive words
2024-04-26 03:51:33 +00:00
findnature
f9f2e1cd8f chore: remove repetitive words
Signed-off-by: findnature <cricis@aliyun.com>
2024-04-26 10:00:43 +08:00
Adam Talbot
a7f089b64c feat: graduate gateway-api to beta and enable by default
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
2024-04-25 17:05:58 +01:00
Tim Ramlot
20fa3169bf
Merge pull request #6927 from yj-yoo/remove_deprecated_function
Graduate 'DisallowInsecureCSRUsageDefinition' to GA
2024-04-24 15:23:42 +01:00
Sankalp Yengaldas
adc7cd0f06 add testcases and generate deepcopy methods
Signed-off-by: Sankalp Yengaldas <sankalp.yb@fmr.com>
2024-04-24 10:14:31 -04:00
Sankalp Yengaldas
660be1d278 add caBundleSecretRef field support to internal APIs
Signed-off-by: Sankalp Yengaldas <sankalp.yb@fmr.com>
2024-04-24 02:31:09 -04:00
Tim Ramlot
8d2cb0c336
Merge pull request #6889 from jsnctl/6817-api-defaults-tests
feat: Adding API defaults unit test + testfile fixture
2024-04-23 13:37:46 +01:00
Tim Ramlot
a26e2dc21e
cleanup code
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2024-04-23 13:02:55 +02:00
Youngjun
d2988a906a refectoring: remove deprecated function
- remove deprecated function
- comment update beta to ga (and version)

Signed-off-by: Youngjun <yj.yoo@okestro.com>
2024-04-22 22:57:52 +09:00
Youngjun
237dfd9f0d refectoring: remove unnecessary code
Signed-off-by: Youngjun <yj.yoo@okestro.com>
2024-04-22 14:24:59 +09:00
Jason Costello
610a066fef Adding missing boilerplate
Signed-off-by: Jason Costello <jason@jsnc.tl>
2024-04-21 15:12:02 -04:00
Jason Costello
b363fd9b3f Applying API default tests to rest of configuration modules
Signed-off-by: Jason Costello <jason@jsnc.tl>
2024-04-21 09:15:38 -04:00
Jason Costello
046027a556 Merge branch 'master' into 6817-api-defaults-tests
Signed-off-by: Jason Costello <jason@jsnc.tl>
2024-04-20 16:07:34 -04:00
Ashley Davis
828b8f6ce9
improve error message for common error when configuring external issuers
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
2024-04-19 15:08:40 +01:00
Ashley Davis
61710e3c55
add explicit test of external issuers
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
2024-04-18 13:14:21 +01:00