Commit Graph

8214 Commits

Author SHA1 Message Date
Mr Talbot
b7b8f07f55 Add @ThatsMrTalbot to OWNERS as reviewer
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
2023-12-21 11:02:33 +00:00
jetstack-bot
ebb955f3f0
Merge pull request #6565 from ThatsMrTalbot/fix/flag-validation-not-called
fix: validation functions are not called anywhere
2023-12-21 09:11:11 +00:00
Adam Talbot
59184de02f test: add tests for config validation functions
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
2023-12-21 08:58:02 +00:00
jetstack-bot
d9252716da
Merge pull request #6562 from ThatsMrTalbot/fix/normalise-install-flags
fix: normalise install flags to match other commands
2023-12-21 08:37:11 +00:00
jetstack-bot
c7714e65f0
Merge pull request #6551 from wallrj/gosec-601
Fix gosec G601: Implicit memory aliasing of items from a range statement
2023-12-20 18:21:37 +00:00
Tim Ramlot
0dabd1f008
refactor code, deduplicating init logic across install and uninstall
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-20 18:54:01 +01:00
Richard Wall
4de9e956e5 Fix gosec G601: Implicit memory aliasing of items from a range statement
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2023-12-20 17:25:41 +00:00
Richard Wall
3bed23f3f5 Enable the linting of _test.go files too
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2023-12-20 16:28:20 +00:00
Adam Talbot
4e02058cf3 fix: validation functions are not called anywhere
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
2023-12-20 15:49:18 +00:00
Tim Ramlot
fb381a6c3f
Update cmd/ctl/pkg/uninstall/uninstall.go
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-20 16:46:48 +01:00
Adam Talbot
6e83949f64 fix: normalise install flags to match other commands
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
2023-12-20 15:01:28 +00:00
jetstack-bot
a10d81be5d
Merge pull request #6559 from ThatsMrTalbot/feat/gateway-api-v1
Update gateway-api to v1
2023-12-19 10:45:15 +00:00
Adam Talbot
247a034116 feat: update gateway api to v1
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
2023-12-18 21:00:42 +00:00
jetstack-bot
529d8a74a6
Merge pull request #6552 from allenmunC1/leaf-duration
Add flag and field to customize leaf duration on dynamic certificates
2023-12-14 16:02:38 +00:00
Richard Wall
260dc11c2d Show all issues
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2023-12-14 12:10:20 +00:00
Richard Wall
09211dabdf Enable gosec G601
https://github.com/securego/gosec#available-rules

Signed-off-by: Richard Wall <richard.wall@venafi.com>
2023-12-14 12:10:20 +00:00
jetstack-bot
cf8421e13f
Merge pull request #6556 from SgtCoDFish/golangci-lint-make
Add target + installation for golangci-lint
2023-12-14 09:37:13 +00:00
Allen Mun
9b09aa87a7 Add flag and field to customize leaf duration on dynamic certificates
Signed-off-by: Allen Mun <allen.mun@capitalone.com>
2023-12-13 15:45:52 -05:00
Ashley Davis
dd61635f3b
add target + installation for golangci-lint
This lets users locally run the same commands that are run in CI

Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
2023-12-13 19:58:01 +00:00
jetstack-bot
7b36cfa808
Merge pull request #6555 from SgtCoDFish/fixlicenses
Fix licenses file
2023-12-13 15:19:12 +00:00
Ashley Davis
25298b75c7
fix licenses file
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
2023-12-13 14:22:15 +00:00
jetstack-bot
8da699a735
Merge pull request #6542 from tanujd11/fix/name-constraints-csr-structure
fix: structure of nameconstraint in CSR
2023-12-12 16:07:16 +00:00
jetstack-bot
4ae25789a2
Merge pull request #6537 from wallrj/golangci-lint
Add the golangci-lint GitHub action
2023-12-12 15:22:03 +00:00
Tim Ramlot
849b6bda9e
add tests & final cleanup
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-12 15:57:07 +01:00
Tim Ramlot
cfaf3f338e
cleanup code
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-12 13:47:55 +01:00
tanujd11
da84cf5b88 fix: imports
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-12 17:10:32 +05:30
tanujd11
652feb50cc Addressed review comments
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-12 17:05:33 +05:30
tanujd11
5f0a715863 add nameConstraints from openssl
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-12 00:40:45 +05:30
jetstack-bot
37e425c4da
Merge pull request #6545 from wallrj/bump-go
Bump Go to 1.21.5
2023-12-11 18:05:47 +00:00
Richard Wall
f3a91ac8aa Bump Go to 1.21.5
- go1.21.4 (released 2023-11-07) includes security fixes to the path/filepath package, as well as bug fixes to the linker, the runtime, the compiler, and the go/types, net/http, and runtime/cgo packages.
- go1.21.5 (released 2023-12-05) includes security fixes to the go command, and the net/http and path/filepath packages, as well as bug fixes to the compiler, the go command, the runtime, and the crypto/rand, net, os, and syscall packages.

Signed-off-by: Richard Wall <richard.wall@venafi.com>
2023-12-11 17:27:09 +00:00
tanujd11
bc75f8488d fix: structure of nameconstraint in CSR
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-11 18:00:15 +05:30
jetstack-bot
e8d279025c
Merge pull request #6500 from tanujd11/feature/ca-cert-name-constraint
feature: added name constraints in certs with isCA enabled
2023-12-08 12:18:42 +00:00
tanujd11
a29a5913d0 addressed review comments
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-07 23:42:35 +05:30
Richard Wall
70cf0d200b Add the golangci-lint GitHub action
Initially we enable only the gosec linter and only check G112
because that has been addressed in #6534.

Signed-off-by: Richard Wall <richard.wall@venafi.com>
2023-12-07 18:03:04 +00:00
tanujd11
28ca4312b3 fix: additional review comments
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-07 22:30:31 +05:30
tanujd11
8d362439a8 fix UTs
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-07 22:30:31 +05:30
tanujd11
84d7dd4aed Addressed review comments
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-07 22:30:31 +05:30
tanujd11
d1b3e5ca83 Move critical from NameConstraintItem to NameConstraint and remove validateNameConstraints
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-07 22:30:29 +05:30
tanujd11
adb9311f56 validate name constraint before signing CSR
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-07 22:29:45 +05:30
tanujd11
50d84c1bbc nits: added new line at EOF and comment fix
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-07 22:27:42 +05:30
tanujd11
589030dec1 feature: added name constraints
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-07 22:27:31 +05:30
jetstack-bot
e7e3e5f4de
Merge pull request #6534 from wallrj/server-timeout
Mitigate potential Slowloris attacks by setting ReadHeaderTimeout in all http.Server instances
2023-12-07 13:28:05 +01:00
jetstack-bot
5484a92df8
Merge pull request #6535 from inteon/cleanup_generate_csr
Refactor GenerateCSR and deprecate the helper functions
2023-12-07 13:15:05 +01:00
Richard Wall
8bed166858 Add ReadHeaderTimeout to all http.Server where that setting is missing
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2023-12-07 11:42:22 +00:00
Tim Ramlot
767764d598
refactor GenerateCSR and deprecated the helper functions
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-06 18:16:19 +01:00
jetstack-bot
4209de2371
Merge pull request #6533 from inteon/cleanup_literal_subject_validation
BUGFIX: LiteralCertificateSubject webhook logic
2023-12-06 16:24:44 +01:00
Tim Ramlot
c5d7f15aa1
LiteralCertificateSubject: improve webhook logic
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-06 16:09:06 +01:00
jetstack-bot
40951826ab
Merge pull request #6531 from inteon/rename_fields_internal_api
Rename internal API fields to match the field names in the public API
2023-12-06 14:46:43 +01:00
Tim Ramlot
25eec9514a
rename internal API fields to match the fieldnames in the public API
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-06 13:59:59 +01:00
jetstack-bot
202a80e218
Merge pull request #6519 from JoeNorth/master
Update AWS SDK for Go to 1.48.7
2023-11-29 15:12:49 +01:00