weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix: validation functions are not called anywhere

Browse Source 
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
This commit is contained in:
Adam Talbot 2023-12-20 14:59:00 +00:00
parent a10d81be5d
commit 4e02058cf3
3 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
cmd/cainjector/app/cainjector.go
View File

@ -27,6 +27,7 @@ import (
"github.com/cert-manager/cert-manager/cainjector-binary/app/options"
config "github.com/cert-manager/cert-manager/internal/apis/config/cainjector"
"github.com/cert-manager/cert-manager/internal/apis/config/cainjector/validation"
cmdutil "github.com/cert-manager/cert-manager/internal/cmd/util"
cainjectorconfigfile "github.com/cert-manager/cert-manager/pkg/cainjector/configfile"
@ -88,6 +89,10 @@ servers and webhook servers.`,
return err
}
if err := validation.ValidateCAInjectorConfiguration(cainjectorConfig); err != nil {
return fmt.Errorf("error validating flags: %w", err)
}
if err := logf.ValidateAndApplyAsField(&cainjectorConfig.Logging, field.NewPath("logging")); err != nil {
return fmt.Errorf("failed to validate cainjector logging flags: %w", err)
}

5
cmd/controller/app/start.go
View File

@ -27,6 +27,7 @@ import (
"github.com/cert-manager/cert-manager/controller-binary/app/options"
config "github.com/cert-manager/cert-manager/internal/apis/config/controller"
"github.com/cert-manager/cert-manager/internal/apis/config/controller/validation"
cmdutil "github.com/cert-manager/cert-manager/internal/cmd/util"
_ "github.com/cert-manager/cert-manager/pkg/controller/acmechallenges"
@ -99,6 +100,10 @@ to renew certificates at an appropriate time before expiry.`,
return err
}
if err := validation.ValidateControllerConfiguration(controllerConfig); err != nil {
return fmt.Errorf("error validating flags: %w", err)
}
if err := logf.ValidateAndApplyAsField(&controllerConfig.Logging, field.NewPath("logging")); err != nil {
return fmt.Errorf("failed to validate controller logging flags: %w", err)
}

5
cmd/webhook/app/webhook.go
View File

@ -26,6 +26,7 @@ import (
"k8s.io/apimachinery/pkg/util/validation/field"
config "github.com/cert-manager/cert-manager/internal/apis/config/webhook"
"github.com/cert-manager/cert-manager/internal/apis/config/webhook/validation"
cmdutil "github.com/cert-manager/cert-manager/internal/cmd/util"
cmwebhook "github.com/cert-manager/cert-manager/internal/webhook"
logf "github.com/cert-manager/cert-manager/pkg/logs"
@ -94,6 +95,10 @@ functionality for cert-manager.`,
return err
}
if err := validation.ValidateWebhookConfiguration(webhookConfig); err != nil {
return fmt.Errorf("error validating flags: %w", err)
}
if err := logf.ValidateAndApplyAsField(&webhookConfig.Logging, field.NewPath("logging")); err != nil {
return fmt.Errorf("failed to validate webhook logging flags: %w", err)
}