Maël Valais
75b49ab641
make: fix message when CMREL_KEY isn't set
...
Double quotes are not interpreted by make, which meant that the variable
CMREL_KEY was set to '""' and was never empty, which means the $(error
...) block was never interpreted.
Signed-off-by: Maël Valais <mael@vls.dev>
2022-02-15 11:50:36 +01:00
jetstack-bot
0860a4141b
Merge pull request #4847 from akamac/patch-1
...
add name to the exposed metrics port
2022-02-14 14:02:52 +00:00
jetstack-bot
ad4264b6ec
Merge pull request #4841 from irbekrm/remove_annotation
...
Removes cainjector annotations from CRDs
2022-02-14 10:48:52 +00:00
jetstack-bot
2f4f8aea50
Merge pull request #4848 from JoshVanL/test-e2e-certificates-aof-check-feature
...
Adds check in additionaloutputformat e2e test suite for ServerSideApply feature gate
2022-02-14 10:11:52 +00:00
jetstack-bot
12a2148df3
Merge pull request #4794 from JoshVanL/controllers-server-side-apply-issuers
...
Server Side Apply: Adds support for [Cluster]Issuer controller to use SSA with Feature Gate
2022-02-11 19:37:01 +00:00
jetstack-bot
e3fd107481
Merge pull request #4849 from JoshVanL/devel-addon-cert-manager-feature-ssa
...
Adds ServerSideApply as a feature gate for the controller
2022-02-11 18:05:01 +00:00
joshvanl
fd747b42b9
Adds log output for what feature gates are enabled when installing from
...
devel
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 17:31:10 +00:00
joshvanl
413993f33a
Adds ServerSideApply as a feature gate for the controller
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 17:12:32 +00:00
joshvanl
82346f9027
Adds check in additionaloutputformat e2e test suite for ServerSideApply
...
which is required to be enabled
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 17:07:25 +00:00
jetstack-bot
8781cfd14e
Merge pull request #4777 from JoshVanL/controller-server-side-apply-certificates
...
Server Side Apply: Adds support for Certificates controller to use SSA with Feature Gate
2022-02-11 16:54:01 +00:00
joshvanl
f73d6584fb
Fix copyright year. Remove carrot from OWNERS string match
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:26:56 +00:00
joshvanl
d1ffb0ad0d
Adds roundtrip tests for issuer and cluster issuer serialize
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:26:56 +00:00
joshvanl
3e23b6fd8a
Adds patch permissions to cert-manager controller for issuers and
...
clusterissuers
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:26:56 +00:00
joshvanl
5f1249efe9
Adds issuer and cluster issuer integration tests to ensure mapped
...
conditions
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:26:56 +00:00
joshvanl
085b2bf34b
Updates issuer and cluster issuer controllers to optionally user server
...
side apply
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:26:56 +00:00
joshvanl
5c37326e36
Adds issuer apply helper
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:26:56 +00:00
joshvanl
49108a0278
Adds list map type to Conditions for both Issuers and Cluster Issuers
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:26:56 +00:00
joshvanl
593ea18341
Remove carrot from OWNERS file match string
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:18:44 +00:00
joshvanl
9946c84760
Fix NewController signature in certificates integration test
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:17:47 +00:00
joshvanl
4dc6c957d4
Adds review comments
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:15:57 +00:00
joshvanl
e31070a68f
Fix list map type tag for internal Certificate API definitions
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:15:57 +00:00
joshvanl
6b3cde9327
Fix apply[_test].go package names
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:15:57 +00:00
joshvanl
067863f83a
Revert issuing integration test to again check for Issuing condition
...
being removed
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:15:57 +00:00
joshvanl
37775615ff
Use ApplyStatus in all Certificates controllers. When ServerSideApply
...
enabled, set Issuing condition to False instead of removing it
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:15:57 +00:00
joshvanl
f4f3ab22e1
Adds shared internal controller certificates apply status func
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:15:57 +00:00
joshvanl
a8909f9b91
Update integration tests for passing field manager. Add integration
...
tests for certificate condition field open api tags
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:15:56 +00:00
joshvanl
36955b773f
Adds ServerSideApply feature gate to enabled to devel install
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:14:31 +00:00
joshvanl
23ba58b008
Update CRD for field labels. Adds patch rbac to Certificates for
...
cert-manager controller
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:14:31 +00:00
joshvanl
2417132b3c
Adds ServerSideApply feature gate
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:14:31 +00:00
joshvanl
bdb4954c25
Adds updateOrApply to certificates controllers to optionally Apply
...
certificate based on feature gate
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:14:31 +00:00
joshvanl
279a8ede99
Adds listType=map and listMapKey=type to Certificate Status Conditions
...
field
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-11 16:14:31 +00:00
Alexey Miasoedov
c37e0b9b93
add name to the exposed metrics port
...
Signed-off-by: Alexey Miasoedov <alexey.miasoedov@gmail.com>
2022-02-11 18:37:09 +03:00
jetstack-bot
07c665e001
Merge pull request #4842 from SgtCoDFish/ctlintegrationtime
...
Change handling of time in ctl integration tests
2022-02-11 14:33:01 +00:00
jetstack-bot
9ff7568f4e
Merge pull request #4809 from JoshVanL/ca-injector-remove-auditsinks-permissions
...
Remove auditsinks permissions from ca-injector as it is no longer supported
2022-02-11 13:56:01 +00:00
jetstack-bot
4f11cc27dd
Merge pull request #4822 from JoshVanL/devel-feature-gates-parse
...
Parse and distribute feature gates in devel script
2022-02-11 13:19:01 +00:00
jetstack-bot
0bee3ec8f2
Merge pull request #4843 from SgtCoDFish/unsoundsched
...
Increase margin of error in an otherwise unsound test
2022-02-11 12:10:01 +00:00
jetstack-bot
3ffab472ce
Merge pull request #4845 from jahrlin/user-bazelrc
...
support user.bazelrc
2022-02-11 10:27:01 +00:00
Ashley Davis
89bb5481cb
Increase margin of error in an otherwise unsound test
...
This test can easily fail on a heavily loaded machine, such as one
running many tests in parallel.
1. The afterFunc could be delayed _massively_ on a heavily loaded
machine, such as one running a lot of tests in parallel.
2. Requiring an accuracy of 1ms seems like a flake waiting to happen
(as it was in this case)
3. When we write code which uses this scheduler, we can't even
safely assume the afterFunc will _ever_ be run, let alone run
within a 1% margin of time error. As such I don't think this
test is providing any value beyond a general sanity check.
By increasing the allowable delta massively, we keep this test as a
sanity check but basically remove the chance of a flake. The test
essentially becomes "does afterFunc work, generally?".
Also adds a check that the elapsed time is greater than the expected
time.
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2022-02-11 10:14:34 +00:00
Joakim Ahrlin
906f45beac
support user.bazelrc
...
Signed-off-by: Joakim Ahrlin <joakim.ahrlin@gmail.com>
2022-02-11 10:41:30 +01:00
Ashley Davis
fc4f130755
Change handling of time in ctl integration tests
...
Two main changes:
1. Timezones
Because the tests were run in bazel or in CI environments, they always
ran in UTC, but the behaviour of ctl is based on local time, not UTC. We
show "not after" in the local timezone.
Now, we parse the "not after" time from the output so that its timezone
is respected and should pass on any developer laptop even outside of
bazel.
2. Created At
There was previously a pretty big regex for checking that "Created at"
was a valid timestamp. Now, we simply parse the timestamp using the Go
standard library to confirm that it's a valid RFC3339 timestamp.
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2022-02-10 15:29:51 +00:00
irbekrm
5fd80d6ad3
Removes cainjector annotations from CRDs
...
As we're no longer using cainjector to inject CA bundles to those CRDs
Signed-off-by: irbekrm <irbekrm@gmail.com>
2022-02-10 13:43:06 +00:00
jetstack-bot
2c254545d7
Merge pull request #4813 from JoshVanL/controllers-post-issuance-additional-output-formats
...
Post Issuance Check: Certificate's AdditionalOutputFormats
2022-02-09 07:27:47 +00:00
joshvanl
4de248e883
Updates comments to read better
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-08 16:07:04 +00:00
jetstack-bot
bef0795301
Merge pull request #4833 from jakexks/validation
...
Relax the validation on the default Issuer Kind for certificate-shim
2022-02-08 15:23:46 +00:00
Jake Sanders
f225637e20
Relax the validation on the default Issuer Kind for certificate-shim
...
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
2022-02-08 13:50:13 +00:00
joshvanl
23603775e1
Change import jetstack/cert-manager -> cert-manager/cert-manager
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-07 15:05:06 +00:00
joshvanl
19b68c9ba2
Update SecretTemplate comments on policy checks
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-07 15:02:51 +00:00
joshvanl
079f2b0fd9
Add AdditionalCertificateOutputFormats=true to FEATURE_GATES default
...
value in /devel/run-e2e.sh
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-07 14:43:25 +00:00
joshvanl
d5365af662
Adds e2e tests for additional output formats
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-07 14:43:25 +00:00
joshvanl
ab45d640ea
Adds integration tests for additional output formats
...
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
2022-02-07 14:42:04 +00:00