Ashley Davis
29f167b3cf
further clarifications and updates to the proliferation design doc
...
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2023-06-16 09:03:22 +01:00
jetstack-bot
b954456289
Merge pull request #6094 from SgtCoDFish/proliferation_3
...
Attempt to clarify in short the modules proliferation design
2023-06-15 10:09:22 +02:00
jetstack-bot
2d01fbecac
Merge pull request #6147 from inteon/fix_wrong_annotations
...
BUGFIX: issuer-ref and certificate-name annotations are incorrectly updated on Secrets
2023-06-14 16:44:21 +02:00
Tim Ramlot
fe4f4e4aa6
re-add TODO comment and make the message more clear
...
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-06-14 14:51:39 +02:00
Tim Ramlot
9c9e833c5a
add TODO comment that explains that we don't understand the reason for the current behaviour
...
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-06-14 14:51:07 +02:00
Tim Ramlot
3aa7b82e43
Update internal/controller/certificates/policies/checks.go
...
Co-authored-by: EDDIE-DAV <136573637+EDDIE-DAV@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-06-14 10:19:52 +01:00
Tim Ramlot
8ddf016b00
fix a bug that caused the issuer-ref and certificate-name annotations on Secrets to be correct when being updated.
...
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-06-13 16:54:32 +02:00
jetstack-bot
76a683d1d6
Merge pull request #6144 from schrodit/rm-servicelinks-helm
...
Disable service link in helm chart deployments
2023-06-12 16:04:17 +02:00
schrodit
a3c6261c38
disable service links on status api job
...
Signed-off-by: schrodit <mail@timschrodi.tech>
2023-06-12 14:09:36 +02:00
schrodit
c70be0a28b
Disable service links in helm charts
...
Signed-off-by: schrodit <mail@timschrodi.tech>
2023-06-12 13:33:55 +02:00
jetstack-bot
81c8ae8ff5
Merge pull request #6143 from schrodit/remove-servicelinks
...
Remove service links from http solver pod
2023-06-12 10:13:17 +02:00
schrodit
53a5a95d9f
Add enableServiceLink to test pod definition
...
Signed-off-by: schrodit <mail@timschrodi.tech>
2023-06-12 09:54:37 +02:00
schrodit
c9559882c4
Remove service links from http solver pod
...
Signed-off-by: schrodit <mail@timschrodi.tech>
2023-06-12 09:26:22 +02:00
jetstack-bot
c035090430
Merge pull request #6135 from cloud-native-team/master
...
fix function name in comments
2023-06-07 15:18:52 +02:00
cui fliter
4723347260
fix function name in comments
...
Signed-off-by: cui fliter <imcusg@gmail.com>
2023-06-07 17:17:07 +08:00
jetstack-bot
f8940ab5c4
Merge pull request #6125 from irbekrm/explain_fao
...
Document what fao stands for in the controller.cert-manager.io/fao label
2023-06-06 14:09:45 +02:00
jetstack-bot
7f519b3244
Merge pull request #6088 from cypres/master
...
issuer: acme: clouddns: Fix race condition
2023-06-02 19:14:58 +02:00
jetstack-bot
89d05fc149
Merge pull request #6126 from SgtCoDFish/basebump
...
Bump base images with make update-base-images
2023-06-02 15:41:58 +02:00
Ashley Davis
f30cd9228c
bump base images with make update-base-images
...
see #4033
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2023-06-02 14:31:38 +01:00
irbekrm
f4dc243b77
Document what fao stands for in the controller.cert-manager.io/fao label
...
Signed-off-by: irbekrm <irbekrm@gmail.com>
2023-06-02 13:45:10 +01:00
Hans Arnholm
501581ad06
issuer: acme: clouddns: Only clean up own records
...
If running multiple certmanagers they can race against each other
Signed-off-by: Hans Arnholm <hans@arnholm.dk>
2023-06-01 10:15:54 +02:00
jetstack-bot
2fb9e61c6e
Merge pull request #6109 from inteon/bugfix_api_check_poll_once
...
BUGFIX: `cmctl check api --wait 0` should still check the API once
2023-05-30 14:26:00 +01:00
Tim Ramlot
ced9f2bce0
if wait is set to 0, we still want to check the API once
...
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-05-30 15:08:02 +02:00
jetstack-bot
c5e6bf39d6
Merge pull request #6054 from inteon/correct_versions
...
Use Version 3 for *x509.Certificate
2023-05-26 13:57:32 +01:00
Ashley Davis
5bfd3078ca
add note about workspaces
...
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2023-05-26 12:00:54 +01:00
Ashley Davis
cc89050c02
fix double indented dashes for github markdown
...
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2023-05-26 11:55:42 +01:00
jetstack-bot
ba3ed3ebe5
Merge pull request #6098 from lucacome/bump-controller-runtime
...
Bump sigs.k8s.io/controller-runtime to v0.15.0
2023-05-24 12:49:22 +01:00
jetstack-bot
d214c30a39
Merge pull request #6093 from irbekrm/fix_webhook_flags
...
Fix webhook feature gate
2023-05-24 11:29:23 +01:00
Tim Ramlot
55ebaa31b5
fix typo
...
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-05-24 12:19:22 +02:00
Ashley Davis
07cd2e3782
review suggestion
...
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2023-05-24 09:34:30 +01:00
Luca Comellini
8a5704635a
Bump sigs.k8s.io/controller-runtime to v0.15.0
...
Signed-off-by: Luca Comellini <luca.com@gmail.com>
2023-05-23 17:34:28 -07:00
irbekrm
acf07419f5
Fix a bug in helm chart where webhook had controller feature gates passed
...
This will break anyone who relied on featureGates field to pass feature gates to webhook- they will need to use the new webhook.featureGates field
Signed-off-by: irbekrm <irbekrm@gmail.com>
2023-05-23 12:44:31 +01:00
Ashley Davis
f1b499f578
attempt to clarify in short the modules proliferation design
...
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
2023-05-23 12:11:07 +01:00
irbekrm
8a34cbc0a0
Adds some warnings for folks to not import feature gates into shared code
...
Really we should restructure this to remove the possibility of accidentally overwriting other component's feature gates
Signed-off-by: irbekrm <irbekrm@gmail.com>
2023-05-23 12:02:55 +01:00
irbekrm
b1a59164e0
Don't import controller's feature gate setup into a shared library
...
To prevent controller's feature gates from overwriting other component's feature gates
Signed-off-by: irbekrm <irbekrm@gmail.com>
2023-05-23 12:01:30 +01:00
jetstack-bot
5c0722dccb
Merge pull request #6085 from irbekrm/disable_apf_for_webhook
...
Disable APF for webhook extension apiserver
2023-05-22 13:41:27 +01:00
irbekrm
524998abdf
Don't run API Priority and Fairness controller in webhook extension apiserver
...
Because it is not needed and can cause issues with older versions of kube
Signed-off-by: irbekrm <irbekrm@gmail.com>
2023-05-22 12:53:15 +01:00
jetstack-bot
7ccb323549
Merge pull request #6084 from irbekrm/bump_cm_in_cli
...
Updates cmctl to point at latest cert-manager
2023-05-19 14:45:55 +01:00
irbekrm
132ab27cec
Updates cmctl to point at latest cert-manager
...
Signed-off-by: irbekrm <irbekrm@gmail.com>
2023-05-19 14:31:18 +01:00
jetstack-bot
d185972237
Merge pull request #6077 from lucacome/bump-k8s.io-deps
...
Bump k8s.io dependencies
2023-05-19 10:57:55 +01:00
Luca Comellini
bf6bbb19de
Bump k8s.io dependencies
...
Signed-off-by: Luca Comellini <luca.com@gmail.com>
2023-05-18 21:55:47 -07:00
jetstack-bot
529497f150
Merge pull request #6034 from gdvalle/patch-1
...
apis/acme/v1: ACMEIssuer: set omitempty on optional field
2023-05-18 11:14:39 +01:00
jetstack-bot
1be0238ec9
Merge pull request #6078 from irbekrm/kubebuilder_shas
...
Kubebuilder shas
2023-05-18 10:54:39 +01:00
irbekrm
f2b97a5dd3
Bumps kubebuilder SHAs
...
As the kubebuilder tools for 1.27.1 have been repushed
Signed-off-by: irbekrm <irbekrm@gmail.com>
2023-05-18 10:19:42 +01:00
jetstack-bot
022292832f
Merge pull request #6032 from inteon/fix_acme_bugs
...
Fix small bugs and make small improvements in ACME code
2023-05-12 15:19:41 +01:00
jetstack-bot
691474bc61
Merge pull request #6068 from cert-manager/docker_upgrade
...
Upgrade github.com/docker/distribution v2.8.2+incompatible
2023-05-12 14:48:41 +01:00
Tim Ramlot
0284d20a74
upgrade all our docker deps
...
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-05-12 15:32:09 +02:00
jetstack-bot
897329fd76
Merge pull request #6066 from inteon/fix_gomod
...
Fix cmctl go.mod: make it importable & make it go installable
2023-05-12 14:00:41 +01:00
Tim Ramlot
d14ffca049
replace go.mod replace statements with require statements
...
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-05-12 14:38:32 +02:00
Tim Ramlot
2ba39e9ebc
allow importing the ctl cmd package
...
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-05-12 14:13:04 +02:00