weiguoqiang/cert-manager
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Merge pull request #6085 from irbekrm/disable_apf_for_webhook

Browse Source 
Disable APF for webhook extension apiserver
This commit is contained in:
jetstack-bot 2023-05-22 13:41:27 +01:00 committed by GitHub
commit 5c0722dccb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/acme/webhook/cmd/server/start.go
View File

@ -23,8 +23,11 @@ import (
"github.com/spf13/cobra"
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
"k8s.io/apiserver/pkg/features"
genericapiserver "k8s.io/apiserver/pkg/server"
genericoptions "k8s.io/apiserver/pkg/server/options"
utilfeature "k8s.io/apiserver/pkg/util/feature"
"k8s.io/component-base/logs"
"github.com/cert-manager/cert-manager/pkg/acme/webhook"
@ -135,6 +138,13 @@ func (o WebhookServerOptions) Config() (*apiserver.Config, error) {
// RunWebhookServer creates a new apiserver, registers an API Group for each of
// the configured solvers and runs the new apiserver.
func (o WebhookServerOptions) RunWebhookServer(stopCh <-chan struct{}) error {
// extension apiserver does not need priority and fairness.
// TODO: this is a short term fix; when APF graduates we will need to
// find another way. Alternatives are either to find a way how to
// disable APF controller (without the feature gate), run the controller
// (create RBAC and ensure required resources are installed) or do some
// bigger refactor of this project that could solve the problem
utilruntime.Must(utilfeature.DefaultMutableFeatureGate.Set(fmt.Sprintf("%s=false", features.APIPriorityAndFairness)))
config, err := o.Config()
if err != nil {
return err