Commit Graph

8226 Commits

Author SHA1 Message Date
Richard Wall
0ea258327d Fix gosec G505
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-01-02 10:10:11 +00:00
Richard Wall
fffb70c25f Enable gosec G505
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2024-01-02 09:26:53 +00:00
jetstack-bot
5615de61ee
Merge pull request #6563 from inteon/hide_deprecated_flags
Hide deprecated CLI flags
2023-12-27 09:59:59 +00:00
jetstack-bot
5e09dd3059
Merge pull request #6561 from inteon/parse_certificate_chain
Certificate chain parsing
2023-12-27 09:59:53 +00:00
jetstack-bot
9449565640
Merge pull request #6571 from pevidex/fix-validation-webhook-error-message
Fix validation webhook error message
2023-12-25 10:04:17 +00:00
pevidex
5ce1cfec9c test: add missing test for ed25519 key algorithm
Signed-off-by: pevidex <ricardojosexavier@hotmail.com>
2023-12-25 01:26:40 +00:00
pevidex
8a516503de fix: mention ed25519 on validation webhook error when key is not valid
Signed-off-by: pevidex <ricardojosexavier@hotmail.com>
2023-12-25 01:24:59 +00:00
jetstack-bot
ee968864c7
Merge pull request #6566 from ThatsMrTalbot/patch-1
Add @ThatsMrTalbot to OWNERS as reviewer
2023-12-21 14:33:12 +00:00
Mr Talbot
b7b8f07f55 Add @ThatsMrTalbot to OWNERS as reviewer
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
2023-12-21 11:02:33 +00:00
jetstack-bot
ebb955f3f0
Merge pull request #6565 from ThatsMrTalbot/fix/flag-validation-not-called
fix: validation functions are not called anywhere
2023-12-21 09:11:11 +00:00
Adam Talbot
59184de02f test: add tests for config validation functions
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
2023-12-21 08:58:02 +00:00
jetstack-bot
d9252716da
Merge pull request #6562 from ThatsMrTalbot/fix/normalise-install-flags
fix: normalise install flags to match other commands
2023-12-21 08:37:11 +00:00
jetstack-bot
c7714e65f0
Merge pull request #6551 from wallrj/gosec-601
Fix gosec G601: Implicit memory aliasing of items from a range statement
2023-12-20 18:21:37 +00:00
Tim Ramlot
0dabd1f008
refactor code, deduplicating init logic across install and uninstall
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-20 18:54:01 +01:00
Richard Wall
4de9e956e5 Fix gosec G601: Implicit memory aliasing of items from a range statement
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2023-12-20 17:25:41 +00:00
Richard Wall
3bed23f3f5 Enable the linting of _test.go files too
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2023-12-20 16:28:20 +00:00
Adam Talbot
4e02058cf3 fix: validation functions are not called anywhere
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
2023-12-20 15:49:18 +00:00
Tim Ramlot
fb381a6c3f
Update cmd/ctl/pkg/uninstall/uninstall.go
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-20 16:46:48 +01:00
Adam Talbot
6e83949f64 fix: normalise install flags to match other commands
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
2023-12-20 15:01:28 +00:00
Tim Ramlot
f60a61bde1
hide deprecated flags
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-20 10:25:35 +01:00
Tim Ramlot
f2af5672ee
add additional validation checks
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-20 10:13:11 +01:00
Tim Ramlot
cd58042746
improve the algorithm and add prevent DOS
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-20 10:13:11 +01:00
Tim Ramlot
c81609cdef
move certificate chain parsing to seperate file
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-20 10:13:07 +01:00
jetstack-bot
a10d81be5d
Merge pull request #6559 from ThatsMrTalbot/feat/gateway-api-v1
Update gateway-api to v1
2023-12-19 10:45:15 +00:00
Adam Talbot
247a034116 feat: update gateway api to v1
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
2023-12-18 21:00:42 +00:00
jetstack-bot
529d8a74a6
Merge pull request #6552 from allenmunC1/leaf-duration
Add flag and field to customize leaf duration on dynamic certificates
2023-12-14 16:02:38 +00:00
Richard Wall
260dc11c2d Show all issues
Signed-off-by: Richard Wall <richard.wall@venafi.com>
2023-12-14 12:10:20 +00:00
Richard Wall
09211dabdf Enable gosec G601
https://github.com/securego/gosec#available-rules

Signed-off-by: Richard Wall <richard.wall@venafi.com>
2023-12-14 12:10:20 +00:00
jetstack-bot
cf8421e13f
Merge pull request #6556 from SgtCoDFish/golangci-lint-make
Add target + installation for golangci-lint
2023-12-14 09:37:13 +00:00
Allen Mun
9b09aa87a7 Add flag and field to customize leaf duration on dynamic certificates
Signed-off-by: Allen Mun <allen.mun@capitalone.com>
2023-12-13 15:45:52 -05:00
Ashley Davis
dd61635f3b
add target + installation for golangci-lint
This lets users locally run the same commands that are run in CI

Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
2023-12-13 19:58:01 +00:00
jetstack-bot
7b36cfa808
Merge pull request #6555 from SgtCoDFish/fixlicenses
Fix licenses file
2023-12-13 15:19:12 +00:00
Ashley Davis
25298b75c7
fix licenses file
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
2023-12-13 14:22:15 +00:00
jetstack-bot
8da699a735
Merge pull request #6542 from tanujd11/fix/name-constraints-csr-structure
fix: structure of nameconstraint in CSR
2023-12-12 16:07:16 +00:00
jetstack-bot
4ae25789a2
Merge pull request #6537 from wallrj/golangci-lint
Add the golangci-lint GitHub action
2023-12-12 15:22:03 +00:00
Tim Ramlot
849b6bda9e
add tests & final cleanup
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-12 15:57:07 +01:00
Tim Ramlot
cfaf3f338e
cleanup code
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
2023-12-12 13:47:55 +01:00
tanujd11
da84cf5b88 fix: imports
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-12 17:10:32 +05:30
tanujd11
652feb50cc Addressed review comments
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-12 17:05:33 +05:30
tanujd11
5f0a715863 add nameConstraints from openssl
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-12 00:40:45 +05:30
jetstack-bot
37e425c4da
Merge pull request #6545 from wallrj/bump-go
Bump Go to 1.21.5
2023-12-11 18:05:47 +00:00
Richard Wall
f3a91ac8aa Bump Go to 1.21.5
- go1.21.4 (released 2023-11-07) includes security fixes to the path/filepath package, as well as bug fixes to the linker, the runtime, the compiler, and the go/types, net/http, and runtime/cgo packages.
- go1.21.5 (released 2023-12-05) includes security fixes to the go command, and the net/http and path/filepath packages, as well as bug fixes to the compiler, the go command, the runtime, and the crypto/rand, net, os, and syscall packages.

Signed-off-by: Richard Wall <richard.wall@venafi.com>
2023-12-11 17:27:09 +00:00
tanujd11
bc75f8488d fix: structure of nameconstraint in CSR
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-11 18:00:15 +05:30
jetstack-bot
e8d279025c
Merge pull request #6500 from tanujd11/feature/ca-cert-name-constraint
feature: added name constraints in certs with isCA enabled
2023-12-08 12:18:42 +00:00
tanujd11
a29a5913d0 addressed review comments
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-07 23:42:35 +05:30
Richard Wall
70cf0d200b Add the golangci-lint GitHub action
Initially we enable only the gosec linter and only check G112
because that has been addressed in #6534.

Signed-off-by: Richard Wall <richard.wall@venafi.com>
2023-12-07 18:03:04 +00:00
tanujd11
28ca4312b3 fix: additional review comments
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-07 22:30:31 +05:30
tanujd11
8d362439a8 fix UTs
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-07 22:30:31 +05:30
tanujd11
84d7dd4aed Addressed review comments
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-07 22:30:31 +05:30
tanujd11
d1b3e5ca83 Move critical from NameConstraintItem to NameConstraint and remove validateNameConstraints
Signed-off-by: tanujd11 <dwiveditanuj41@gmail.com>
2023-12-07 22:30:29 +05:30