Commit Graph

1531 Commits

Author SHA1 Message Date
Azure SDK Bot
e7747b4af9
Skip unnecessary and misleading role assignment warnings in local test resource deployment (#2954)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-10-07 13:06:09 -04:00
George Arama
bcfbe44a73
rework the polling method (#2949)
* rework th polling method

* fix typo for clang

* typo 2

* moved method to private

* expose properties

* Update to use Properties instead of redirecting to internal member

* formar files
2021-10-06 15:48:33 -07:00
George Arama
e5a01a29bd
Certificate Contacts API (#2912)
* Certificate Contacts API

* PR issues

* spell

* revert cspell , set disables in code

* set disables in code

* PR comments

* PR comments

* pr issue

* pr comments

* oops

* missed replace
2021-10-06 12:12:18 -07:00
Azure SDK Bot
5aa13f541d
Increment package version after release of azure-security-keyvault-keys (#2951) 2021-10-06 10:53:14 -07:00
Azure SDK Bot
aab2b798f8
Add devops variable setting/clearing to eng/common (#2952)
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
2021-10-06 10:30:24 -07:00
Azure SDK Bot
975ad22708
Sync eng/common directory with azure-sdk-tools for PR 2064 (#2953) 2021-10-06 09:30:57 -07:00
Azure SDK Bot
6303dd6d32
Revert change back (#2950)
Reverts back to a version that does not have mysterious Credential Issue

Co-authored-by: Sean Kane <68240067+seankane-msft@users.noreply.github.com>
2021-10-05 16:11:03 -04:00
Azure SDK Bot
e5f190c7a5
Handle multiple segments in service directory path (#2943)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-10-05 11:56:45 -07:00
Victor Vazquez
6044c63ad1
update changelog to release verion (#2937) 2021-10-05 11:38:02 -07:00
George Arama
613972c4c4
Certificates Issuers API (#2911)
* issuers

* PR issues

* PR comments
2021-10-04 12:08:43 -07:00
Azure SDK Bot
cfd115ed59
Update docker-start-proxy.ps1 (#2941)
Update to the latest version of the container

Co-authored-by: Sean Kane <68240067+seankane-msft@users.noreply.github.com>
2021-10-01 17:06:49 -04:00
Victor Vazquez
fc01933f28
disable cert tests for now (#2939) 2021-09-29 13:45:00 -07:00
Azure SDK Bot
cde679782a
Sync eng/common directory with azure-sdk-tools for PR 2046 (#2931)
* Pass package name from calling pipeline to uniquely identify pull request review

* Update log summary

* Update eng/common/scripts/Detect-Api-Changes.ps1

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
2021-09-29 07:05:08 -07:00
Victor Vazquez
8a12a64629
Adding GetCryptographyClient to KeyClient (#2917)
* Adding GetCryptographyClient to KeyClient

* update arg name
2021-09-27 15:36:37 -07:00
Azure SDK Bot
02be9fc757
Use stress-test-resources file naming to avoid live test auto-discovery (#2919)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-09-27 11:32:19 -07:00
Azure SDK Bot
6785c17149
Sync eng/common directory with azure-sdk-tools for PR 2027 (#2915)
* Handle assembly already loaded errors in deploy stress test script

* Add dependency checks and installation links to deploy-stress-tests.ps1

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-09-27 10:47:37 -07:00
Azure SDK Bot
58b19709c7
Add common policheck steps (#2920)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-09-24 16:39:08 -07:00
Azure SDK Bot
9ffa5c06cd
Sync eng/common directory with azure-sdk-tools for PR 2035 (#2918)
* Add

* Add more description to docs of where the variable is consumed

Co-authored-by: Daniel Jurek <djurek@microsoft.com>
2021-09-24 13:10:58 -07:00
Azure SDK Bot
b02dec3cf5
Clean-up changelog scripts (#2913)
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
2021-09-21 19:58:11 -07:00
George Arama
8727030623
Start create certificate (#2909)
* fix tests local

* first stab

* second

* operation

* HUzaaaah

* split header file

* updates

* error

* format, error

* clang due to certificates

* remove useless line used for debugginng

* Update .vscode/cspell.json

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* Update .vscode/cspell.json

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* Update sdk/keyvault/azure-security-keyvault-certificates/inc/azure/keyvault/certificates/certificate_client_models.hpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* Update sdk/keyvault/azure-security-keyvault-certificates/src/certificate_client_operations.cpp

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

* PR fixes

* revert wrong changes

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2021-09-21 12:38:41 -07:00
Azure SDK Bot
0646d2ddfe
Sync eng/common directory with azure-sdk-tools for PR 2010 (#2907)
* Remove empty sections in changelog entry as part of prepare release

* Update SECTIONS_HEADER_REGEX to accomodate various header levels

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-09-17 10:20:51 -07:00
Azure SDK Bot
d0991c71d2
Sync eng/common directory with azure-sdk-tools for PR 2011 (#2903)
* Common pipeline template and script to detect API changes

* Cahnges as per review comments

* Review comment changes

* CCahgnes as per review comments

* Show warning for list of failed packages to detect API changes

* Apply suggestions from code review

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
2021-09-16 12:33:40 -07:00
Rick Winter
bb8b889cf5
Remove static_cast (#2815)
* Remove static_cast

* Add additional checks around our Logger::Level to ensure its lock_free
2021-09-16 11:54:18 -07:00
Azure SDK Bot
8070ab2392
Sync eng/common directory with azure-sdk-tools for PR 2016 (#2904)
* Make ServiceName optional for verify-changelog

In cases like go where we don't pass a service name having this default to "not-specified" breaks things so we should allow for ServiceName and/or ServiceDirectory to be empty.

* Put quotes around the strings to allow for empty

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
2021-09-15 15:32:47 -07:00
Azure SDK Bot
15b6a7abc4
Sync eng/common directory with azure-sdk-tools for PR 2009 (#2897)
* Skip PSModule caching in container jobs

* Add succeeded check to condition

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
2021-09-15 12:45:36 -07:00
Azure SDK Bot
818cab9a2a
Add for multiple levels of Atx Headers in the CHANGELOG.md (#2900)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-09-14 16:56:12 -07:00
Daniel Jurek
14aa1516d0
Add spell check exceptions and enable CI failure for spelling errors in changed files (#2865)
* Add spell check exceptions and enable spell check failures

* Add HRESULT and sort spelling list

* Add exceptions for cmake-modules
2021-09-13 14:38:49 -07:00
Azure SDK Bot
9088500ec6
Sync eng/common directory with azure-sdk-tools for PR 1979 (#2864)
* Move logic for removing empty sections to ChangeLog-Operations.ps1

* Refactor sections regex

* Add SanitizeEntry parameter

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-09-13 13:50:35 -07:00
Azure SDK Bot
34cb6c76ae
Fix SemVer.ToString to handle v0 case (#2863)
Since we are treating v0 versions as prerelease we need to make sure
we don't accidently start to add the bogus prerelease label in cases where
we call ToString() on the version.

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
2021-09-13 13:06:08 -07:00
Azure SDK Bot
4aacb5f59f
Sync eng/common directory with azure-sdk-tools for PR 1946 (#2862)
* Add ability to exit gracefully when all files in the diff are excluded

* Address case where cspell exits with an error when all files from the 'files' config list are excluded by the expressions in 'ignorePaths'

* Add tests

* Review feedback: impl goes at the bottom and should be treated as a script, logic for testing should happen above that and exit appropriately if running tests

* Import common instead of logging

* Enable strict mode

Co-authored-by: Daniel Jurek <djurek@microsoft.com>
2021-09-13 13:04:47 -07:00
Azure SDK Bot
3e2e5a6dfc
Sync eng/common directory with azure-sdk-tools for PR 1983 (#2860)
* Doc Updates and Revisions for External Use

The focus of these changes is to revise the script to better support use
by external contributors and others outside of the Azure SDK ecosystem and
without access to the Microsoft AAD Tenant.

Changes include:

- Creation of a new Test Application service principal is now possible
  from a non-Microsoft AAD tenant.

- When a new Test Application principal is created, the principle of least
  privilege is now applied; the new Test Application is granted ownership
  of the resource group associated with the test resources and no longer
  has access to any other resources in the subscription.

- If an existing Test Application principal is specified, it will be
  assigned ownership of the resource group created.  This supports using
  a Test Application principal without privileges at the subscription-level.

- When no provisioner is specified, the script is now executed in the
  context of the caller rather than the Test Application principal.
  This supports using a Test Application principal that has restricted
  privileges and better aligns to the purpose of the Test Application
  principal.

- The `$TestApplicationOid` is now explicitly bound at the time a new Test
  Application principal is created rather than having to query for it later.

- Common error scenarios resulting from lack of permissions now provide
  messaging with more context of why the failure occurred and suggest
  remediation.

- Added new examples to illustrate the common call patterns needed by
  external contributors running the script, outside of the Microsoft tenant
  and Azure SDK ecosystem.

- Documentation has been enhanced with additional context to detail the
  permissions and roles assigned by the script.

- Added documentation details for Bicep template use.

* Add the provisioner OID to the deployment params

Key Vault needs this to deploy Managed HSMs. There's a corresponding change necessary in test-resources.json I'll roll out across languages.

* Fixing typos and spelling mistakes

Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
Co-authored-by: Heath Stewart <heaths@microsoft.com>
2021-09-13 09:21:47 -07:00
George Arama
6eb365cdd4
Devcontainer (#2861)
* final

* ytryrt

* Update .devcontainer/devcontainer.json

Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>

Co-authored-by: Victor Vazquez <victor.vazquez@microsoft.com>
2021-09-10 15:55:33 -07:00
Daniel Jurek
af44672837
Releases to vcpkg tag codeowners (#2825)
* Attempt tagging of @danieljurek in PRBody

* Attempt to assign reviewers

* Use codeowners, filter out groups, use a default owner, add comments to issue.

* Move variables to right level of config

* Set PrOwners variable

* Remove PR owners, requires admin permissions

* Escape DevOps variable to expand into string

* Add AuthToken

* Tweak portfile and codeowners to validate multiple artifact scenario

* Revert "Tweak portfile and codeowners to validate multiple artifact scenario"

This reverts commit bcc7a36119c7f399f1b079f51889d6ff0d499142.

* Review feedback

* Validate fallback logic

* Deal with empty list of owners

* Revert "Validate fallback logic"

This reverts commit ade2dff5a7d9cac9bb61fdc0f92cd50412b7c31c.
2021-09-09 14:47:15 -07:00
Azure SDK Bot
99ff3b04bd
Install az module if not installed in deploy-stress-tests.ps1 (#2857)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-09-09 14:01:10 -07:00
Azure SDK Bot
517902128f
Explicitly exit 0 so a failed inner command (like mvn) doesn't propagate up to a failure of the pipeline (#2859)
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
2021-09-09 11:03:45 -07:00
JinmingHu
88500317b7
Add ut for queue message containing special characters (#2858) 2021-09-09 12:04:58 +08:00
Azure SDK Bot
ef1dd860d5
Increment version for storage releases (#2846)
* Increment package version after release of azure-storage-blobs

* Increment package version after release of azure-storage-files-datalake

* Increment package version after release of azure-storage-files-shares

* Increment package version after release of azure-storage-queues
2021-09-09 10:42:50 +08:00
Azure SDK Bot
18ec808a25
Increment package version after release of azure-storage-common (#2847) 2021-09-09 10:41:41 +08:00
Azure SDK Bot
003eb57488
Sync eng/common directory with azure-sdk-tools repository (#2856) 2021-09-08 17:27:39 -07:00
Azure SDK Bot
c21718f838
Increment version for keyvault releases (#2855)
* Increment package version after release of azure-security-keyvault-keys

* Increment package version after release of azure-security-keyvault-secrets
2021-09-08 17:21:42 -07:00
Victor Vazquez
f752663d35
diable cert live tests (#2851) 2021-09-08 13:10:52 -07:00
Azure SDK Bot
91b459b560
Add Skip.SetTestPipelineVersion to allow overidiing of use of BuildID for test version (#2849)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-09-08 12:58:47 -07:00
Victor Vazquez
41138dcc8a
cl (#2840) 2021-09-08 10:08:33 -07:00
George Arama
6f8236287e
first pass (#2841) 2021-09-08 10:07:56 -07:00
JinmingHu
a1f69cd1fb
Update vcpkg.json (#2845) 2021-09-08 12:01:47 +08:00
JinmingHu
e6a488193b
Storage Sept Release (#2836) 2021-09-08 09:39:24 +08:00
Azure SDK Bot
6ef0b265e5
updating proxy to use latest version (#2843)
Co-authored-by: seankane-msft <seankane@microsoft.com>
2021-09-07 16:05:35 -07:00
Victor Vazquez
4ec0a34247
update links (#2842) 2021-09-07 14:45:08 -07:00
Victor Vazquez
8f0d6728c3
Adding Key Vault Certificates - GetCertificateWithPolicy API (#2818)
* certs one api checkpoint
2021-09-07 13:44:15 -07:00
JinmingHu
841675b622
Fix a bug where blobs with some characters cannot be listed (#2837)
* fix bug

* CL

* fix bug
2021-09-07 15:14:37 +08:00