Sync eng/common directory with azure-sdk-tools for PR 2016 (#2904)

* Make ServiceName optional for verify-changelog

In cases like go where we don't pass a service name having this default to "not-specified" breaks things so we should allow for ServiceName and/or ServiceDirectory to be empty.

* Put quotes around the strings to allow for empty

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

eng/common/pipelines/templates/steps/verify-changelog.yml

@@ -4,7 +4,7 @@ parameters:
   default: 'not-specified'
 - name: ServiceName
   type: string
-  default: 'not-specified'
+  default: ''
 - name: ServiceDirectory
   type: string
   default: ''
@@ -17,10 +17,10 @@ steps:
     inputs:
       filePath: $(Build.SourcesDirectory)/eng/common/scripts/Verify-ChangeLog.ps1
       arguments: >
-        -PackageName ${{ parameters.PackageName }}
-        -ServiceDirectory ${{ coalesce(parameters.ServiceDirectory, parameters.ServiceName) }}
+        -PackageName '${{ parameters.PackageName }}'
+        -ServiceDirectory '${{ coalesce(parameters.ServiceDirectory, parameters.ServiceName) }}'
         -ForRelease $${{ parameters.ForRelease }}
       pwsh: true
       workingDirectory: $(Pipeline.Workspace)
     displayName: Verify ChangeLogEntry for ${{ parameters.PackageName }}
-    continueOnError: false
+    continueOnError: false