Commit Graph

122 Commits

Author SHA1 Message Date
Ahson Khan
63b2d21bc6
Renamed Azure::Nullable<T>::GetValue() to Value(). (#2034)
* Renamed `Azure::Nullable<T>::GetValue()` to `Value()`.

* Update clang formatting.
2021-04-05 15:42:14 -07:00
Ahson Khan
8095d85e67
Simplify the public surface design of Response<T> for usability. (#1974)
* Simplify the design of Response<T> for usability.

* Revert changes to operation<T> to keep the changes single purpose.

* Update many of the response<T> call sites based on API changes.

* Update all remaining callsites and fix clang formatting.

* Update Response<T> documentation.

* Fix clang formatting.

* Remove status code from the Response<T> public surface area.

* Update the changelog.

* Fix up CL wording and remove commented-out change to operation<T>.

* Fixed test by actually calling a method.

* Fix up key vault test by not taking ownership of raw response.

* Fix call to get status code in test.

* Add new line at end of keyvualt live test file.

* Make a local copy within keyvault pipeline to avoid compilers re-ordering things.

* Make the fixes to the recent keyvault changes.

* Fix key vault pipeline to address ImportKey test failure
2021-04-01 00:50:04 +00:00
JinmingHu
c3a9d67d01
rename BlockListTypeOption -> BlockListType (#1945) 2021-03-19 09:54:57 +00:00
JinmingHu
37e5b2ad79
rename Tier -> AccessTier (#1943) 2021-03-19 06:23:35 +00:00
JinmingHu
a66592c99e
Rename some return types and options (#1941)
* rename some return types and options

* fix changelog

* BodyStream reference in blob protocol layer

* PathClient::GetAccessControlList returns PathAccessControlList

* more changelog

* changelog

* move UndeleteBlobContainerResult to _detail
2021-03-19 13:32:26 +08:00
JinmingHu
b88eb6d785
remove public fields from operation<T> (#1939) 2021-03-19 04:10:50 +00:00
JinmingHu
1b316d3b44
Changed BodyStream parameter in upload functions from pointer to refe… (#1938)
* Changed BodyStream parameter in upload functions from pointer to reference

* clang-format
2021-03-19 03:19:37 +00:00
JinmingHu
47c426990b
Removed RequestId from return types (#1931)
* remove request IDs

* changelog

* remove more
2021-03-18 19:51:35 +08:00
JinmingHu
9152e3dc33
remove DataLake/Blob/Share from options and result types (#1927) 2021-03-18 05:58:39 +00:00
JinmingHu
5210e8eb0d
revert changes to GetAccessPolicy (#1923) 2021-03-17 03:09:37 +00:00
JinmingHu
5df3596c34
Changed return type of BlobClinet::GetTags to std::map<std::string, std::string> (#1922) 2021-03-17 10:37:12 +08:00
JinmingHu
9c7d4c61e4
move stuff from _details to _internal for storage-common package (#1912)
closes https://github.com/Azure/azure-sdk-for-cpp/issues/1869


# Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the [contributing guide](https://github.com/Azure/azure-sdk-for-cpp/blob/master/CONTRIBUTING.md#pull-requests).

- [x] [C++ Guidelines](https://azure.github.io/azure-sdk/cpp_introduction.html)
- [x] Doxygen docs
- [x] Unit tests
- [x] No unwanted commits/changes
- [x] Descriptive title/description
  - [x] PR is single purpose
  - [x] Related issue listed
- [x] Comments in source
- [x] No typos
- [x] Update changelog
- [x] Not work-in-progress
- [x] External references or docs updated
- [x] Self review of PR done
- [x] Any breaking changes?
2021-03-16 06:55:13 +00:00
JinmingHu
100eba49e2
rename return types of some Get operations (#1819) 2021-03-16 12:30:30 +08:00
Ahson Khan
6a1afb9cbe
Moved the Base64Encode() and Base64Decode() functions to be static members of a Convert class within the Azure::Core namespace. (#1870)
* Moved the `Base64Encode()` and `Base64Decode()` functions to be static members of a `Convert` class within the `Azure::Core` namespace.

* Add the class name in the source file for posix.
2021-03-11 12:39:51 -08:00
Rick Winter
7c862e1a51
Switch to return the RawResponse const& (#1852)
* Operation returns a RawResposne const&
2021-03-11 10:59:33 -08:00
Ahson Khan
12475350b2
Changed the static methods 'BodyStream::ReadToCount()' and 'BodyStream::ReadToEnd()' into instance methods. (#1863)
Usability studies found that static methods are generally not as user-friendly as instance methods. Folks new to the SDK have harder time discovering the APIs, they reverse the flow of typing, and the calling code ends up a bit more verbose because you have to spell out the whole namespace and type name when there aren't any using directives.

There doesn't seem to be a strong benefit or feasibility reason to keep these method statics which are typically harder to use and discover.

cc @kyle-patterson
2021-03-11 11:58:33 +00:00
Victor Vazquez
23b698f2c6
Move URL to CORE (#1840)
* move url from Core::Http to Core::
2021-03-10 23:29:35 -08:00
Victor Vazquez
a9c0637e46
Moving Nullable<T> to Azure namespace (#1847)
* Moving Nullable<T> to Azure namespace

* changelog
2021-03-10 18:56:11 -08:00
Victor Vazquez
c7ba56f837
Move http policies to Azure::Core::Http::Policies (#1844)
* Move http policies to Azure::Core::Http::Policies

* update to latest master
2021-03-10 18:55:56 -08:00
Ahson Khan
2a1ea1f890
Rename the Range type to HttpRange within the Azure::Core::Http namespace. (#1835)
Part of https://github.com/Azure/azure-sdk-for-cpp/issues/1789

> We shouldn't have Method, StatusCode, or Range. The way to reason about this is chances of collision and ease of documentation/discover-ability in SEO. RawResponse is specific enough that it doesn't need Http prefix, that's how I would draw the line.
2021-03-10 23:26:36 +00:00
Rick Winter
ec24f659c4
Simplify the Context structure (#1824)
* Simplify the Context structure
* Move Azure::Core::GetApplicationContext() to Azure::Core::Context::GetApplicationContext()
2021-03-10 23:19:23 +00:00
Anton Kolesnyk
76870c4414
Azure::Core::DateTime => Azure::DateTime (#1836)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-03-10 22:44:09 +00:00
Ahson Khan
3d6cd38658
Move Azure::IO types like BodyStream to Azure::Core::IO. (#1833)
Part of https://github.com/Azure/azure-sdk-for-cpp/issues/1789

From Jeff:
> BodyStream is only exposed to users when uploading/downloading bytes. Except for Storage almost no services do this at all; they read the stream and deserialize into a structure and the customer gets the structure - not the stream. Azure::Core:IO is a fine namespace.
2021-03-10 21:36:29 +00:00
Anton Kolesnyk
bc564dbddd
Namespaces renamed: Details => _detail, Internal => _internal (#1823) 2021-03-09 18:05:47 -08:00
Victor Vazquez
a70be6a49c
Moving ETag to ::Azure (#1801)
etag rename
2021-03-08 16:05:18 -08:00
JinmingHu
45055dc9ef
use new HttpPipeline builder (#1784) 2021-03-07 10:03:08 +08:00
JinmingHu
01ae3714f1
return rawresponse for copy operation (#1807)
* return rawresponse for copy operation

* also for file copy

* remove noexcept
2021-03-06 08:26:34 +00:00
Ahson Khan
11a533a6fd
For consistency within the SDK, move Azure::Core::Context to be the last parameter for various Azure::Core APIs. (#1779)
* For consistency within the SDK, move Azure::Core::Context to be the last
parameter for various Azure::Core APIs.

* Fix merge conflict due to log policy file change.

* Update new client options tests
2021-03-05 14:39:57 -08:00
Victor Vazquez
16eb5710d1
Rename add headers (#1750)
* Rename AddHeader to SetHeader
2021-03-04 22:09:22 +00:00
Ahson Khan
a55aba01be
Moved BodyStream and its derived types from Azure::Core::Http namespace to Azure::IO, and update headers. (#1733)
* Moved `BodyStream` and its derived types from `Azure::Core::Http`
namespace to `Azure::IO`, and update headers.

* Fix up clang formatting.

* Add missing winhttp bodystream namespace change.

* Update merge conflict related changes.

* Update header paths in includes.
2021-03-01 11:33:26 -08:00
JinmingHu
624d81ed0f
Rename string conversion functions to ToString() (#1748)
* Get() -> ToString()

* changelog
2021-02-25 23:30:43 -08:00
JinmingHu
50772fa2d2
return Operation<T> for copy blob API (#1736) 2021-02-26 04:48:17 +00:00
Casey Carter
f9d4d36ad8
Defend public headers against inclusion of Windows.h (#1719)
* Defend public headers against inclusion of Windows.h

... which defines some nasty function-like macros `min` and `max` when `_NOMINMAX` isn't defined. We prevent expansion as a function-like macro by inserting some token(s) between `min`/`max` and the following `(`. Most commonly that means wrapping the entire qualified-name in `()` a la `(std::min)(x, y)`, but an explicit template argument list (`std::min<int>(x, y)`) works as well.

* clang-format all the things

* Test coverage

I assume that the `azure-meow-common` headers are fully covered by the tests for the `azure-meow-woof` SDKs.
2021-02-23 09:56:00 -08:00
Victor Vazquez
b7de24483a
Rename and structure unit test and perf tests (#1706)
* Rename and structure unit test and perf tests
2021-02-23 05:55:12 +00:00
JinmingHu
5c2d0fba17
remove unused stuff (#1701) 2021-02-19 14:53:04 +08:00
Victor Vazquez
e9cf40505b
Performance projects for services (#1655)
* add test metadata to the tests for the perf fw
2021-02-18 21:05:22 +00:00
Victor Vazquez
b41c53509b
Update GetString to ToString (#1677)
* Update GetString to ToString
2021-02-12 22:25:01 +00:00
Ahson Khan
b40603dc40
Renamed Crc64 to Crc64Hash and change it to derive from the Azure::Core::Cryptography::Hash class. (#1646)
* Renamed `Crc64` to `Crc64Hash` and change it to derive from the `Azure::Core::Cryptography::Hash` class.

* Add default dtor
2021-02-09 22:06:11 -08:00
Ahson Khan
5359e2793a
Remove Storage::Md5 and replace it with the one from Azure::Core. (#1618)
* Add MD5 hashing APIs to Azure::Core available from azure/core/md5.hpp.

* Add simplified header test for md5 and base64.

* Add changelog entry.

* Remove unnecessary include.

* Remove Storage::Md5 and replace it with the one from Azure::Core.

* Fix clang formatting.

* Add required cstdint include directive.

* Update storage based on recent changes to Md5 hash APIs.
2021-02-08 20:04:25 -08:00
JinmingHu
90430040d5
Many changes to File service and DataLake service (#1623)
* changes

* UploadRangeFromUri

* fileattributes

* test case for file attributes

* add new lines

* changelog

* clang-format

* fix build error

* uri->url

* changes to datalake

* Remove BreakResult::LeaseTime
2021-02-08 19:57:30 +08:00
JinmingHu
d26e148c86
refine list return types for blob service (#1578)
* refine return type of listblob and listblobcontainers

* changelog
2021-02-03 16:14:14 +08:00
JinmingHu
c8da53d544
Change ChangeLease return type (#1573)
* ChangeLease return type

* file client

* Add comment

* return Result rather than Client

* fix

* fix
2021-02-03 14:49:24 +08:00
JinmingHu
fab5c1139b
Refine DownloadBlobResult and DownloadBlobToResult (#1564)
* blob result

* rename

* fix

* fix
2021-02-02 19:25:22 +08:00
JinmingHu
e84b9eac50
add missing properties in blob download result (#1521)
* rename ContentLength->BlobSize
add missing properties in DownloadBlobToResult

* range hash algorithm

* changelog

* fix ut error
2021-02-01 12:04:28 +08:00
JinmingHu
5e2e84cdbc
add missing properties in BlobClient::GetProperties (#1512)
* add missing properties in BlobClient::GetProperties

* changelog

* fix test case bug

* Add more properties in download blob result
2021-01-29 11:39:00 +08:00
JinmingHu
ee156b6505
add TransferOptions into download and upload options (#1503)
* tansfer options

* changelog

* fix build error

* clang-format

* fix typo

* fix crash
2021-01-28 23:46:15 +08:00
JinmingHu
836a8a591a
Removed BlobPrefix struct, use std::string instead (#1508)
* blob prefix is std::vector<std::string>

* changelog
2021-01-28 21:48:47 +08:00
JinmingHu
f49dc280df
use Azure::Core::ETag for ETag type (#1489)
* etag

* ETag for DataLake/File service

Co-authored-by: Tank Tang <kat@microsoft.com>
2021-01-28 19:36:48 +08:00
JinmingHu
ec9d35ae8c
remove some items from filter blob result (#1504) 2021-01-28 16:32:51 +08:00
JinmingHu
9c2d02244e
rename bitwise enum variables, following the pattern XxxFlags (#1466)
* XxxItems->XxxFlags

* changelog
2021-01-28 12:54:42 +08:00