github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

remove public fields from operation<T> (#1939)

Browse Source
This commit is contained in:
JinmingHu 2021-03-19 12:10:50 +08:00 committed by GitHub
parent 1b316d3b44
commit b88eb6d785
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 0 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/blob_responses.hpp
View File

@ -66,13 +66,6 @@ namespace Azure { namespace Storage { namespace Blobs {
} // namespace Models
class StartCopyBlobOperation : public Azure::Core::Operation<Models::BlobProperties> {
public:
Azure::ETag ETag;
Azure::DateTime LastModified;
std::string CopyId;
Models::CopyStatus CopyStatus;
Azure::Nullable<std::string> VersionId;
public:
Models::BlobProperties Value() const override { return m_pollResult; }

5
sdk/storage/azure-storage-blobs/src/blob_client.cpp
View File

@ -562,11 +562,6 @@ namespace Azure { namespace Storage { namespace Blobs {
*m_pipeline, m_blobUrl, protocolLayerOptions, context);
StartCopyBlobOperation res;
res.m_rawResponse = response.ExtractRawResponse();
res.ETag = std::move(response->ETag);
res.LastModified = std::move(response->LastModified);
res.CopyId = std::move(response->CopyId);
res.CopyStatus = std::move(response->CopyStatus);
res.VersionId = std::move(response->VersionId);
res.m_blobClient = std::make_shared<BlobClient>(*this);
return res;
}

5
sdk/storage/azure-storage-blobs/src/page_blob_client.cpp
View File

@ -302,11 +302,6 @@ namespace Azure { namespace Storage { namespace Blobs {
*m_pipeline, m_blobUrl, protocolLayerOptions, context);
StartCopyBlobOperation res;
res.m_rawResponse = response.ExtractRawResponse();
res.ETag = std::move(response->ETag);
res.LastModified = std::move(response->LastModified);
res.CopyId = std::move(response->CopyId);
res.CopyStatus = std::move(response->CopyStatus);
res.VersionId = std::move(response->VersionId);
res.m_blobClient = std::make_shared<BlobClient>(*this);
return res;
}

10
sdk/storage/azure-storage-blobs/test/ut/block_blob_client_test.cpp
View File

@ -206,16 +206,7 @@ namespace Azure { namespace Storage { namespace Test {
auto blobClient = m_blobContainerClient->GetBlobClient(RandomString());
auto res = blobClient.StartCopyFromUri(m_blockBlobClient->GetUrl());
EXPECT_EQ(res.GetRawResponse().GetStatusCode(), Azure::Core::Http::HttpStatusCode::Accepted);
EXPECT_TRUE(res.ETag.HasValue());
EXPECT_TRUE(IsValidTime(res.LastModified));
EXPECT_FALSE(res.CopyId.empty());
EXPECT_TRUE(res.VersionId.HasValue());
EXPECT_FALSE(res.VersionId.GetValue().empty());
EXPECT_TRUE(
res.CopyStatus == Azure::Storage::Blobs::Models::CopyStatus::Pending
|| res.CopyStatus == Azure::Storage::Blobs::Models::CopyStatus::Success);
auto properties = *blobClient.GetProperties();
EXPECT_EQ(properties.CopyId.GetValue(), res.CopyId);
EXPECT_FALSE(properties.CopySource.GetValue().empty());
EXPECT_TRUE(
properties.CopyStatus.GetValue() == Azure::Storage::Blobs::Models::CopyStatus::Pending
@ -230,7 +221,6 @@ namespace Azure { namespace Storage { namespace Test {
EXPECT_FALSE(properties.IncrementalCopyDestinationSnapshot.HasValue());
auto downloadResult = blobClient.Download();
EXPECT_EQ(downloadResult->Details.CopyId.GetValue(), res.CopyId);
EXPECT_FALSE(downloadResult->Details.CopySource.GetValue().empty());
EXPECT_TRUE(
downloadResult->Details.CopyStatus.GetValue()

6
sdk/storage/azure-storage-blobs/test/ut/page_blob_client_test.cpp
View File

@ -151,12 +151,6 @@ namespace Azure { namespace Storage { namespace Test {
auto copyInfo = pageBlobClient.StartCopyIncremental(sourceUri.GetAbsoluteUrl());
EXPECT_EQ(
copyInfo.GetRawResponse().GetStatusCode(), Azure::Core::Http::HttpStatusCode::Accepted);
EXPECT_TRUE(copyInfo.ETag.HasValue());
EXPECT_TRUE(IsValidTime(copyInfo.LastModified));
EXPECT_FALSE(copyInfo.CopyId.empty());
EXPECT_FALSE(copyInfo.CopyStatus.ToString().empty());
EXPECT_TRUE(copyInfo.VersionId.HasValue());
EXPECT_FALSE(copyInfo.VersionId.GetValue().empty());
auto getPropertiesResult = copyInfo.PollUntilDone(std::chrono::seconds(1));
ASSERT_TRUE(getPropertiesResult->CopyStatus.HasValue());
EXPECT_EQ(getPropertiesResult->CopyStatus.GetValue(), Blobs::Models::CopyStatus::Success);

7
sdk/storage/azure-storage-files-shares/inc/azure/storage/files/shares/share_responses.hpp
View File

@ -171,13 +171,6 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares {
} // namespace Models
class StartCopyFileOperation : public Azure::Core::Operation<Models::FileProperties> {
public:
Azure::ETag ETag;
Azure::DateTime LastModified;
std::string CopyId;
Models::CopyStatusType CopyStatus;
Nullable<std::string> VersionId;
public:
Models::FileProperties Value() const override { return m_pollResult; }

4
sdk/storage/azure-storage-files-shares/src/share_file_client.cpp
View File

@ -373,10 +373,6 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares {
StartCopyFileOperation res;
res.m_rawResponse = response.ExtractRawResponse();
res.ETag = std::move(response->ETag);
res.LastModified = std::move(response->LastModified);
res.CopyId = std::move(response->CopyId);
res.CopyStatus = std::move(response->CopyStatus);
res.m_fileClient = std::make_shared<ShareFileClient>(*this);
return res;
}

4
sdk/storage/azure-storage-files-shares/test/share_file_client_test.cpp
View File

@ -682,10 +682,6 @@ namespace Azure { namespace Storage { namespace Test {
EXPECT_EQ(
copyOperation.GetRawResponse().GetStatusCode(),
Azure::Core::Http::HttpStatusCode::Accepted);
EXPECT_TRUE(copyOperation.ETag.HasValue());
EXPECT_TRUE(IsValidTime(copyOperation.LastModified));
EXPECT_FALSE(copyOperation.CopyId.empty());
EXPECT_FALSE(copyOperation.CopyStatus.ToString().empty());
auto fileProperties = *copyOperation.PollUntilDone(std::chrono::milliseconds(1000));
EXPECT_EQ(
fileProperties.CopyStatus.GetValue(), Files::Shares::Models::CopyStatusType::Success);