github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

return rawresponse for copy operation (#1807)

Browse Source 
* return rawresponse for copy operation

* also for file copy

* remove noexcept
This commit is contained in:
JinmingHu 2021-03-06 16:26:34 +08:00 committed by GitHub
parent 9dedcb0d4c
commit 01ae3714f1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 22 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/blob_responses.hpp
View File

@ -87,11 +87,13 @@ namespace Azure { namespace Storage { namespace Blobs {
* @return A pointer to #Azure::Core::Http::RawResponse.
* @note Does not give up ownership of the RawResponse.
*/
Azure::Core::Http::RawResponse* GetRawResponse() const override
{
// TODO: Fix to return the rawResponse
return nullptr;
}
Azure::Core::Http::RawResponse* GetRawResponse() const override { return m_rawResponse.get(); }
StartCopyBlobOperation() = default;
StartCopyBlobOperation(StartCopyBlobOperation&&) = default;
StartCopyBlobOperation& operator=(StartCopyBlobOperation&&) = default;
~StartCopyBlobOperation() override {}
@ -109,6 +111,7 @@ namespace Azure { namespace Storage { namespace Blobs {
std::chrono::milliseconds period,
Azure::Core::Context& context) override;
std::unique_ptr<Azure::Core::Http::RawResponse> m_rawResponse;
std::shared_ptr<BlobClient> m_blobClient;
Models::GetBlobPropertiesResult m_pollResult;

1
sdk/storage/azure-storage-blobs/src/blob_client.cpp
View File

@ -545,6 +545,7 @@ namespace Azure { namespace Storage { namespace Blobs {
auto response = Details::BlobRestClient::Blob::StartCopyFromUri(
context, *m_pipeline, m_blobUrl, protocolLayerOptions);
StartCopyBlobOperation res;
res.m_rawResponse = response.ExtractRawResponse();
res.RequestId = std::move(response->RequestId);
res.ETag = std::move(response->ETag);
res.LastModified = std::move(response->LastModified);

1
sdk/storage/azure-storage-blobs/src/page_blob_client.cpp
View File

@ -304,6 +304,7 @@ namespace Azure { namespace Storage { namespace Blobs {
auto response = Details::BlobRestClient::PageBlob::StartCopyIncremental(
context, *m_pipeline, m_blobUrl, protocolLayerOptions);
StartCopyBlobOperation res;
res.m_rawResponse = response.ExtractRawResponse();
res.RequestId = std::move(response->RequestId);
res.ETag = std::move(response->ETag);
res.LastModified = std::move(response->LastModified);

1
sdk/storage/azure-storage-blobs/test/ut/block_blob_client_test.cpp
View File

@ -205,6 +205,7 @@ namespace Azure { namespace Storage { namespace Test {
{
auto blobClient = m_blobContainerClient->GetBlobClient(RandomString());
auto res = blobClient.StartCopyFromUri(m_blockBlobClient->GetUrl());
EXPECT_NE(res.GetRawResponse(), nullptr);
EXPECT_FALSE(res.RequestId.empty());
EXPECT_TRUE(res.ETag.HasValue());
EXPECT_TRUE(IsValidTime(res.LastModified));

1
sdk/storage/azure-storage-blobs/test/ut/page_blob_client_test.cpp
View File

@ -150,6 +150,7 @@ namespace Azure { namespace Storage { namespace Test {
Azure::Core::Http::Url sourceUri(m_pageBlobClient->WithSnapshot(snapshot).GetUrl());
sourceUri.AppendQueryParameters(GetSas());
auto copyInfo = pageBlobClient.StartCopyIncremental(sourceUri.GetAbsoluteUrl());
EXPECT_NE(copyInfo.GetRawResponse(), nullptr);
EXPECT_FALSE(copyInfo.RequestId.empty());
EXPECT_TRUE(copyInfo.ETag.HasValue());
EXPECT_TRUE(IsValidTime(copyInfo.LastModified));

13
sdk/storage/azure-storage-files-shares/inc/azure/storage/files/shares/share_responses.hpp
View File

@ -203,11 +203,13 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares {
* @return A pointer to #Azure::Core::Http::RawResponse.
* @note Does not give up ownership of the RawResponse.
*/
Azure::Core::Http::RawResponse* GetRawResponse() const override
{
// TODO: Fix to return the rawResponse
return nullptr;
}
Azure::Core::Http::RawResponse* GetRawResponse() const override { return m_rawResponse.get(); }
StartCopyShareFileOperation() = default;
StartCopyShareFileOperation(StartCopyShareFileOperation&&) = default;
StartCopyShareFileOperation& operator=(StartCopyShareFileOperation&&) = default;
~StartCopyShareFileOperation() override {}
@ -225,6 +227,7 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares {
std::chrono::milliseconds period,
Azure::Core::Context& context) override;
std::unique_ptr<Azure::Core::Http::RawResponse> m_rawResponse;
std::shared_ptr<ShareFileClient> m_fileClient;
Models::GetShareFilePropertiesResult m_pollResult;

1
sdk/storage/azure-storage-files-shares/src/share_file_client.cpp
View File

@ -374,6 +374,7 @@ namespace Azure { namespace Storage { namespace Files { namespace Shares {
m_shareFileUrl, *m_pipeline, context, protocolLayerOptions);
StartCopyShareFileOperation res;
res.m_rawResponse = response.ExtractRawResponse();
res.RequestId = std::move(response->RequestId);
res.ETag = std::move(response->ETag);
res.LastModified = std::move(response->LastModified);

1
sdk/storage/azure-storage-files-shares/test/share_file_client_test.cpp
View File

@ -680,6 +680,7 @@ namespace Azure { namespace Storage { namespace Test {
auto destFileClient
= m_shareClient->GetRootDirectoryClient().GetFileClient(LowercaseRandomString(10));
auto copyOperation = destFileClient.StartCopy(fileClient.GetUrl());
EXPECT_NE(copyOperation.GetRawResponse(), nullptr);
EXPECT_FALSE(copyOperation.RequestId.empty());
EXPECT_TRUE(copyOperation.ETag.HasValue());
EXPECT_TRUE(IsValidTime(copyOperation.LastModified));