Commit Graph

726 Commits

Author SHA1 Message Date
Azure SDK Bot
a3a4709ba9
Sync eng/common directory with azure-sdk-tools for PR 1341 (#1479)
* Run the link verification step even previous step failed.

* Make the tab right

* Address comments

* Run default condition if no RunOnFailure set.

* Changed back to simple condition

Co-authored-by: Sima Zhu <sizhu@microsoft.com>
2021-01-26 18:14:46 -08:00
Kan Tang
b3cdb2790c
Uses std::abort() instead of abort() or exception for precondition. (#1474) 2021-01-27 09:43:22 +08:00
Victor Vazquez
5f20767a4b
Setting up keyvault live test (#1465)
* Setting up keyvault live test
2021-01-26 15:44:59 -08:00
Daniel Jurek
583120d3ef
Add timeout parameter to live test job (#1478) 2021-01-26 15:04:37 -08:00
Rick Winter
50a4186d96
Add support for HTTP Etag to Azure::Core (#1428)
* Add ETag class
2021-01-26 12:04:34 -08:00
Azure SDK Bot
153a6dd8b8
Fixed the problem of no display name issue (#1476)
Co-authored-by: Sima Zhu <sizhu@microsoft.com>
2021-01-26 10:52:46 -08:00
Victor Vazquez
ccccd115f8
Adding missing comments in curl source (#1440)
fixes: #1416
2021-01-26 08:19:09 +00:00
JinmingHu
ae53a38c7a
Support poll operations in blob service (#1461)
* operation<T>

* add test cases

* changelog

* fix build error

* add virtual destructor

* fix build error

* use Azure::Core::RequestFailedException
2021-01-26 16:00:20 +08:00
Ahson Khan
a850513e28
Update clang format validate script instructions when it fails to be accurate (#1460)
Syncing the instructions based on changes from https://github.com/Azure/azure-sdk-for-cpp/pull/1438

Currently, the instructions suggest running a command which may not work on all OSes:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=701256&view=logs&j=0585f5d6-0937-5c15-894c-06e189e06847&t=a45688da-a69e-5817-f832-3aa6246959b7
```text
Some files were not formatted correctly according to the .clang-format file.
Please run clang-format version 10 or greater to fix the issue by using this bash command at the root of the repo:
find sdk/ -regex '.*\.\(cpp\|hpp\)' -exec clang-format -style=file -i {} \;
```
2021-01-26 01:44:04 +00:00
Azure SDK Bot
469bf2ca2d
Sync eng/common directory with azure-sdk-tools for PR 1335 (#1441)
* Lossen up $RELEASE_TITLE_REGEX to accomodate wrongly formated changelogs

* Update changelog logic to use ordered hashtable

* Update semver and Changelog logic

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-01-25 10:50:56 -08:00
JinmingHu
d2f29afb1d
Added additional information in StorageException, fixed a bug where ClientRequestId wasn't filled in StorageException. (#1455)
* additional info in storage exception

* changelog

* clang-format
2021-01-25 22:22:27 +08:00
Kan Tang
a60fff1d6e
Removed unused parameters, options, results and functions in protocol layer. (#1454) 2021-01-25 15:37:33 +08:00
JinmingHu
84f7445302
PublicAccessType::Private was renamed to PublicAccessType::None (#1453)
* rename PublicAccessType::Private to None

* changelog

* fix
2021-01-25 15:35:56 +08:00
JinmingHu
4c8232e9cf
startsOn parameter for GetUserDelegationKey was changed to optional. (#1451)
* GetUserDelegationKey startsOn is optional

* changelog

* clang-format
2021-01-25 14:49:11 +08:00
Kan Tang
0df1cfa90f
Changed DataLakeFileClient::Flush's endingOffset parameter's name to position. (#1449)
* Changed DataLakeFileClient::Flush's endingOffset parameter's name to position.

* Update CHANGELOG.md
2021-01-25 12:28:34 +08:00
Kan Tang
ad54405b9d
Added request ID. (#1452)
* Added request ID.

* Update sdk/storage/azure-storage-files-datalake/CHANGELOG.md

Co-authored-by: JinmingHu <jinmhu@microsoft.com>

Co-authored-by: JinmingHu <jinmhu@microsoft.com>
2021-01-25 12:25:18 +08:00
Kan Tang
6f6c3c9cde
Added support for specifying public access type when creating a file system. (#1447) 2021-01-25 10:37:34 +08:00
Kan Tang
6b71b5416d
Refined ListPathsSinglePage (#1446) 2021-01-25 10:17:29 +08:00
Kan Tang
f27c5770d1
Refined list related APIs and make LeaseDuration an enum. (#1445)
* Refined list related APIs

* Update CHANGELOG.md
2021-01-25 10:14:33 +08:00
Kan Tang
23df72519b
Moved lease related operations to DataLakeLeaseClient/ShareLeaseClient. (#1444)
* Moved lease related operations to DataLakeLeaseClient/ShareLeaseClient.

* Adds lease duration change to changelog

* Update sdk/storage/azure-storage-files-datalake/src/datalake_lease_client.cpp

Co-authored-by: JinmingHu <jinmhu@microsoft.com>

* Hide Share Lease again since it seems to be still not ready.

* Move renew to private as it is not for file lease.

Co-authored-by: JinmingHu <jinmhu@microsoft.com>
2021-01-24 20:55:09 +08:00
Kan Tang
46d4af45b6
Refined protocol layer. (#1443)
* Refined protocol layer.

* Resolves review comments.

* Move more un-used things into details.
2021-01-23 23:10:41 +08:00
Victor Vazquez
1aaf1f22df
Sample for fetchContent (#1392)
* Sample for fetchContent
2021-01-22 16:10:44 -08:00
Victor Vazquez
4455ac577c
Move clang-format check to include tests (#1438)
* Move clang-format check to include tests
2021-01-22 13:35:59 -08:00
Victor Vazquez
5af134b103
missing format (#1437)
Adding clang-format to json.hpp.  Not sure how it passed the gates before. I might need to revisit if the clang-format check is working
2021-01-22 19:38:59 +00:00
Victor Vazquez
385a7887a2
Moving json to internal (#1378)
Wrap nlohmann json lib inside core internal api
2021-01-22 11:12:27 -08:00
JinmingHu
c4d89ac5c9
use std::chrono::seconds or enum for lease duration (#1432)
* use std::chrono::seconds for duration

* changelog

* add enum for lease duration in response

* changelog

* fix build error

* fix build error

* fix build error
2021-01-22 16:28:14 +08:00
Daniel Jurek
cc1aeb4d3f
Fix Language-Settings.ps1 to use correct logic (#1427) 2021-01-21 21:59:12 -08:00
Kan Tang
a0a3c6d5c5
Changed ContentRange from std::string to Azure::Core::Http::Range. (#1415)
* Changed ContentRange from std::string to Azure::Core::Http::Range.

* Resolved further comments.

* Resolved test issues
2021-01-21 21:37:03 -08:00
JinmingHu
d5a53423bd
replace GetRawResponse with ExtractRawResponse (#1430) 2021-01-22 11:53:10 +08:00
JinmingHu
76db013528
blob lease client (#1424)
* blob lease client

* changelog

* Apply suggestions from code review
2021-01-22 10:24:10 +08:00
Anton Kolesnyk
15182d5a34
Fix link errors when producing a DLL, add UWP compilation support (#1346) 2021-01-21 16:52:07 -08:00
Azure SDK Bot
4b8dbb696a
Sync eng/common directory with azure-sdk-tools for PR 1251 (#1429)
* Add PrepareRelease Script

* Generalize Prepare-Release Script

* Update Update-ChangeLog.ps1

* Update Package-Properties.ps1

* Update Collect-ChangeLog Script

* Update Collect-ChangeLog.ps1 and Collect-Unreleased.ps1

* Update GeneralReleaseNotesParser.ps1 script

* Update Prepare-Release Script to use recent DevOps Scripts

* Move Get-LanguageName to eng\common\scripts\Helpers\DevOps-WorkItem-Helpers.ps1, improve error message, add logic to detect changes made by prepare-release script

* Use LanguageDisplayName, move Get-CSVMetadata to Package-Properties.ps1

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-01-21 16:48:02 -08:00
Victor Vazquez
a2bc2e9d99
remove static analysis from CI (#1423)
fixes: #1422
2021-01-21 20:20:27 +00:00
Chidozie Ononiwu
1310c8e0ea
Add LanguageDisplayName variable in LanguageSettings file (#1406) 2021-01-21 09:57:10 -08:00
Kan Tang
13afe30353
Added support for Set/GetAccessPolicy in DataLakeFileSystemClient (#1411)
* Added support for Set/GetAccessPolicy in FileSystemClient

* Address review comments

* Changed Private to None.
2021-01-21 19:55:48 +08:00
Victor Vazquez
473c7ee0b0
add libcurl to livetest pipeline (#1413) 2021-01-20 19:39:00 -08:00
Azure SDK Bot
bae689aee2
Ensure bypass conditional template gets run for 1es ubuntu image (#1420)
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
2021-01-20 18:30:27 -08:00
Azure SDK Bot
aae5fc8186
Sync eng/common directory with azure-sdk-tools repository (#1418) 2021-01-20 15:37:08 -08:00
Azure SDK Bot
2fe1ab8a4b
Sync eng/common directory with azure-sdk-tools for PR 1317 (#1419)
* retarget the tool clone to a release tag

Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
2021-01-20 23:19:16 +00:00
Victor Vazquez
1320d8a830
Add link to the doc (#1384)
* Add link to the doc
2021-01-20 10:02:21 -08:00
Kan Tang
bbbf8bff39
Remove Data suffix according to review comments. (#1397)
* Remove Data suffix according to review comments.

* Update readme.
2021-01-20 19:37:51 +08:00
Kan Tang
e2a49a127b
Renamed GetUri to GetUrl. (#1414) 2021-01-20 16:53:52 +08:00
JinmingHu
66538df833
AccountSasResource::BlobContainer was renamed to AccountSasResource::Container (#1410)
* Rename AccountSasResource::BlobContainer to AccountSasResource::Container

* changelog
2021-01-20 16:39:34 +08:00
Victor Vazquez
d5cb9ccec0
revert timeout patch on libcurl (#1412)
Reverting https://github.com/Azure/azure-sdk-for-cpp/pull/1391/files as the patch is still required.

The previous validation was invalid because the current storage pipeline is not testing libcurl transport adapter
2021-01-20 06:50:22 +00:00
JinmingHu
4c322f3b7e
AccessType and ListType should be non-nullable (#1408)
* access type and block list type is not nullable

* access type is optional in protocol layer

* changelog
2021-01-20 14:29:13 +08:00
Victor Vazquez
3f67c21ba8
Fix the end of chunk parsing (#1403)
While parsing a chunked response with the curl HTTP transport adapter, there was an issue for parsing the last chunk.
As soon as the end of chunk data was found ("0") the adapter was returning and setting the session state as if the transfer was completed.
However, the HTTP RFC for chunked data (https://tools.ietf.org/html/rfc7230#section-4.1) defines that there is a CRLF after the last chunk info.

By not reading the last CRLF from the response, and if the connection was re-used right after reading the last chunk made the next request to get the `CRLF` as the first part for the response, making the parser crash.

The fix in this PR makes sure that when the last chunk is found and parsed, the CRLF is also parsed from the response to make sure that the response data transfer has completed

fixes: #1396
2021-01-20 05:57:45 +00:00
Azure SDK Bot
7d04092708
Update error message in tools repo (#1405)
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
2021-01-19 21:34:30 -08:00
Kan Tang
ffd79fcc74
Refined the ACL/Permission APIs according to review comments. (#1399)
* Refined the ACL/Permission APIs according to review comments.

* Update CHANGELOG.md

* Update datalake_options.hpp
2021-01-20 12:08:49 +08:00
Kan Tang
d0abaa1076
Use path/directory/file name instead of path. (#1398)
* Use path/directory/file name instead of path.

* Resolved review comments and refined docs.
2021-01-20 12:08:42 +08:00
Kan Tang
6bd4ded77f
Revert adding the datalake prefix for list path API in protocol layer's options. (#1400) 2021-01-20 11:02:45 +08:00