github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

revert timeout patch on libcurl (#1412)

Browse Source 
Reverting https://github.com/Azure/azure-sdk-for-cpp/pull/1391/files as the patch is still required.

The previous validation was invalid because the current storage pipeline is not testing libcurl transport adapter
This commit is contained in:
Victor Vazquez 2021-01-19 22:50:22 -08:00 committed by GitHub
parent 4c322f3b7e
commit d5cb9ccec0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sdk/core/azure-core/src/http/curl/curl.cpp
View File

@ -1134,6 +1134,16 @@ std::unique_ptr<CurlNetworkConnection> CurlConnectionPool::GetCurlConnection(
+ std::string(curl_easy_strerror(result)));
}
// Set timeout to 24h. Libcurl will fail uploading on windows if timeout is:
// timeout >= 25 days. Fails as soon as trying to upload any data
// 25 days < timeout > 1 days. Fail on huge uploads ( > 1GB)
if (!SetLibcurlOption(newHandle, CURLOPT_TIMEOUT, 60L * 60L * 24L, &result))
{
throw Azure::Core::Http::TransportException(
Details::c_DefaultFailedToGetNewConnectionTemplate + host + ". "
+ std::string(curl_easy_strerror(result)));
}
/******************** Curl handle options apply to all connections created
* The keepAlive option is managed by the session directly.
*/