* Improvement: Create only necessary threads when there isn't enough data to transfer
* Update sdk/storage/azure-storage-common/inc/azure/storage/common/internal/concurrent_transfer.hpp
* CL
# Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the [contributing guide](https://github.com/Azure/azure-sdk-for-cpp/blob/main/CONTRIBUTING.md#pull-requests).
- [x] [C++ Guidelines](https://azure.github.io/azure-sdk/cpp_introduction.html)
- [x] Doxygen docs
- [x] Unit tests
- [x] No unwanted commits/changes
- [x] Descriptive title/description
- [x] PR is single purpose
- [x] Related issue listed
- [x] Comments in source
- [x] No typos
- [x] Update changelog
- [x] Not work-in-progress
- [x] External references or docs updated
- [x] Self review of PR done
- [] Any breaking changes?
* add support for non public scope for secret client credential
* improve function comments
* update tests with good url
* update secret url tests
* update logic to no-throw
* use class
* Update sdk/core/azure-core/inc/azure/core/http/policies/policy.hpp
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* format
* fix
* remove default scope
* move patch out of Core to use package-per-client patch
* update includes
* Update sdk/keyvault/azure-security-keyvault-keys/CHANGELOG.md
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* update patch
Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
* playback tests
* two running tests
* more tests and some redaction
* formatting
* formatting
* fix bb and remove unused includes
* macos
* annoying issues
* offline client
* format
* pr comment
* reset the env to original after the client is gone.
* oops
* testing
* formats
* remove default resource for secrets, not needed
* code coverage
* build issue
* first set of changes
* another set
* add new constructor
* format files, remove pedantinc ;
* factory
* format
* expect_death not behaving as expected
Trying to reduce the noise to signal ratio and manage GitHub notifications to when I am explicitly tagged for relevant reviews and conversations, rather than during day-to-day keyvault code churn and features.
* ignore result of function
* changelog
* Add g++5 to CI legs
* use inline config for g++ 5
* update flag
* set default values for variables
* fix format
* Stress test deployment script resiliency fixes
* Use PSModule-Helpers to install powershell-yaml
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
* More logging, faster matrix
* Verbose makefile
* Add code that is expected to cause failure
* Use clang with Ubuntu 20
* Install clang-format-11 in another step
* Revert "Add code that is expected to cause failure"
This reverts commit 7ff7201e1b81e17c168b7598f0d23c489b5e6f43.
* Remove cmake args, add build args -j
* Attempt to purge all vaults, managed HSMs
Reverts #1910. Vaults and managed HSMs are automatically purged on their purge date. The point was to purge them daily to preserve capacity. The default purge date is +90 days.
* Add timeout and more logging
* Pass required -Resource
* Fix log message
* Ensure the $Resource is correctly captured
Added comment to new code explaining why, since ScriptBlock.GetNewClosure() is not working as expected.
* Add -ErrorAction to Receive-Job
Worked without terminating when run locally, but failed on the first error in the AzDO agent.
* Use $using:r instead of creating ScriptBlock
More idiomatic for passing ScriptBlocks to jobs.
* Resolve PR feedback
* Change default DeleteAfterHours to 120
Resolves#1917
* Use the Az cmdlets built-in -AsJob
Co-authored-by: Heath Stewart <heaths@microsoft.com>
