Spell Check Phase 2 (#2794)

* Formatting

* Add cpp to dictionaries, comment to words section, and opted-out paths for spell checking

* Enable blocking of PRs on spelling error

.vscode/cspell.json

@@ -2,8 +2,27 @@
   "version": "0.1",
   "language": "en",
   "languageId": "cpp",
-  "dictionaries": ["powershell"],
-  "ignorePaths": ["vcpkg/**/*", "*.exe", "*.a", "*.lib", ".vscode/cspell.json", "json.hpp", "*nlohmann-json*"],
+  "dictionaries": [
+    "powershell",
+    "cpp"
+  ],
+  "ignorePaths": [
+    "vcpkg/**/*",
+    "*.exe",
+    "*.a",
+    "*.lib",
+    ".vscode/cspell.json",
+    "eng/common/**/*",
+    "json.hpp",
+    "*nlohmann-json*",
+    "sdk/identity/**/*",
+    "sdk/core/**/*",
+    "sdk/keyvault/**/*",
+    "sdk/storage/**/*"
+  ],
+  // * Unless configured otherwise, these words are not case sensitive
+  // * Alphabetize the list when making changes so the list is easier for future
+  //   users to maintain and reason about.
   "words": [
     "ABFS",
     "ABNF",
@@ -85,28 +104,42 @@
   "overrides": [
     {
       "filename": "**/eng/pipelines/templates/jobs/archetype-sdk-client.yml",
-      "words": ["lcov", "iname"]
+      "words": [
+        "lcov",
+        "iname"
+      ]
     },
     {
       "filename": "**/sdk/storage/azure-storage-common/src/crypt.cpp",
-      "words": ["wdata"]
+      "words": [
+        "wdata"
+      ]
     },
     {
       "filename": "**/sdk/storage/azure-storage-files-shares/inc/azure/storage/files/shares/share_options.hpp",
-      "words": ["dacl"]
+      "words": [
+        "dacl"
+      ]
     },
     {
       "filename": "**/sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/protocol/blob_rest_client.hpp",
-      "words": ["xmsblobsequencenumber"]
+      "words": [
+        "xmsblobsequencenumber"
+      ]
     },
     {
       "filename": "**/sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/key_client_models.hpp",
-      "words": ["SECG", "SECP"]
+      "words": [
+        "SECG",
+        "SECP"
+      ]
     },
     {
       "filename": "**/sdk/storage/azure-storage-common/test/test_base.hpp",
-      "words": ["FQJQ"]
+      "words": [
+        "FQJQ"
+      ]
     }
   ],
   "allowCompoundWords": true
-}
+}

eng/pipelines/templates/jobs/archetype-sdk-client.yml

@@ -279,6 +279,8 @@ jobs:
       VCPKG_DEFAULT_TRIPLET: 'x64-windows-static'
     steps:
       - template: /eng/common/pipelines/templates/steps/check-spelling.yml
+        parameters:
+          ContinueOnError: false
 
       - template: /eng/common/pipelines/templates/steps/verify-links.yml
         parameters: