Commit Graph

644 Commits

Author SHA1 Message Date
Victor Vazquez
8bf8ebb53c
fix msvc static checks (#1829) 2021-03-10 07:07:01 +00:00
Ahson Khan
2213991d52
Remove BUILD_ENV_LOGGER cmake option and always honor AZURE_LOG_LEVEL env var, if set. (#1827) 2021-03-09 23:05:00 -08:00
Victor Vazquez
a4110e44e2
throw when rawResponse was extracted (#1825)
* throw when rawResponse was extracted
2021-03-09 21:50:08 -08:00
Anton Kolesnyk
bc564dbddd
Namespaces renamed: Details => _detail, Internal => _internal (#1823) 2021-03-09 18:05:47 -08:00
Victor Vazquez
931cb76e82
update tests from core to run together (#1818) 2021-03-09 22:42:15 +00:00
Ahson Khan
dd3c79c9b4
Make sure DateTime.ToString() works without requiring additional parameters by choosing RFC 3339 as the default. (#1812)
* Make sure DateTime.ToString() works without requiring additional parameters by choosing RFC 3339 as the default.

* Address naming feedback and add some tests.

* Fix test warning by using static cast.
2021-03-09 13:29:20 -08:00
Victor Vazquez
6582d3a6dc
moving pipeline from azure core internal to azure core http internal (#1821) 2021-03-09 12:02:44 -08:00
Victor Vazquez
e4b5b806d0
Move Azure::MatchConditions and Azure::ModifiedConditions (#1810)
Move `Azure::MatchConditions` and `Azure::ModifiedConditions` (#1810)
2021-03-09 01:45:22 +00:00
Victor Vazquez
a70be6a49c
Moving ETag to ::Azure (#1801)
etag rename
2021-03-08 16:05:18 -08:00
Ahson Khan
41a3b4c429
Fixing ci yml be making sure the comment starts with # (#1813)
Fixes typo from https://github.com/Azure/azure-sdk-for-cpp/pull/1800#discussion_r589725726
2021-03-08 22:17:23 +00:00
Victor Vazquez
04d8508e07
Move Response<T> to Azure:: (#1800)
* Move Response<T> to Azure
2021-03-08 21:19:17 +00:00
Casey Carter
32314ac993
Typo in "associated" (#1811) 2021-03-08 12:05:45 -08:00
Rick Winter
e7e2ea8bb5
Move Version out of the Details namespace (#1809)
* Move Version out of the Details namespace
SDKVersion strings for each package are not a detail and can be used by customers.

* Add changelog
2021-03-08 10:21:25 -08:00
Anton Kolesnyk
6b83c85154
Fix build on VS2017 (#1808)
* VS2017 is right, we should be including `<iterator>`, if we use `std::inserter`. It fails to compile on VS2017 without that include.
Why if fails on 2017 and not 2019? Some of the other stdlib headers we include must be including `<iterator>` indirectly in 2019. But we should not be relying on that. Standard says, you use `std::inserter` - include `<iterator>`, if it works without that, that's a coincidence which may break beween versions of stdlib/compilers.

* VS 2017 does not fail because we don't include `<type_taits>` here, but formally we should include it too, because we use 
`std::remove_reference` and `std::remove_const`. It just happens that `log.hpp` includes it, but we should not be relying on that.

This was found during local vcpkg verification - I happen to have it configured targeting VS2017. It does not mean it will fail in vcpkg CI, or would affect many customers, but some for sure. Verification on vcpkg CI looks good - https://github.com/microsoft/vcpkg/pull/16578 (it is based on our master as of Sat 3/6 + this fix).
I verified locally that it builds successfully on `x64-windows`, `x64-windows-static`, and `arm-uwp`.

We should run verification once again, once we have all the renames/moves in master.
2021-03-07 02:04:25 +00:00
JinmingHu
45055dc9ef
use new HttpPipeline builder (#1784) 2021-03-07 10:03:08 +08:00
JinmingHu
01ae3714f1
return rawresponse for copy operation (#1807)
* return rawresponse for copy operation

* also for file copy

* remove noexcept
2021-03-06 08:26:34 +00:00
Rick Winter
9dedcb0d4c
Operations need to provide the RawResponse (#1803)
* Operations should expose the RawResposne
Added the pure virtual method
2021-03-05 20:33:14 -08:00
Victor Vazquez
401dbfe448
Fix context for unique (#1796)
* fix for Context to support unique ptr
2021-03-05 16:09:04 -08:00
Ahson Khan
11a533a6fd
For consistency within the SDK, move Azure::Core::Context to be the last parameter for various Azure::Core APIs. (#1779)
* For consistency within the SDK, move Azure::Core::Context to be the last
parameter for various Azure::Core APIs.

* Fix merge conflict due to log policy file change.

* Update new client options tests
2021-03-05 14:39:57 -08:00
Anton Kolesnyk
622e8da4fe
API Review Feedback: Logging and DateTime updates (#1752) 2021-03-05 12:16:14 -08:00
Victor Vazquez
501a98276b
fix for moving and copying client options (#1788) 2021-03-05 08:26:30 +00:00
JinmingHu
d6e88c2603
remove response<void> (#1785)
* not return response<void> anymore

* remove response<void> template specialization

* changelog
2021-03-05 05:54:07 +00:00
Victor Vazquez
35e7f292fc
fix wrong doc (#1783) 2021-03-04 21:47:19 -08:00
Victor Vazquez
16eb5710d1
Rename add headers (#1750)
* Rename AddHeader to SetHeader
2021-03-04 22:09:22 +00:00
Victor Vazquez
92e680b6af
make per call and per operation policies public (#1771) 2021-03-04 13:48:44 -08:00
JinmingHu
813980da8f
use AccessCondition provided by Azure::Core (#1775) 2021-03-04 13:27:56 -08:00
Victor Vazquez
78b9a87278
Client base options on Azure Core (#1734)
Add client options base class
construct pipeline from Core
2021-03-03 15:25:28 -08:00
Victor Vazquez
a5ff474118
Http request counter (#1738)
* Add counter to request about the retry number using the Context
2021-03-03 20:51:19 +00:00
Victor Vazquez
c01efb4d0f
Keyvault create keys overloads createKey for RSA, EC and Oct (#1726)
overload operations for create
2021-03-02 15:48:54 -08:00
Rick Winter
9ad38383fe
Make ModifiedConditions Nullable. (#1761)
* Make ModifiedConditions Nullable.
Add access helpers for Nullable.
2021-03-02 13:42:25 -08:00
Ahson Khan
a55aba01be
Moved BodyStream and its derived types from Azure::Core::Http namespace to Azure::IO, and update headers. (#1733)
* Moved `BodyStream` and its derived types from `Azure::Core::Http`
namespace to `Azure::IO`, and update headers.

* Fix up clang formatting.

* Add missing winhttp bodystream namespace change.

* Update merge conflict related changes.

* Update header paths in includes.
2021-03-01 11:33:26 -08:00
Anton Kolesnyk
fe2f0d6d85
Fix UWP build (#1756)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-02-26 17:47:37 -08:00
Anton Kolesnyk
ae575b0c08
CaseInsensitiveMap (#1731)
* Add CaseInsensitiveMap<T>

* Drop unneccessary namespace qualification

* Comment working: more accurate description

* GCC and Clang fix (typename specification) + doxy comments for template parameters

* Remove Allocator template parameter - we can add it later if we need it, currently no need to commit to having it there

* Drop <T> template parameter. We can add it later with default value of std::string without breaking change

* Unit test

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-02-26 08:38:01 -08:00
JinmingHu
624d81ed0f
Rename string conversion functions to ToString() (#1748)
* Get() -> ToString()

* changelog
2021-02-25 23:30:43 -08:00
JinmingHu
31c2234ee8
Operation<T> for copy API (#1747) 2021-02-26 06:19:38 +00:00
JinmingHu
50772fa2d2
return Operation<T> for copy blob API (#1736) 2021-02-26 04:48:17 +00:00
Victor Vazquez
5fdb9f4b5d
Remove null body stream (#1741)
* Remove LimitBodyStream
Move NullBodyStream to internal
2021-02-25 22:37:34 +00:00
Ahson Khan
d1e43af75e
Add LRO concept section to core, along with a sample snippet to help get started. (#1729)
* Add LRO concept section to core, along with a sample snippet to help get started.

* address feedback
2021-02-24 09:14:17 -08:00
Casey Carter
f9d4d36ad8
Defend public headers against inclusion of Windows.h (#1719)
* Defend public headers against inclusion of Windows.h

... which defines some nasty function-like macros `min` and `max` when `_NOMINMAX` isn't defined. We prevent expansion as a function-like macro by inserting some token(s) between `min`/`max` and the following `(`. Most commonly that means wrapping the entire qualified-name in `()` a la `(std::min)(x, y)`, but an explicit template argument list (`std::min<int>(x, y)`) works as well.

* clang-format all the things

* Test coverage

I assume that the `azure-meow-common` headers are fully covered by the tests for the `azure-meow-woof` SDKs.
2021-02-23 09:56:00 -08:00
Victor Vazquez
b7de24483a
Rename and structure unit test and perf tests (#1706)
* Rename and structure unit test and perf tests
2021-02-23 05:55:12 +00:00
Victor Vazquez
f9eea4d22d
Adding missing documentation for key vault keys (#1700)
* Adding missing documentation for key vault keys
2021-02-22 16:09:36 -08:00
Ahson Khan
0dfe2f498d
Throw a logic error when calling Rewind on unsupported BodyStreams and update the exception message to be actionable. (#1713)
* Throw a runtime error when calling Rewind on unsupported BodyStreams and update the exception message.

* Add rewind test for bodystream.

* Change exception type from runtime to logic.

* Add necessary platform specific headers.
2021-02-22 12:26:51 -08:00
Ahson Khan
97b0ccf79b
Make sure to rewind the body stream at the start of each request retry attempt. (#1712)
* Make sure to rewind the body stream at the start of each request retry attempt.

* Add change log entry

* Add request start try unit test
2021-02-22 12:18:34 -08:00
Rick Winter
50efbdb4c0
Add holder for registry handle to ensure cleanup of native resources. (#1711)
Add a holder for the registry key to ensure it is always cleaned up when it goes out of scope.
Exceptions should be caught as const.
2021-02-22 17:48:28 +00:00
JinmingHu
249327a3fa
Refactor pipeline building logic, add support for customized application id and API version (#1703)
* refactor pipeline build code

* Changelog

* fix build error

* fix bug

* fix ut

* changelog
2021-02-20 09:13:20 +08:00
JinmingHu
5c2d0fba17
remove unused stuff (#1701) 2021-02-19 14:53:04 +08:00
Anton Kolesnyk
bf347d24c2
Disable compiler extensions, fix Clang options to have effect, fix warnings (#1615)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-02-18 19:15:11 -08:00
Victor Vazquez
e9cf40505b
Performance projects for services (#1655)
* add test metadata to the tests for the perf fw
2021-02-18 21:05:22 +00:00
Victor Vazquez
cea5e03a17
Keyvault adding delete key (#1675)
Adding delete key operation
2021-02-18 09:36:13 +00:00
Victor Vazquez
5f523f7030
update noRevoke (#1678)
* update noRevoke

* use EnableCertificateRevocationListCheck instead of Disable
2021-02-18 02:16:22 +00:00