github/azure-sdk-for-cpp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Move Version out of the Details namespace (#1809)

Browse Source 
* Move Version out of the Details namespace
SDKVersion strings for each package are not a detail and can be used by customers.

* Add changelog
This commit is contained in:
Rick Winter 2021-03-08 10:21:25 -08:00 committed by GitHub
parent 6b83c85154
commit e7e2ea8bb5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sdk/core/azure-core/CHANGELOG.md
View File

@ -15,6 +15,7 @@
- Renamed `NoRevoke` to `EnableCertificateRevocationListCheck` for `Azure::Core::Http::CurlTransportSSLOptions`.
- Renamed `GetString()` to `ToString()` in `Azure::Core::DateTime`.
- Renamed `GetUuidString()` to `ToString()` in `Azure::Core::Uuid`.
- Moved `Version` from `Azure::Core::Details` to `Azure::Core`.
- Moved `BodyStream` and its derived types from `Azure::Core::Http` namespace to `Azure::IO`, and moved the `body_stream.hpp` header from `azure/core/http` to `azure/core/io`.
- Moved `NullBodyStream` to internal usage only. It is not meant for public use.
- Removed `LimitBodyStream`.

4
sdk/core/azure-core/inc/azure/core/version.hpp
View File

@ -17,7 +17,7 @@
#define AZURE_CORE_VERSION_PATCH 0
#define AZURE_CORE_VERSION_PRERELEASE "beta.7"
namespace Azure { namespace Core { namespace Details {
namespace Azure { namespace Core {
/**
* @brief Provides version information.
@ -48,7 +48,7 @@ namespace Azure { namespace Core { namespace Details {
static constexpr const char* secret = AZURE_CORE_VERSION_PRERELEASE;
};
}}} // namespace Azure::Core::Details
}} // namespace Azure::Core
#undef AZURE_CORE_VERSION_MAJOR
#undef AZURE_CORE_VERSION_MINOR

2
sdk/core/azure-core/src/version.cpp
View File

@ -6,7 +6,7 @@
#include <sstream>
#include <string>
using namespace Azure::Core::Details;
using namespace Azure::Core;
const std::string Version::PreRelease = secret;

2
sdk/core/azure-core/test/ut/simplified_header.cpp
View File

@ -44,7 +44,7 @@ TEST(SimplifiedHeader, core)
EXPECT_NO_THROW(Azure::Core::Uuid::CreateUuid());
EXPECT_NO_THROW(Azure::Core::RequestFailedException("foo"));
EXPECT_NO_THROW(Azure::Core::OperationStatus("foo"));
EXPECT_NO_THROW(Azure::Core::Details::Version::VersionString());
EXPECT_NO_THROW(Azure::Core::Version::VersionString());
{
std::vector<uint8_t> buffer(10);

4
sdk/template/azure-template/inc/azure/template/version.hpp
View File

@ -12,7 +12,7 @@
#define AZURE_TEMPLATE_VERSION_PATCH 0
#define AZURE_TEMPLATE_VERSION_PRERELEASE "beta.25"
namespace Azure { namespace Template { namespace Details {
namespace Azure { namespace Template {
/**
* @brief Provides version information.
@ -43,7 +43,7 @@ namespace Azure { namespace Template { namespace Details {
static constexpr const char* secret = AZURE_TEMPLATE_VERSION_PRERELEASE;
};
}}} // namespace Azure::Template::Details
}} // namespace Azure::Template
#undef AZURE_TEMPLATE_VERSION_MAJOR
#undef AZURE_TEMPLATE_VERSION_MINOR

2
sdk/template/azure-template/src/template_client.cpp
View File

@ -8,4 +8,4 @@
using namespace Azure::Template;
std::string const TemplateClient::ClientVersion() { return Details::Version::VersionString(); }
std::string const TemplateClient::ClientVersion() { return Version::VersionString(); }

2
sdk/template/azure-template/src/version.cpp
View File

@ -5,7 +5,7 @@
#include <sstream>
#include <string>
using namespace Azure::Template::Details;
using namespace Azure::Template;
const std::string Version::PreRelease = secret;