Commit Graph

93 Commits

Author SHA1 Message Date
Victor Vazquez
141878670f
update variable to compile (#2373) 2021-06-01 10:03:51 -07:00
Anton Kolesnyk
15c525d387
Fix empty rethrows, update some catches to catch all (#2362)
* Fix empty rethrows, update some catches to catch all

* AZURE_UNREACHABLE_CODE()

Co-authored-by: JinmingHu <jinmhu@microsoft.com>

Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
Co-authored-by: JinmingHu <jinmhu@microsoft.com>
2021-05-28 09:24:42 -07:00
Anton Kolesnyk
78703658a2
Fix throw new (#2360)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-05-28 01:52:39 -07:00
Victor Vazquez
9e7fa34c34
Keyvault readme update (#2350)
* progress

* update keyvault keys readme

* Apply suggestions from code review

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2021-05-28 06:52:52 +00:00
Victor Vazquez
88dc1ac8cf
adding Test file sufix to all tests (#2337)
* azure core

* perf

* identity

* keyvault

* storage
2021-05-25 11:15:30 -07:00
Azure SDK Bot
069f753464
Increment version for keyvault releases (#2324)
* Increment package version after release of azure-security-keyvault-common

* Increment package version after release of azure-security-keyvault-keys
2021-05-21 13:37:48 -07:00
Ahson Khan
0a0bd6fbc2
Update changelog for the upcoming beta release. (#2309)
Holding off to do a review of the commits.

Area owners, please review yourself as well, and fix what might be missing or needs updating.
2021-05-19 04:31:36 +00:00
Ahson Khan
65821ec115
Use size_t for buffers representing data in memory rather than int64_t. (#2285)
* Use size_t for buffers representing data in memory rather than int64_t.

* add a cast from size_t to int64_t

* Address feedback - OnRead return size_t.

* Change Read and ReadToCount to return size_t instead of int64_t.

* Update curl usage and ReadFromSocket.

* Missed one signature.

* Update changelog.

* Update transport layer to use the right size_t size.

* Fix curl use of MBS.

* Cast to size_t since that's all memory stream supprts.

* Add static casts to size_t as temporary workarounds.

* update storage tests.

* More test fixes.
2021-05-18 18:51:20 -07:00
Ahson Khan
ff126f1eb7
Explore removing use of int within header files to align with guidelines. (#2276)
Part of https://github.com/Azure/azure-sdk-for-cpp/issues/2226

Trying to focus mainly on headers, depending on the conclusion, we'd want to make cpp file changes as well, but that can be done later.

Assuming this is the guideline we want:
https://azure.github.io/azure-sdk/cpp_implementation.html#integer-sizes

![image](https://user-images.githubusercontent.com/6527137/118341184-00d52580-b4d3-11eb-8e96-937cb5899c92.png)

Some places that we still use `int` is for things like unix file desriptor or where APIs like BIO_read from OpenSSL returns an int. Are those exceptions OK?
0b64ab3845/sdk/core/azure-core/inc/azure/core/io/body_stream.hpp (L166)
308e5363ad/sdk/core/azure-core/src/base64.cpp (L87)
2021-05-18 20:49:53 +00:00
Anton Kolesnyk
00dfcc2beb
Doxygen comment updates (#2280) 2021-05-17 17:05:06 -07:00
Anton Kolesnyk
efe4772acb
Update upper/lower/other casing (#2267)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-05-14 12:54:16 -07:00
Anton Kolesnyk
00c47e8ec3
Delete vcpkg readme (#2268)
Co-authored-by: Anton Kolesnyk <antkmsft@users.noreply.github.com>
2021-05-14 12:53:59 -07:00
Victor Vazquez
f4febae12c
missing line for single docs (#2264)
* missing line for single docs

* format
2021-05-13 17:41:48 -07:00
Anton Kolesnyk
530e49b217
Document final/virtual destructor changes (#2256) 2021-05-12 11:38:17 -07:00
Anton Kolesnyk
019db35863
Add final specifier (#2237) 2021-05-10 11:57:40 -07:00
Victor Vazquez
1a71c46cbd
[Key Vault Keys] Cryptography client - Encrypt/Decrypt/Wrap/Unwrap/Sing/Verify (#2140) 2021-05-07 21:49:11 +00:00
Ahson Khan
fd9c3e5ebb
Fix true spelling errors across all source and header files within the SDK and add exceptions for false positives. (#2209)
Part of https://github.com/Azure/azure-sdk-for-cpp/issues/1277, checking what types of warnings the CI emits.

Verified all SDK product `.cpp`, `.hpp`, `.txt`, and `.md` files, primarily focused on azure-core. They are all clean now. There are some exceptions that needs to be added for keyvault and storage, but they are false positives, so not a concern.

> `cspell lint --config .vscode/cspell.json *.hpp */**/*.hpp`

CSpell: Files checked: 188, Issues found: 0 in 0 files

> `cspell lint --config .vscode/cspell.json *.cpp */**/*.cpp`

CSpell: Files checked: 186, Issues found: 88 in 15 files (keyvault and storage false positives, or tests)

> `cspell lint --config .vscode/cspell.json *.md */**/*.md`

CSpell: Files checked: 45, Issues found: 5 in 2 files (eng/common)

> `cspell lint --config .vscode/cspell.json *.txt */**/*.txt`

CSpell: Files checked: 44, Issues found: 0 in 0 files

> `cspell lint --config .vscode/cspell.json *.* */**/*`

CSpell: Files checked: 646, Issues found: 328 in 69 files (most of these are in eng\docs\api\assets\style.css or eng/common)

Deprioritize and ignored the errors from the test files (including test resource json files), and `eng/common` since those need to be centrally fixed.
2021-05-07 21:04:58 +00:00
Victor Vazquez
10d244e511
LRO operation resume token - following factory method design (#2195)
* Add tests for resume token pattern

* update deleteKeyOperation
2021-05-05 23:14:31 +00:00
Anton Kolesnyk
d69742ae10
Context::GetApplicationContext() => Context::ApplicationContext (#2178) 2021-05-04 15:26:33 -07:00
Anton Kolesnyk
cd36753d76
PackageVersion made constexpr and moved to src/package_version.hpp (#2166) 2021-04-28 17:34:24 -07:00
Victor Vazquez
c82f0e8efc
Rename paged models from key vault (#2160)
rename pageable APIs and models from keyvault
2021-04-28 17:49:47 +00:00
Victor Vazquez
fe9002e905
Moving Pageble<T> to Core and updating KeyVault to use it (#2144)
* updated getDeletedKeys

* pagable for list keys
2021-04-27 02:44:03 +00:00
Anton Kolesnyk
698e9965c5
VcPkg: format json manifest files (#2151) 2021-04-22 17:37:44 -07:00
Anton Kolesnyk
fdfc915565
VcPkg manifest tweaks (#2149) 2021-04-22 12:27:56 -07:00
Anton Kolesnyk
23f98744ba
VcPkg: use version-semver (#2138) 2021-04-20 11:41:19 -07:00
Anton Kolesnyk
ba714bebd1
VcPkg files: Simplify header comment handling (#2135) 2021-04-20 01:01:16 +00:00
Ahson Khan
d452e94337
Update vcpkg ports to use a manifest json file instead of a CONTROL file. (#2132)
* Update vcpkg ports to use a manifest json file instead of a CONTROL file.

* Update vcpkg ports to use a manifest json file instead of a CONTROL file
for remaining packages.

* Add the new vcpkg manifet json files and also update the template
package.

* Update paths in the cmake and eng scripts to find the right file now
that CONTROL is gone.
2021-04-19 12:50:50 -07:00
Victor Vazquez
b87bda520a
based on code -rev from https://github.com/Azure/azure-sdk-for-cpp/pull/2117 (#2125)
* based on code -rev

* remove non-required method

* Update sdk/keyvault/azure-security-keyvault-keys/inc/azure/keyvault/keys/key_type.hpp
2021-04-16 21:00:24 +00:00
Victor Vazquez
fbe7d51349
Keyvault api review beta.1 updates (#2117)
* Remove to_json for jsonWebKey

* parse N

* Deserialize JWK for EC and OCT

* change log

* format

* fix live tests

* remove KeyVaultException

* Remove clientOptions from keyvault common

* use ext enum pattern

* rename JsonWebKeyType to KeyVaultKeyType

* Move singlePage base classes to shared internal

* rename maxResults

* format

* missing rename

* minor

* fix doxygen

* Make Service Version an ext enum
2021-04-15 11:53:45 -07:00
Victor Vazquez
ce4b285ddd
[Keyvault] operation resume token fix (#2093)
Enable resume operations for keyvault
2021-04-14 18:55:09 +00:00
Victor Vazquez
1ea5afa961
Jwk deserialize (#2087)
* Remove to_json for jsonWebKey

* parse N

* Deserialize JWK for EC and OCT

* change log

* format

* fix live tests
2021-04-14 11:41:05 -07:00
Victor Vazquez
5de76e7a21
Fix for Azure Core with libcurl. clean up and global clean up (#1500)
make SDK to call global_init and global_cleanup
2021-04-08 22:55:26 +00:00
Azure SDK Bot
ff0d5a18cd
Increment version for keyvault releases (#2084)
* Increment package version after release of azure-security-keyvault-common

* Increment package version after release of azure-security-keyvault-keys

Co-authored-by: Ahson Khan <ahson_ahmedk@yahoo.com>
2021-04-08 01:19:03 +00:00
Victor Vazquez
fae04fa9d2
Keyvault changelog (#2071)
* update chanlog for KeyVault release
2021-04-07 16:33:33 -07:00
Ahson Khan
304300c928
Removed GetUrlWithoutQuery() and GetUrlAuthorityWithScheme() from Azure::Core::Url and added GetScheme(). (#2055)
* Removed GetUrlWithoutQuery() and GetUrlAuthorityWithScheme() from
Azure::Core::Url and added GetScheme().

* Address PR feedback.
2021-04-07 01:48:33 +00:00
Ahson Khan
d638d1ff3d
Move package version to details, and rename VersionString() to ToString(). (#2042) 2021-04-06 00:50:25 +00:00
Ahson Khan
63b2d21bc6
Renamed Azure::Nullable<T>::GetValue() to Value(). (#2034)
* Renamed `Azure::Nullable<T>::GetValue()` to `Value()`.

* Update clang formatting.
2021-04-05 15:42:14 -07:00
Victor Vazquez
dfdaf25223
[Core] Refactor RequestFailedException with Http information (#2026)
* KeyVault Exception
2021-04-05 12:11:31 -07:00
Victor Vazquez
308e5363ad
remove the common namespace from keyvault (#2029) 2021-04-02 06:02:23 +00:00
Victor Vazquez
2348ad9d5a
update links for samples (#2021) 2021-04-02 05:03:28 +00:00
Ahson Khan
80e61d8929
Add a forward slash at the end of the key vault URL to match what the portal returns. (#2017)
* Add a forward slash at the end of the key vault URL to match what the portal returns.

* Don't add the extra `/` in the expected token within tests.

* Fix another instance of extra `/`.

Co-authored-by: Anton Kolesnyk <41349689+antkmsft@users.noreply.github.com>
2021-04-01 01:21:50 -07:00
Ahson Khan
0a68af6c1f
Add error checking around std::getenv for KeyVault tests (#2019)
* Add error checking around std::getenv for KeyVault tests

* Revert unrelated change.
2021-04-01 03:43:16 +00:00
Ahson Khan
8095d85e67
Simplify the public surface design of Response<T> for usability. (#1974)
* Simplify the design of Response<T> for usability.

* Revert changes to operation<T> to keep the changes single purpose.

* Update many of the response<T> call sites based on API changes.

* Update all remaining callsites and fix clang formatting.

* Update Response<T> documentation.

* Fix clang formatting.

* Remove status code from the Response<T> public surface area.

* Update the changelog.

* Fix up CL wording and remove commented-out change to operation<T>.

* Fixed test by actually calling a method.

* Fix up key vault test by not taking ownership of raw response.

* Fix call to get status code in test.

* Add new line at end of keyvualt live test file.

* Make a local copy within keyvault pipeline to avoid compilers re-ordering things.

* Make the fixes to the recent keyvault changes.

* Fix key vault pipeline to address ImportKey test failure
2021-04-01 00:50:04 +00:00
Anton Kolesnyk
ddd7a093f4
Move policies to internal (#1985) 2021-03-31 12:56:33 -07:00
Victor Vazquez
a4ae81708b
[Keyvault] APIs (#1967)
Adding the next APIs:

UpdateKeyProperties, fixes: #1541
GetPropertiesOfKeys , fixes: #1542
GetPropertiesOfKeyVersions, fixes: #1543
GetDeletedKeys, fixes: #1546
PurgeDeletedKey, fixes: #1547
StartRecoveryDeletedKey, fixes: #1548
BackupKey, fixes: #1549
RestoreKeyBackup, fixes: #1550
ImportKey, fixes: #1551
Add samples, fixes: #1987
2021-03-30 20:12:48 +00:00
Anton Kolesnyk
0665efe0fe
unique_ptr Get() => Extract() || Send() || ExtractOrCreate() (#1984) 2021-03-30 10:17:24 -07:00
Victor Vazquez
a5bc8fe0ef
Adding GetDeletedKey (#1907)
* Adding GetDeletedKey
2021-03-17 18:15:35 +00:00
Victor Vazquez
6c5e487f6d
fix pollInternal implementation (#1892) 2021-03-12 16:22:34 -08:00
Victor Vazquez
42a67b1349
Moving GetRawResponseInternal out of public from Operation derived classes (#1890) 2021-03-12 12:31:01 -08:00
Victor Vazquez
825d4f11d5
make poll return const ref to rawResponse (#1875)
* make poll return const ref to rawResponse
2021-03-12 03:18:47 +00:00